bringing sitemap and menu to CoreWebForm #265
Conversation
src/WebForms/SiteMapProvider.cs
Outdated
| { | ||
| Page page = context.GetRequiredFeature<IHttpHandlerFeature>().Current as Page; | ||
|
|
||
| //TODO check with @taylor |
There was a problem hiding this comment.
@twsouthwick take a look if there is a better way
There was a problem hiding this comment.
Can you add an extension method for Page? GetCurrentPage(this HttpContext context)?
There was a problem hiding this comment.
You can now use context.AsSystemWeb().CurrentHandler now
src/WebForms/UI/Control.cs
Outdated
| AdapterInternal = null; | ||
|
|
||
| //TODO create issue | ||
| #if GetAdapter_BrowserCapabilities |
There was a problem hiding this comment.
@twsouthwick should we handle here or in the adapter ?
There was a problem hiding this comment.
create an issue here and mark this with PORT_BROWSERCAPABILITIES - I like the PORT_ prefix for easily identifiying what's needed
|
|
||
| // https://github.com/dotnet/systemweb-adapters/issues/497 | ||
|
|
||
| // if (Page.Request.Browser.RequiresUniqueFilePathSuffix) |
There was a problem hiding this comment.
will create an internal issue
| return null; | ||
|
|
||
| #if PORT_GetGlobalResourceProvider | ||
| // throw new NotImplementedException(); |
There was a problem hiding this comment.
for times like this, use HttpRuntimeHelper.GetLogger<> to get a logger to message things out
| </siteMap> | ||
| */ | ||
|
|
||
| public sealed class SiteMapSection : ConfigurationSection |
There was a problem hiding this comment.
make this internal, and I'd like to see a follow up that removes the config stuff and replaces it with an option
3fd3d38 to
75e65ff
Compare
|
@birojnayak are you still planning on pushing this through? |
|
@twsouthwick yes.. give me sometime. |
d67c855 to
eb250c7
Compare
twsouthwick
left a comment
There was a problem hiding this comment.
just a couple of visibility things then LGTM
| namespace System.Web.Configuration | ||
| { | ||
|
|
||
| public static class ProvidersHelper { |
There was a problem hiding this comment.
I don't want any of the config stuff brought in. As an initial port, bringing it in as internal is fine but make sure to follow up with removing it
src/WebForms/Extensions.cs
Outdated
| return request.CurrentExecutionFilePath; | ||
| } | ||
|
|
||
| public static Page GetCurrentPage(this HttpContext context) => context.GetRequiredFeature<IHttpHandlerFeature>().Current as Page; |
There was a problem hiding this comment.
you can use context.CurrentHandler now
| _context.WriteLine($"Wrote result to {tempPath}"); | ||
|
|
||
| Assert.AreEqual(expectedHtml.ReplaceLineEndings(), result.ReplaceLineEndings()); | ||
| //TODO avoid this check, needed for Viewstate |
There was a problem hiding this comment.
can you create an issue to follow up here?
1a95357 to
69945ad
Compare
69945ad to
2a2c24b
Compare
|
Please make sure the created issues aren't just "can you create an issue for this" - specify what needs to be done and link it to the tracking issue |
read the title of the issue... :) |
|
Yes but the content of the issue should be standalone. Still has my request in there which does not make sense to have |
|
Also on such a large pr force pushes make it difficult to do incremental reviews - we'll squash at the end so just pushing fixes allow me to quickly verify things are updated. I now have to go through the whole thing again |
will keep this in mind @twsouthwick .. |
bringing sitemap and menu to CoreWebForm.
Initially it would bring basic required components for #261