Use same assembly name for both compilation and file name #306
Conversation
twsouthwick
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think we should be passing the assembly name in instead of assuming the typename is the right thing
| @@ -73,21 +73,21 @@ private sealed class PersistedCompilation(StaticCompilationOptions options) : IC | |||
| public bool HandleExceptions => false; | |||
|
|
|||
| Stream ICompilationStrategy.CreatePdbStream(string route, string typeName) | |||
There was a problem hiding this comment.
hmmm if this works, that seems like a coincidence. Maybe add a new parameter "assemblyName" to the ICompilationStrategy to make sure we're keeping everything in sync.
There was a problem hiding this comment.
I initially used this method as it required the least amount of changes. I can redo it to modify CreatePdbStream and CreatePeStream to pass in an assembly name instead. At the point it is used in SystemWebCompilation.CreateCompiledPage, compilation.Assemblyname is available, so it should be simple.
There was a problem hiding this comment.
sounds good - I imagine we can simplify it later, but for now more explicit the better :)
|
LGTM - once ci finishes, I'll merge |
Fixes #305
Currently, the compilation uses an assembly name derived from the name of the type for the page, while the assembly name for the file name is derived from the page's default route. Because these names are different, an error occurs attempting to load the assembly, which expects the compiled assembly name to match the file name.
This pull request attempts to remedy this by using the same assembly name for the file name that is currently being used for the compilation.