Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@birojnayak
Copy link
Collaborator

Before AJAX toolkit works as-is, we need to port JavaScript Serializer as we don't want to touch the AJAX toolkit and change the serializer. So below PR ports the JS serializer #403 .

Here are the foundations,

  • Ported public API's to keep the backward compatibility as is. But under the hood changed to use STJ(System.Text.JSON)
  • Added Serializer Converter Factory to ensure RegisterConverter (backward API) works else default to STJ.
  • Added Custom Deserializer to ensure backward compatibility works, else default to STJ.
  • ObjectConverter class ported to keep backward compatible.
  • Added Test project with unit tests. (Let's keep adding more unit tests as we write more code)

@birojnayak birojnayak requested a review from twsouthwick March 2, 2025 07:01
Copy link
Collaborator

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! A few comments and requests, but overall pretty close. Thanks!

@birojnayak birojnayak force-pushed the JavaScriptSerializer branch from 599e997 to 4e9a543 Compare March 3, 2025 23:31
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Test Results

21 tests  ±0   18 ✅ ±0   19s ⏱️ +4s
 2 suites ±0    3 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit be6dd6d. ± Comparison against base commit 9d010aa.

♻️ This comment has been updated with latest results.

@birojnayak birojnayak force-pushed the JavaScriptSerializer branch from 4e9a543 to 0b0adce Compare March 4, 2025 06:28
@twsouthwick
Copy link
Collaborator

Here's an example of what I mean by caching the options and using that as the source of truth: 7f6ee94

@twsouthwick
Copy link
Collaborator

@birojnayak birojnayak force-pushed the JavaScriptSerializer branch 2 times, most recently from 3ea4963 to bf711d8 Compare March 4, 2025 22:52
Copy link
Collaborator

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a couple nits. Once you clean those up, feel free to merge in

@birojnayak birojnayak force-pushed the JavaScriptSerializer branch from bf711d8 to be6dd6d Compare March 5, 2025 05:41
@birojnayak birojnayak merged commit 510db15 into main Mar 5, 2025
9 checks passed
@birojnayak birojnayak deleted the JavaScriptSerializer branch March 5, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants