-
Notifications
You must be signed in to change notification settings - Fork 17
JavaScript serializer porting #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
twsouthwick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! A few comments and requests, but overall pretty close. Thanks!
src/Extensions/Script/Serialization/CustomSerializerJsonConverter.cs
Outdated
Show resolved
Hide resolved
599e997 to
4e9a543
Compare
src/Extensions/Script/Serialization/CustomSerializerJsonConverter.cs
Outdated
Show resolved
Hide resolved
4e9a543 to
0b0adce
Compare
|
Here's an example of what I mean by caching the options and using that as the source of truth: 7f6ee94 |
|
actually - see this: https://github.com/CoreWebForms/CoreWebForms/compare/JavaScriptSerializer...jserializer?expand=1. It's a bit simpler |
3ea4963 to
bf711d8
Compare
twsouthwick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo a couple nits. Once you clean those up, feel free to merge in
bf711d8 to
be6dd6d
Compare
Before AJAX toolkit works as-is, we need to port JavaScript Serializer as we don't want to touch the AJAX toolkit and change the serializer. So below PR ports the JS serializer #403 .
Here are the foundations,