Test Results

21 tests  ±0   18 ✅ ±0   20s ⏱️ +7s
 2 suites ±0    3 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit a391942. ± Comparison against base commit 8902767.

♻️ This comment has been updated with latest results.

let me take this change locally and test the ajax toolkit controls before shipping...

PR Overview

This PR implements a new mechanism for loading controls by detecting assemblies with tag prefixes. Key changes include:

* Replacing the lazy-loaded assembly management with immediate initialization and control scanning in DynamicControlCollection.

* Updating the attribute lookup in WebForms-related files to use a generic extension method (HasAttribute).

* Adjusting the StaticControlCollection to use the generic attribute check and marking helper methods as static.

Reviewed Changes

File Description
src/Compiler.Dynamic/DynamicControlCollection.cs Refactors assembly loading by introducing Initialize, SearchForControls, and LoadMetadataReference methods, and switches to using ImmutableDictionary-based storage for controls and metadata references.
src/WebForms/AssemblyAttributeUtility.cs Replaces the string-based attribute lookup with a new generic version for improved type-safety.
src/WebForms/PreApplicationStartMethodExtensions.cs Updates the attribute check to use the new generic HasAttribute method.
src/Compiler.Dynamic/StaticControlCollection.cs Updates the control scanning logic to use the generic HasAttribute method and marks the helper method static.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)

too much verbose ... ha ha..

So we are able to detect the TagPrefixAttribute via HasControls for assembly present in the bin folder. But those are never added to _controls because the CurrentDomain_AssemblyLoad never gets called for dll which are part of the bin folder. So I added explicitly after _context.LoadFromAssemblyPath(file); , but in the WebFormsCompilerExtension where we are reading assemblies to register tag, again it's failing. You can re-create using the sample https://github.com/birojnayak/CoreWebForms/tree/AJAXToolKit , just copy the accordion.aspx file and you can build ajaxtoolkit.dll from here

            .Configure<IMetadataProvider>((options, metadata) =>
            {
                foreach (var control in metadata.ControlAssemblies)
                {
                    foreach (var tag in control.GetCustomAttributes<TagPrefixAttribute>())
                    {
                        options.DefaultTagNamespaceRegisterEntries.Add(new(tag.TagPrefix, tag.NamespaceName, control.FullName));
                    }
                }
            });

It loads the WebForms.SqlClient library just fine this way so I do see it working. Can you create a branch that just works to try it out so I don't have to build extra things? i.e. include the .dll in the branch. I just want to just run it

It loads the WebForms.SqlClient library just fine this way so I do see it working. Can you create a branch that just works to try it out so I don't have to build extra things? i.e. include the .dll in the branch. I just want to just run it

ok.. let me do that..