Object data source #445
Object data source #445
Conversation
604a034 to
a172439
Compare
| } | ||
| } | ||
|
|
||
| if(type == null) |
There was a problem hiding this comment.
Taylor, this would be expensive (while in old System.Web also it would take same time or less). But if there is a better way, do let me know.. we can take a follow-up task or incorporate in this one. Probably this is the most imp piece in this PR (where I am looking some guidance)
There was a problem hiding this comment.
It's fine for now. If we need to, we can cache it somehow so it's not necessary if we're doing the same lookup a lot
twsouthwick
left a comment
There was a problem hiding this comment.
Why did you remove ajax.aspx? Other than that, LGTM
src/WebForms/WebForms.csproj
Outdated
| <PackageReference Include="System.CodeDom" Version="9.0.3" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.SystemWebAdapters" Version="2.0.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.SystemWebAdapters.CoreServices" Version="2.0.0" /> | ||
| <PackageReference Include="System.Drawing.Common" Version="9.0.3" /> |
There was a problem hiding this comment.
We had removed this before - what's requiring it? I'm fine adding it back but it would be nice to decouple it if possible
a172439 to
ca07579
Compare
put it back.. got confused why it was there ... |
ca07579 to
7c9b54e
Compare
Port the ObjectDataSource control.