Readme Update #136
Merged
Readme Update #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al-rigazzi
approved these changes
Feb 3, 2022
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
Very good job, just a couple of minor typos remaining, otherwise LGTM
Contributor
|
I ran Detailsdiff --git a/README.md b/README.md
index 3822d24..5cd9d8d 100644
--- a/README.md
+++ b/README.md
@@ -74,7 +74,7 @@ TODO: Check if new table is what is expected
<td>1.7.0</td>
</tr>
<tr>
- <td>Tensorlow\Keras</td>
+ <td>Tensorflow\Keras</td>
<td>2.5.2</td>
</tr>
<tr>
@@ -86,7 +86,7 @@ TODO: Check if new table is what is expected
<td>1.9.1</td>
</tr>
<tr>
- <td>Tensorlow\Keras</td>
+ <td>Tensorflow\Keras</td>
<td>2.6.2</td>
</tr>
<tr>
@@ -455,7 +455,7 @@ db_cluster = PBSOrchestrator(db_nodes=3, db_port=6780, batch=True,
exp.start(db_cluster)
print(f"Orchestrator launched on nodes: {db_cluster.hosts}")
-# launch models, anaylsis, training, inference sessions, etc
+# launch models, analysis, training, inference sessions, etc
# that communicate with the database using the SmartRedis clients
exp.stop(db_cluster)
@@ -598,7 +598,7 @@ scripts if there is no database for them to connect to.
The example below shows how to take a PyTorch model, send it to the Orchestrator, and
execute it on data stored within the database.
-Notice that when we set the model in the database, we set the device arguement to
+Notice that when we set the model in the database, we set the device argument to
**GPU**. By doing this we ensure that execution of the model takes place on a GPU if
one is available to the database.
@@ -927,7 +927,7 @@ TODO: Again confirm that this should be replaced with new table
<td>1.7.0</td>
</tr>
<tr>
- <td>Tensorlow\Keras</td>
+ <td>Tensorflow\Keras</td>
<td>2.5.2</td>
</tr>
<tr>
@@ -939,7 +939,7 @@ TODO: Again confirm that this should be replaced with new table
<td>1.9.1</td>
</tr>
<tr>
- <td>Tensorlow\Keras</td>
+ <td>Tensorflow\Keras</td>
<td>2.6.2</td>
</tr>
<tr> |
Member
Author
|
@ben-albrecht Thanks for the catch! Fixed in latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the SmartSim README for upcoming release.
create_run_settings,create_batch_settings)