RunSettings Set Method #166
Conversation
Spartee
left a comment
There was a problem hiding this comment.
Couple changes. Let me know your thoughts on the condition flag
Merge remote-tracking branch 'upstream/develop' into rs-set-arg
Spartee
left a comment
There was a problem hiding this comment.
Minor comments, mostly on docstrings. Great stuff!
smartsim/settings/base.py
Outdated
| rs = RunSettings("python") | ||
| rs.set("an-arg", "a-val") | ||
| rs.set("a-flag") | ||
| rs.run_args["an-arg"] # returns "a-val" |
There was a problem hiding this comment.
Ideally users shouldn't know that run_args exist now and solely use .set() if you want to show the arguments in the docstring then lets call a user facing method like RunSettings.format_run_args
There was a problem hiding this comment.
Does this mean that we should be moving run_args -> _run_args or is that considered out of scope for this PR?
There was a problem hiding this comment.
Leaving as is for now, fixed docstr in 4a10a76
smartsim/settings/base.py
Outdated
| """allows users to set individual run arguments. Does | ||
| basic formating such as stripping leading dashes. | ||
| This method also ensures that the argument being set |
There was a problem hiding this comment.
So we don't actually check that it IS valid. Lets just state that condition can be used to write scripts that will adapt under variables that can be changed at runtime. like, for example, the hostname one.
Spartee
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making those changes!
This PR implements a
RunSettings.setwhich is able to programmatically set run arguments:run_argsdictionary.RunSettingsare able to further restrict arguments that may conflict with SmartSim's process by providing their own restricted arguments.Looking for feedback and/or additional arguments that should be restricted in the subclasses.