Colocated model fix #237
Merged
Colocated model fix #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added tests using PyTorch to cover the cases that led to the error.
ab6b3bd to
a198058
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #237 +/- ##
===========================================
+ Coverage 84.14% 84.43% +0.29%
===========================================
Files 59 56 -3
Lines 3317 3284 -33
===========================================
- Hits 2791 2773 -18
+ Misses 526 511 -15
|
catch error when PyTorch is not installed.
MattToast
approved these changes
Oct 5, 2022
Member
MattToast
left a comment
There was a problem hiding this comment.
LGTM!! Thanks for taking care of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was reported that uninitialized variables in the
colocated.pyentry point were causing an error when utilizingadd_ml_model()for PyTorch models. This PR fixes that bug and adds tests for theadd_ml_model()methods using PyTorch.