Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mitigate suppressed protected-access errors from pylint #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ankona merged 7 commits into from
Aug 22, 2023
Merged

Mitigate suppressed protected-access errors from pylint #341

ankona merged 7 commits into from
Aug 22, 2023

Conversation

@ankona
Copy link
Contributor

@ankona ankona commented Aug 15, 2023 •
edited
Loading

Mitigate the following protected-access errors & remove suppression:

  1. EntityList._db_models -> add db_models property returning immutable collection
  2. EntityList._db_scripts -> add db_scripts property returning immutable collection
  3. Model._db_models -> add db_models property returning immutable collection
  4. Model._db_scripts -> add db_scripts property returning immutable collection
  5. Add Model.add_ml_model_object passthrough to _append_db_model
  6. Add EntityList.add_ml_model_object passthrough to _append_db_model
  7. BatchSettings._preamble -> add preamble property returning immutable collection

@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #341 (d79c18e) into develop (d80bbc0) will decrease coverage by 0.06%.
Report is 1 commits behind head on develop.
The diff coverage is 97.36%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    87.31%   87.25%   -0.06%     
===========================================
  Files           59       59              
  Lines         3531     3546      +15     
===========================================
+ Hits          3083     3094      +11     
- Misses         448      452       +4
Files Changed Coverage Δ
smartsim/entity/entityList.py 94.44% <85.71%> (+1.11%) ⬆️
smartsim/_core/control/controller.py 84.15% <100.00%> (ø)
smartsim/_core/control/manifest.py 94.05% <100.00%> (ø)
smartsim/_core/generation/generator.py 93.93% <100.00%> (ø)
smartsim/entity/ensemble.py 99.20% <100.00%> (ø)
smartsim/entity/model.py 95.94% <100.00%> (+0.17%) ⬆️
smartsim/settings/base.py 98.31% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

mellis13
mellis13 suggested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these lint suppressions. It seems like DBModel and DBScript are more visible to the user now that they are properties. Do you think it's worth making a ticket to look through these objects and make sure they have basic user-functionality for inspection (e.g. __str__).

@ankona ankona added type: chore Issue outside of general development type: usability Issues related to ease of use labels Aug 16, 2023
@ankona
Copy link
Contributor Author

ankona commented Aug 21, 2023

Ticket 511 created @mellis13

@ankona ankona requested a review from mellis13 August 21, 2023 10:49
mellis13
mellis13 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@ankona ankona merged commit c4bf40c into CrayLabs:develop Aug 22, 2023
@ankona ankona deleted the oss487 branch April 4, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mellis13 mellis13 mellis13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: chore Issue outside of general development type: usability Issues related to ease of use

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ankona @mellis13