Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@al-rigazzi
Copy link
Collaborator

This PR adds the possibility of printing files attached to models and to ensembles.

@al-rigazzi al-rigazzi self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #352 (89f543c) into develop (9c31c86) will increase coverage by 0.09%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    88.34%   88.43%   +0.09%     
===========================================
  Files           59       59              
  Lines         3552     3580      +28     
===========================================
+ Hits          3138     3166      +28     
  Misses         414      414              
Files Changed Coverage
smartsim/entity/model.py 85.71%
smartsim/entity/ensemble.py 100.00%
smartsim/entity/files.py 100.00%

@al-rigazzi al-rigazzi requested review from MattToast and ankona August 29, 2023 19:20
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Couple of minor knit-picks, but otherwise LGTM!!

@al-rigazzi al-rigazzi requested a review from MattToast August 31, 2023 15:19
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@al-rigazzi al-rigazzi merged commit 8f2e24f into CrayLabs:develop Sep 1, 2023
@al-rigazzi al-rigazzi deleted the print-model-files branch September 1, 2023 07:46
@MattToast MattToast added area: generation Issues related to Experiment file generation type: feature Issues that include feature request or feature idea labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: generation Issues related to Experiment file generation type: feature Issues that include feature request or feature idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants