Experiment Preview #447
Merged
Experiment Preview #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankona
reviewed
Jan 4, 2024
ankona
reviewed
Jan 4, 2024
ankona
reviewed
Jan 4, 2024
ankona
reviewed
Jan 4, 2024
ankona
reviewed
Jan 4, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## preview #447 +/- ##
===========================================
+ Coverage 90.01% 90.32% +0.31%
===========================================
Files 60 61 +1
Lines 3826 3866 +40
===========================================
+ Hits 3444 3492 +48
+ Misses 382 374 -8
|
al-rigazzi
requested changes
Jan 8, 2024
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
Good starting point, I agree with @ankona's suggestion to use static methods. @MattToast may want to chime in as well.
ankona
reviewed
Jan 9, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
smartsim/log.py
Outdated
| """ | ||
| logger.propagate = False | ||
| fmt = None | ||
| formatter = logging.Formatter(fmt) |
Contributor
There was a problem hiding this comment.
Do you really want a None here? would "%(message)s" do the job?
I don't even know what happens if you have a null formatter!
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
ankona
reviewed
Jan 12, 2024
…nto exppreview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.