Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Relax typing extensions required version #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MattToast merged 1 commit into from
Jan 22, 2024
Merged

Relax typing extensions required version #459

MattToast merged 1 commit into from
Jan 22, 2024

Conversation

@MattToast
Copy link
Member

@MattToast MattToast commented Jan 19, 2024

Relaxes the required version typing_extensions to prevent the following error when pip installing via pip install -e /path/to/local/smarsim[dev,ml,mypy]

(venv) [drozt@hostname ss]$ pip install -e .[dev,ml,mypy]
# ... abridged ...
ERROR: Cannot install smartsim and smartsim[dev,ml,mypy]==0.6.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    smartsim[dev,ml,mypy] 0.6.0 depends on typing-extensions>=4.9.0; extra == "mypy"
    black 24.1a1 depends on typing-extensions>=4.0.1; python_version < "3.11"
    onnx 1.14.1 depends on typing-extensions>=3.6.2.1
    tensorflow 2.13.1 depends on typing-extensions<4.6.0 and >=3.6.6

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

@MattToast MattToast added area: build Issues related to builds, makefiles, installs, etc area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations labels Jan 19, 2024
@MattToast MattToast requested a review from ankona January 19, 2024 18:35
@MattToast MattToast self-assigned this Jan 19, 2024
@codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f683521) 90.34% compared to head (903904b) 90.80%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    90.34%   90.80%   +0.46%     
===========================================
  Files           60       60              
  Lines         3833     3830       -3     
===========================================
+ Hits          3463     3478      +15     
+ Misses         370      352      -18

see 14 files with indirect coverage changes

ankona
ankona approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattToast MattToast merged commit e4d1646 into CrayLabs:develop Jan 22, 2024
@MattToast MattToast deleted the relax-typing-extensions branch January 22, 2024 23:10
ashao pushed a commit to ashao/SmartSim that referenced this pull request Jan 30, 2024
@MattToast @ashao
Relax typing extensions required version (CrayLabs#459)
b3d3e6e 
Relax the required version of `typing_extensions`

[ committed by @MattToast ]
[ reviewed by @ankona ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ankona ankona ankona approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MattToast MattToast

Labels

area: build Issues related to builds, makefiles, installs, etc area: third-party Issues related to Issues related to dependencies and third-part and third-party package integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MattToast @ankona