Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MattToast
Copy link
Member

@MattToast MattToast commented Feb 7, 2024

This PR makes several patch changes to prepare for a SmartSim release including:

Sets the default value of the "enable telemetry" flag to on. Currently
this will enable telemetry system wide until finer grain control can be
established with CrayLabs#460
@MattToast MattToast requested a review from ankona February 7, 2024 00:35
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b84b49f) 90.49% compared to head (8a6abb4) 90.65%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #477      +/-   ##
===========================================
+ Coverage    90.49%   90.65%   +0.15%     
===========================================
  Files           60       60              
  Lines         3821     3821              
===========================================
+ Hits          3458     3464       +6     
+ Misses         363      357       -6     
Files Coverage Δ
smartsim/_core/config/config.py 98.79% <100.00%> (ø)
smartsim/_core/utils/serialize.py 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

@MattToast MattToast changed the title Patch: Telemetry Enabled by Default Patch Changes for Release Prep Feb 7, 2024
@MattToast MattToast mentioned this pull request Feb 7, 2024
4 tasks
Copy link
Contributor

@ankona ankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MattToast MattToast merged commit 18fe50a into CrayLabs:develop Feb 7, 2024
@MattToast MattToast deleted the telem-on-default branch February 16, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants