Fix line-ending related errors on MacOS (ARM64) #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattToast
previously requested changes
Feb 9, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
Some small initial nits for you to consider while you're sorting out the CI
ankona
reviewed
Feb 9, 2024
Dismissing my review as I have now acted as an author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #482 +/- ##
===========================================
+ Coverage 90.01% 90.85% +0.83%
===========================================
Files 60 60
Lines 3826 3826
===========================================
+ Hits 3444 3476 +32
+ Misses 382 350 -32 |
Adds MacOS/M1/ARM64 to test matrix as described by https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
al-rigazzi
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, cloning Redis on Apple Silicon results in files within some of the Redis build scripts that have Windows-style line endings. This leads to errors because the interpreter for these scripts cannot be parsed correctly (e.g
/bin/sh^M). To solve this, we now modify thegit clonefor both Redis and RedisAI to setcore.autoclrf=true. This should only be done for this platform; on Linux and MacOS (x64), setting this to true ends up with the wrong line endings.