Updating SmartSim version for release #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #486 +/- ##
===========================================
- Coverage 90.85% 90.72% -0.14%
===========================================
Files 60 60
Lines 3826 3826
===========================================
- Hits 3476 3471 -5
- Misses 350 355 +5 |
MattToast
requested changes
Feb 15, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
Two VERY small changes, but otherwise LGTM!!
MattToast
approved these changes
Feb 15, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
One last small ask, but nothing worth holding up approval over. LGTM!!
al-rigazzi
requested changes
Feb 15, 2024
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
Please update release date on .wci.yml
.wci.yml
Outdated
| release: | ||
| version: 0.6.0 | ||
| version: 0.6.1 | ||
| date: 2023-12-18 |
Collaborator
There was a problem hiding this comment.
This date needs to be updated
al-rigazzi
approved these changes
Feb 15, 2024
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing that bad date issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes most instances of 0.6.0 to 0.6.1