Optionally skip building Torch with Intel MKL #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattToast
requested changes
Apr 2, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of small things, but otherwise lgtm!!
al-rigazzi
reviewed
Apr 3, 2024
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
Quick comment (I think it's quite superfluous but...)
al-rigazzi
approved these changes
Apr 3, 2024
Collaborator
al-rigazzi
left a comment
There was a problem hiding this comment.
LGTM, thanks for all that {food} for thoughts!
Member
Author
Blame @MattToast I stole it from one of his |
MattToast
approved these changes
Apr 3, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
Two small nits, and pending test suite, but otherwise LGTM!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #538 +/- ##
========================================
Coverage 90.70% 90.70%
========================================
Files 65 65
Lines 4498 4498
========================================
Hits 4080 4080
Misses 418 418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems that have the Intel Compilers and/or the Intel Math Kernel library installed, the Caffe2 package that comes with Torch will unconditionally try to link in the MKL during the Torch backend. This however can lead to two types of failures:
To alleviate this, a new option "--no_torch_with_mkl" has been added to the
smart buildcommand that modifies the mkl.cmake file to prevent the detection of MKL.