Mitigate dragon/numpy, mypy/typing_extension dependency issues #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashao
approved these changes
Jul 31, 2024
Member
ashao
left a comment
There was a problem hiding this comment.
Thanks for tracking this one down so quickly
MattToast
reviewed
Jul 31, 2024
Member
MattToast
left a comment
There was a problem hiding this comment.
One last thing actually! Not worth holding up approval over, though!!
|
|
||
| try: | ||
| pip("install", "--force-reinstall", str(wheel_path)) | ||
| pip("install", "--force-reinstall", str(wheel_path), "numpy<2") |
Member
There was a problem hiding this comment.
Actually one small note: It looks like the version of numpy that comes in when doing a "normal"
pip install --no-cache-dir smartsim[dev,mypy,ml] && smart build --onnx
is version 1.24.3 (at least for me, from pypi, on osx).
This change will presumably pin to version 1.26.4. I'm not sure if that matters, but if you want to be SUPER safe, you may want to pin to that number.
Member
|
Whoops, just missed the merge, hahaha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates two issues encountered during installation on build agents
mypy/typing_extensions
Installation of mypy or dragon in separate build actions caused some dependencies (typing_extensions, numpy) to be upgraded. Those upgrades result in runtime failures. The build actions were tweaked to allow pip to consider all optional dependencies during resolution.
dragon/numpy
Additionally, the numpy version was capped on dragon installations.