Fix to WLM Parsers #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartee
pushed a commit
that referenced
this pull request
Dec 9, 2021
Replace usage of pandas library with smaller pure python Tabulate package to reduce build size and download time. [ committed by @MattToast ] [ reviewed by @Spartee ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most parsers use
startswithto check that a line contains a given step id. This fails if there are two steps, where the step id are one the prefix of the other, e.g.1111.1and1111.10. If the results are sorted so that1111.10appears before1111.1, then the line of1111.10will be parsed even if the user requests1111.1. The same applies to the more rare case where the job ids are1and11(this is frequent on LSF, due tojslistbehavior).This PR addresses this bug by computing an exact match of the step id and the line field.