-
Notifications
You must be signed in to change notification settings - Fork 631
Add LoggingConfiguration struct for providing log path to pgbackrest … #4263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dsessler7
merged 1 commit into
CrunchyData:main
from
dsessler7:custom-pvcs-pgbackrest-logs
Sep 17, 2025
Merged
Add LoggingConfiguration struct for providing log path to pgbackrest … #4263
dsessler7
merged 1 commit into
CrunchyData:main
from
dsessler7:custom-pvcs-pgbackrest-logs
Sep 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsessler7
commented
Sep 3, 2025
dsessler7
commented
Sep 3, 2025
pkg/apis/postgres-operator.crunchydata.com/v1/pgbackrest_types.go
Outdated
Show resolved
Hide resolved
benjaminjb
reviewed
Sep 3, 2025
benjaminjb
reviewed
Sep 3, 2025
benjaminjb
reviewed
Sep 3, 2025
acabe60
to
1312df1
Compare
69d7ce8
to
a8dceef
Compare
10 tasks
benjaminjb
reviewed
Sep 12, 2025
pkg/apis/postgres-operator.crunchydata.com/v1beta1/shared_types.go
Outdated
Show resolved
Hide resolved
pkg/apis/postgres-operator.crunchydata.com/v1/pgbackrest_types.go
Outdated
Show resolved
Hide resolved
benjaminjb
reviewed
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but still have that question about annotation & additional volumes
cbandy
reviewed
Sep 15, 2025
pkg/apis/postgres-operator.crunchydata.com/v1/pgbackrest_types.go
Outdated
Show resolved
Hide resolved
cbandy
approved these changes
Sep 15, 2025
9bb7e57
to
1cbac34
Compare
cbandy
reviewed
Sep 16, 2025
pkg/apis/postgres-operator.crunchydata.com/v1/postgrescluster_types.go
Outdated
Show resolved
Hide resolved
f5261ca
to
9c39b1e
Compare
benjaminjb
approved these changes
Sep 16, 2025
…processes. Add ability to send pgbackrest logs to additional volume for instance sidecar, repo host, and backups jobs. Add validation to prevent incorrect log paths or setting pgbackrest log-path via global. Add appropriate unit and integration tests.
efb50b8
to
fe960ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…processes.
Add ability to send pgbackrest logs to additional volume for repo host processes.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Currently, the various pgbackrest processes can only log to the default location that we specify.
What is the new behavior (if this is a feature change)?
Users can now have their pgBackRest processes log to additional volumes.
Other Information: