fuse: multi-node mmap support #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbernd
reviewed
Jul 7, 2025
| unsigned int no_mkwrite:1; | ||
|
|
||
| /* Use io_uring for communication */ | ||
| unsigned int io_uring; |
There was a problem hiding this comment.
Interesting, needs to be switched to io_uring:1
There was a problem hiding this comment.
(unrelated, but had slipped through so far)
bsbernd
reviewed
Jul 7, 2025
|
Disadvantage of this way is that we get a PAGE_MKWRITE for every page - that will be expensive. |
|
Needs a "Signed-off-by" |
bsbernd
reviewed
Jul 10, 2025
e77b0a5 to
b6ebff1
Compare
bsbernd
reviewed
Jul 15, 2025
b6ebff1 to
989869f
Compare
bsbernd
reviewed
Jul 16, 2025
bsbernd
reviewed
Jul 16, 2025
bsbernd
reviewed
Jul 16, 2025
bsbernd
approved these changes
Jul 16, 2025
989869f to
af8a424
Compare
|
@cding-ddn I can't merge, there are conflicts. I think the 1st patch in the series is already merged. |
Renumber the operation code to a high value to avoid conflicts with upstream.
Send a DLM_WB_LOCK request in the page_mkwrite handler to enable FUSE filesystems to acquire a distributed lock manager (DLM) lock for protecting upcoming dirty pages when a previously read-only mapped page is about to be written. Signed-off-by: Cheng Ding <[email protected]>
Allow read_folio to return EAGAIN error and translate it to AOP_TRUNCATE_PAGE to retry page fault and read operations. This is used to prevent deadlock of folio lock/DLM lock order reversal: - Fault or read operations acquire folio lock first, then DLM lock. - FUSE daemon blocks new DLM lock acquisition while it invalidating page cache. invalidate_inode_pages2_range() acquires folio lock To prevent deadlock, the FUSE daemon will fail its DLM lock acquisition with EAGAIN if it detects an in-flight page cache invalidating operation. Signed-off-by: Cheng Ding <[email protected]>
af8a424 to
8ecf118
Compare
|
@bernd, I did a rebase, it can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PAGE_MKWRITE fuse request to allow FUSE daemon to acquire DLM lock for protecting dirty page creation.
Allow read_folio to return EAGAIN error and translate it to AOP_TRUNCATE_PAGE to retry page fault and read operations. This is used to prevent deadlock of folio lock/DLM lock order reversal:
This enables memory mapping across cluster nodes with proper distributed locking coordination.