Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ryan-kipawa
Copy link
Contributor

Is this what you had in mind @ecomodeller?

I tried to simplify our build process by:

  • uv sync or uv build command to get up and running (see updated README.md)
  • cross-platform build hook that downloads nuget packages and creates a bin folder
  • single source of truth of the nuget package versions (buildUtil/packages.config)
  • update CI tests to use the new build system
  • pyproject.toml instead of setup.py
  • updated to 23.0.3 (latest on nuget)

All tests seem to pass for Linux and Windows. I tested it on the latest dev branch of MIKE IO, and only two tests failed (one for a new EUM and one for a floating point rounding).

Things we could continue further with:

  • remove MIKECoreCUtil (legacy?)
  • update build actions and remove legacy ones
  • include a publish action?
  • update docker container (if that's still useful to have)
  • remove redundant scripts (e.g. InstallPackages.bat, BuildNativeBin.bat)
  • remove or update MIKECore solution - is a visual studio project still useful to have?
  • automate manual eum.py updates

@JesperGr
Copy link
Collaborator

JesperGr commented Jul 16, 2025

The NuGet packages are now specified in the packages.config - then the InstallPackages.bat and BuildNativeBin.bat are redundant, right?

@JesperGr
Copy link
Collaborator

The patchelf stuff for Linux should be set already by most, if not all, components already. That step can potentially be removed.

@JesperGr
Copy link
Collaborator

Apart from that, things looks pretty neat 🥇 👍

@ryan-kipawa
Copy link
Contributor Author

The NuGet packages are now specified in the packages.config - then the InstallPackages.bat and BuildNativeBin.bat are redundant, right?

Right!

@ryan-kipawa
Copy link
Contributor Author

The patchelf stuff for Linux should be set already by most, if not all, components already. That step can potentially be removed.

I noticed one component was missing it (maybe it didn't require it).

Copy link
Member

@ecomodeller ecomodeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@ryan-kipawa ryan-kipawa merged commit bdccb53 into DHI:master Aug 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants