Feature/asynchronous message sending #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frank-Wiebeler
requested changes
Jan 18, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
From the technical view: Really awesome job.
The comments and requests for change ask for changes in the Commented parts of the code.
The function and attribute naming in the library looks quite obvious, so I'm not really sure if we should add all those function header comments that might not reflect any changes in the future but might lead to misconceptions due to copy&paste. Additionally, some comments only repeat the attribute names. Like "sendMessage(SendMessageParameters parameters); comment: @param parameters Parameters to send messages" does not provide any extra information.
...i-java-api/src/main/java/com/dke/data/agrirouter/api/service/messaging/MessagingService.java
Show resolved
Hide resolved
...a-impl/src/main/java/com/dke/data/agrirouter/impl/messaging/mqtt/SendMessageServiceImpl.java
Show resolved
Hide resolved
...r-api-java-impl/src/main/java/com/dke/data/agrirouter/impl/messaging/rest/MessageSender.java
Outdated
Show resolved
Hide resolved
oliverrahner
previously approved these changes
Feb 18, 2021
| String send(T parameters); | ||
|
|
||
| /** | ||
| * Send a asynchronous message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.