Feature/message chunking for larger messages #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverrahner
previously approved these changes
Apr 13, 2021
Member
|
@saschadoemer please resolve conflicts |
Frank-Wiebeler
requested changes
Apr 16, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Sorry, found a bug that should be fixed before release.
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java
Outdated
Show resolved
Hide resolved
…into feature/message-chunking-for-larger-messages � Conflicts: � agrirouter-sdk-java-api/src/main/kotlin/com/dke/data/agrirouter/api/enums/TechnicalMessageType.kt � agrirouter-sdk-java-impl/src/test/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImplTest.java
oliverrahner
previously approved these changes
Dec 3, 2021
Frank-Wiebeler
requested changes
Dec 3, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Unfortunally found a few potentials for optimization; including the one mentioned last time ;)
...pi/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/DeleteMessageParameters.kt
Outdated
Show resolved
Hide resolved
...pi/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/DeleteMessageParameters.kt
Outdated
Show resolved
Hide resolved
...pi/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/DeleteMessageParameters.kt
Outdated
Show resolved
Hide resolved
...pi/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/DeleteMessageParameters.kt
Outdated
Show resolved
Hide resolved
...api/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/MessageQueryParameters.kt
Outdated
Show resolved
Hide resolved
...java-api/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/PayloadParameters.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java
Outdated
Show resolved
Hide resolved
Add constant.
Stabilize the test cases by adding more wait time. Check the size of each chunk after chunking them.
Frank-Wiebeler
requested changes
Dec 16, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Found a minor issue in the Base64-Encoding part (some If-Path are not Encoded), please check and fix
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Show resolved
Hide resolved
Frank-Wiebeler
requested changes
Dec 20, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
A few minor things left, but we're on a good way 😃
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Show resolved
Hide resolved
...java-api/src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/PayloadParameters.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/dke/data/agrirouter/impl/messaging/encoding/EncodeMessageServiceImpl.java
Show resolved
Hide resolved
...-tests/src/test/java/com/dke/data/agrirouter/test/messaging/rest/SendChunkedMessageTest.java
Outdated
Show resolved
Hide resolved
Frank-Wiebeler
approved these changes
Dec 21, 2021
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Awesome work 😃 Thank you for that 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.