Feature/update certificates for the testcases #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance validation method to trim the parameters as well. Rename parameter validation.
Update fixtures to enable the tests. Add slf4j-nop to remove warnings. Update artifact name.
Add communication unit as fixture. Fix test case.
Frank-Wiebeler
requested changes
Jan 16, 2022
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
There is a very small chance of issues if an implementation uses spaces in the teamsetContextId. As of now, this is not explicitely forbidden
...src/main/kotlin/com/dke/data/agrirouter/api/service/parameters/base/AbstractParameterBase.kt
Outdated
Show resolved
Hide resolved
Frank-Wiebeler
approved these changes
Jan 25, 2022
Member
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Thank you for your good work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.