Feature/list all endpoints as default function #175
Conversation
Remove convenience functionality. Format.
Remove convenience functionality. Format.
Add functions to fetch all message headers from the feed. Format
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Please fix the CI first.
|
@Frank-Wiebeler fixed by re-running ;-) |
|
@saschadoemer So, looks like we did it twice and it worked ones ;) |
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Please check the comments
...impl/src/main/java/com/dke/data/agrirouter/impl/messaging/mqtt/ListEndpointsServiceImpl.java
Outdated
Show resolved
Hide resolved
...impl/src/main/java/com/dke/data/agrirouter/impl/messaging/mqtt/ListEndpointsServiceImpl.java
Outdated
Show resolved
Hide resolved
| * @param onboardingResponse The onboard response for the endpoint. | ||
| * @return The message ID. | ||
| */ | ||
| String listAllWithExistingRoute(OnboardingResponse onboardingResponse); |
There was a problem hiding this comment.
As this is only the requesting function and does not directly return the endpoint list, a name that starts with request would be more accurate.
requestAllWithExistingRoute() or requestAllEndpointsWithExistingRoute()
requestAll() or requestAllEndpoints()
There was a problem hiding this comment.
Since 'request' is based on the HTTP terminology. I would like to stay with the current name. Resolve the conversation if this is fine.
There was a problem hiding this comment.
Good point, what about queue? ;-)
There was a problem hiding this comment.
I would like to keep the same name for both of the services and therefore, stick with the current name.
No description provided.