Feature/happy path testing for documentation #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded QA environment with dynamic environment retrieval from respective objects to improve maintainability and flexibility. Also added `getEnvironment()` method in `AbstractIntegrationTest` for consistent environment access across test classes.
This test validates the onboarding process for a new telemetry connection, ensuring the response contains all necessary authentication and connection details. The test is currently disabled and requires replacing the placeholder registration code to run.
The `QA` environment import was present but unused across multiple test files. This cleanup improves code readability and eliminates unnecessary dependencies, aligning with best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new integration test for onboarding telemetry connections and refactors the test codebase to dynamically use environment configurations instead of hardcoding
QA. By centralizing environment configuration logic, the changes improve maintainability and reusability.New Test Addition:
OnboardingForTelemetryConnectionTestto validate the onboarding process for telemetry connections. The test includes parameter creation, onboarding execution, and response validation.Refactoring for Environment Configuration:
Abstract Integration Test Enhancements:
getEnvironment()inAbstractIntegrationTest.Applicationto dynamically provide environment configurations. Implementations now return an instance ofQA. [1] [2] [3] [4] [5]Fixture and Service Tests Updates:
new QA()instances with calls to thegetEnvironment()method in various test fixtures and service tests, including:CommunicationUnitFixtureFarmingSoftwareFixtureMqttCommunicationUnitFixture[1] [2]TelemetryPlatformFixturePingServiceTestSetSubscriptionServiceTest[1] [2]AuthorizationRequestServiceTest[1] [2]Unused Imports Removal:
QAfrom several test files to clean up the codebase. [1] [2] [3] [4] [5] [6] [7]