Thanks to visit codestin.com
Credit goes to github.com

Skip to content

OVH: fix ovh integration tests for release_candidate_v5#4453

Draft
masterzen wants to merge 1 commit into
DNSControl:release_candidate_v5from
masterzen:masterzen/ovh-fixes-for-release-candidate-v5
Draft

OVH: fix ovh integration tests for release_candidate_v5#4453
masterzen wants to merge 1 commit into
DNSControl:release_candidate_v5from
masterzen:masterzen/ovh-fixes-for-release-candidate-v5

Conversation

@masterzen

@masterzen masterzen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What?

This makes the integration tests pass for the OVH provider on top of the release_candidate_v5 work.

Why?

TXT record parsing seems to have changed, and TXT records where quoted again when parsed.

@masterzen
OVH: fix ovh integration tests for release_candidate_v5
43a08ad 
This fixes parsing native TXT records for the OVH provider.
@masterzen masterzen requested a review from TomOnTime as a code owner July 8, 2026 19:22
@masterzen masterzen marked this pull request as draft July 8, 2026 19:24
@masterzen

masterzen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

While this fixes some of the integration tests, some are still failing:

=== RUN   TestDNSProviders/dnscontroltest.ovh/27:complex_TXT:a_0-byte_TXT
    helpers_integration_test.go:255: OVHcloud API error (status code 400): Client::BadRequest: "{'target': ['Invalid input.']}" (X-OVH-Query-Id: EU.ext-4.6a4ea284.3587060.75b31d3c7614bc9e33a63aea301fdb8e)
=== RUN   TestDNSProviders/dnscontroltest.ovh/97:structured_TXT_as_native_records:Create_native_OVH_records
    helpers_integration_test.go:255: OVHcloud API error (status code 400): Client::BadRequest: "Invalid subdomain: dkim" (X-OVH-Query-Id: EU.ext-3.6a4ea343.1196486.1857a3461e2a5378c77f82354f6a3541)

I need to have a deeper look.

@masterzen masterzen mentioned this pull request Jul 9, 2026
Open
59 tasks
@TomOnTime

TomOnTime commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

FYI: If miekg accepts https://codeberg.org/miekg/dns/pulls/916, the way TXTs are handled might change for the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomOnTime TomOnTime Awaiting requested review from TomOnTime TomOnTime is a code owner

Assignees

No one assigned

Labels

provider-OVH

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masterzen @TomOnTime