-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fixing issue #7464 for DSpace 7 #9596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
approved these changes
May 16, 2024
Member
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @paulo-graca ! This looks correct to me. Merging for 7.6.2 and porting to 8.0
Contributor
|
Successfully created backport PR for |
milanmajchrak
pushed a commit
to dataquest-dev/DSpace
that referenced
this pull request
Feb 12, 2025
Fixing issue DSpace#7464 for DSpace 7
milanmajchrak
added a commit
to dataquest-dev/DSpace
that referenced
this pull request
Feb 14, 2025
* Sync a few dependency exclusions from dspace-8_x to dspace-7_x to fix convergence issues * Merge pull request DSpace#10306 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.1 Bump net.minidev:json-smart from 2.5.0 to 2.5.1 * Merge pull request DSpace#9520 from DSpace/backport-9296-to-dspace-7_x [Port dspace-7_x] Fix resource policy type not set for bitstreams when importing items * Added removed resource policies when adding bitstreams in the AbstractMETSIngester * Merge pull request DSpace#9596 from paulo-graca/bugfixes/issue-7464 Fixing issue DSpace#7464 for DSpace 7 * Merge pull request DSpace#9191 from atmire/w2p-106812_enforce-resource-policies-to-have-group-or-eperson [Port to dspace-7_x] Enforce resource policies to have group or eperson * Fixed Tests following the Resource Policy refactoring * Merge pull request DSpace#9364 from DSpace/backport-9336-to-dspace-7_x [Port dspace-7_x] Add more SWORDv2 Integration Tests * Added test to depositItemWithEmbargo when the user is in the submitter group * Throw a proper exception with more info when Authorization or Crosswalk exception instead of RuntimeException. * Update all GitHub Actions. Add newly required CODECOV_TOKEN to codecov action * Revert unwanted change * Removed mets-embargo.xml because it is not used --------- Co-authored-by: Tim Donohue <[email protected]>
milanmajchrak
added a commit
to dataquest-dev/DSpace
that referenced
this pull request
Feb 14, 2025
* Sync a few dependency exclusions from dspace-8_x to dspace-7_x to fix convergence issues * Merge pull request DSpace#10306 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.1 Bump net.minidev:json-smart from 2.5.0 to 2.5.1 * Merge pull request DSpace#9520 from DSpace/backport-9296-to-dspace-7_x [Port dspace-7_x] Fix resource policy type not set for bitstreams when importing items * Added removed resource policies when adding bitstreams in the AbstractMETSIngester * Merge pull request DSpace#9596 from paulo-graca/bugfixes/issue-7464 Fixing issue DSpace#7464 for DSpace 7 * Merge pull request DSpace#9191 from atmire/w2p-106812_enforce-resource-policies-to-have-group-or-eperson [Port to dspace-7_x] Enforce resource policies to have group or eperson * Fixed Tests following the Resource Policy refactoring * Merge pull request DSpace#9364 from DSpace/backport-9336-to-dspace-7_x [Port dspace-7_x] Add more SWORDv2 Integration Tests * Added test to depositItemWithEmbargo when the user is in the submitter group * Throw a proper exception with more info when Authorization or Crosswalk exception instead of RuntimeException. * Update all GitHub Actions. Add newly required CODECOV_TOKEN to codecov action * Revert unwanted change * Removed mets-embargo.xml because it is not used --------- Co-authored-by: Tim Donohue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 APPROVAL
pull request only requires a single approval to merge.
bug
interface: SWORD
Related to either SWORDv1 or SWORDv2 interfaces (dspace-sword and dspace-swordv2 modules)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
When depositing via Sword, if you specify restricting policies (like embargo or restricted), the resource policy table will have a null value for the type. This PR fixes that for DSpace 7.