Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@paulo-graca
Copy link
Contributor

References

Description

When depositing via Sword, if you specify restricting policies (like embargo or restricted), the resource policy table will have a null value for the type. This PR fixes that for DSpace 7.

@paulo-graca paulo-graca added the 1 APPROVAL pull request only requires a single approval to merge. label May 16, 2024
@paulo-graca paulo-graca self-assigned this May 16, 2024
@paulo-graca paulo-graca linked an issue May 16, 2024 that may be closed by this pull request
@tdonohue tdonohue added bug interface: SWORD Related to either SWORDv1 or SWORDv2 interfaces (dspace-sword and dspace-swordv2 modules) port to main This PR needs to be ported to `main` branch for the next major release labels May 16, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @paulo-graca ! This looks correct to me. Merging for 7.6.2 and porting to 8.0

@tdonohue tdonohue added this to the 7.6.2 milestone May 16, 2024
@tdonohue tdonohue merged commit b3a4571 into DSpace:dspace-7_x May 16, 2024
@dspace-bot
Copy link
Contributor

Successfully created backport PR for main:

@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label May 16, 2024
milanmajchrak pushed a commit to dataquest-dev/DSpace that referenced this pull request Feb 12, 2025
milanmajchrak added a commit to dataquest-dev/DSpace that referenced this pull request Feb 14, 2025
* Sync a few dependency exclusions from dspace-8_x to dspace-7_x to fix convergence issues

* Merge pull request DSpace#10306 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.1

Bump net.minidev:json-smart from 2.5.0 to 2.5.1

* Merge pull request DSpace#9520 from DSpace/backport-9296-to-dspace-7_x

[Port dspace-7_x] Fix resource policy type not set for bitstreams when importing items

* Added removed resource policies when adding bitstreams in the AbstractMETSIngester

* Merge pull request DSpace#9596 from paulo-graca/bugfixes/issue-7464

Fixing issue DSpace#7464 for DSpace 7

* Merge pull request DSpace#9191 from atmire/w2p-106812_enforce-resource-policies-to-have-group-or-eperson

[Port to dspace-7_x] Enforce resource policies to have group or eperson

* Fixed Tests following the Resource Policy refactoring

* Merge pull request DSpace#9364 from DSpace/backport-9336-to-dspace-7_x

[Port dspace-7_x] Add more SWORDv2 Integration Tests

* Added test to depositItemWithEmbargo when the user is in the submitter group

* Throw a proper exception with more info when Authorization or Crosswalk exception instead of RuntimeException.

* Update all GitHub Actions. Add newly required CODECOV_TOKEN to codecov action

* Revert unwanted change

* Removed mets-embargo.xml because it is not used

---------

Co-authored-by: Tim Donohue <[email protected]>
milanmajchrak added a commit to dataquest-dev/DSpace that referenced this pull request Feb 14, 2025
* Sync a few dependency exclusions from dspace-8_x to dspace-7_x to fix convergence issues

* Merge pull request DSpace#10306 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.1

Bump net.minidev:json-smart from 2.5.0 to 2.5.1

* Merge pull request DSpace#9520 from DSpace/backport-9296-to-dspace-7_x

[Port dspace-7_x] Fix resource policy type not set for bitstreams when importing items

* Added removed resource policies when adding bitstreams in the AbstractMETSIngester

* Merge pull request DSpace#9596 from paulo-graca/bugfixes/issue-7464

Fixing issue DSpace#7464 for DSpace 7

* Merge pull request DSpace#9191 from atmire/w2p-106812_enforce-resource-policies-to-have-group-or-eperson

[Port to dspace-7_x] Enforce resource policies to have group or eperson

* Fixed Tests following the Resource Policy refactoring

* Merge pull request DSpace#9364 from DSpace/backport-9336-to-dspace-7_x

[Port dspace-7_x] Add more SWORDv2 Integration Tests

* Added test to depositItemWithEmbargo when the user is in the submitter group

* Throw a proper exception with more info when Authorization or Crosswalk exception instead of RuntimeException.

* Update all GitHub Actions. Add newly required CODECOV_TOKEN to codecov action

* Revert unwanted change

* Removed mets-embargo.xml because it is not used

---------

Co-authored-by: Tim Donohue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge. bug interface: SWORD Related to either SWORDv1 or SWORDv2 interfaces (dspace-sword and dspace-swordv2 modules)

Projects

Development

Successfully merging this pull request may close these issues.

[DS-4117] METSRightsCrosswalk doesn't set resource policy type

3 participants