Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@liumengkai
Copy link
Contributor

@liumengkai liumengkai commented Nov 8, 2022

Purpose of this pull request

support multiple params after -p ,If we want set multiple params with comma,we can set like this:

-p -Mbootstrap=host1:9092,host2:9092

Which issue you fix

#1388

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@liumengkai
Copy link
Contributor Author

code review
@FlechazoW

@liumengkai liumengkai force-pushed the feat-#1388_support_muti_params_comma branch from 8930143 to 796eccf Compare November 8, 2022 14:37
Copy link
Member

@FlechazoW FlechazoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liumengkai
Copy link
Contributor Author

json paramters will be great.
more information: #1393

@liumengkai liumengkai closed this Nov 11, 2022
@liumengkai liumengkai deleted the feat-#1388_support_muti_params_comma branch December 2, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants