Switch inferred spans tests to pytest parametrized. #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0629cc0 to
0e76664
Compare
purple4reina
commented
Mar 27, 2024
| return result_func | ||
|
|
||
|
|
||
| create_inferred_span = wrapped_span_creator(create_inferred_span) |
There was a problem hiding this comment.
Tests still pass if I remove this stuff
There was a problem hiding this comment.
hmmm yeah then definitely remove
duncanista
reviewed
Mar 27, 2024
| assert actual.parent_id == parent.span_id | ||
| assert finish_time == expect.start | ||
| else: | ||
| assert mock_span_finish.call_count == 0 |
There was a problem hiding this comment.
the else is just to crash right? since the counts will always be 1
There was a problem hiding this comment.
Nope! Maybe I should change this, but I overloaded parent_name. If set, then we essentially assume there's two inferred spans. If not set, then there's only one inferred span.
There was a problem hiding this comment.
I'll add a comment for clarification
duncanista
approved these changes
Mar 27, 2024
astuyve
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
pytest.mark.parametrizeto create a single parameterized test for creating inferred spans.Motivation
Cleaner. Easier to read. <3 pytest
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply
https://datadoghq.atlassian.net/browse/SVLS-4291