Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Correct FIPS-mode metrics #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Correct FIPS-mode metrics #588
Changes from all commits
6c58173
b4f6c81
1e564c9
ee1249a
7d21380
b761b28
360a252
f8967a7
95e2cbc
f187a1b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to fire off a metric here, similar to the way we do for dynamodb stream settings. but since the most interesting value,
NO_METRICS
would actually be unavailable, i chose not to do this. let me know if you think we should still send the metric anyway, despite theNO_METRICS
blind spot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using the
get_enhanced_metrics_tags
again? Or else this would be breaking?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still use it as part of the
submit_enhanced_metric
call. but theextension_thread_stats
was neverNone
with the changes i put in and thus this code was not being called anymore anyway. this get function have important side effects we need to bring back somewhere?