Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow login events SDK to be used with appsec disabled #8464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Allow login events SDK to be used with appsec disabled #8464

merged 2 commits into from
Mar 13, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Relocates the logic for handling span tags related to the login event SDK from the com.datadog.appsec.gateway.GatewayBridge class to datadog.trace.api.appsecAppSecEventTracker. This modification ensures the functionality remains accessible even if AppSec is explicitly disabled.

Motivation

Customers using the SDK should still be able to set the appropriate span tags even when AppSec is disabled.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm waf Application Security Management (WAF) labels Feb 27, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from 081dea3 to dc094dd Compare February 27, 2025 16:34
@pr-commenter
Copy link

pr-commenter bot commented Feb 27, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741862989 1741870349
git_commit_sha a39a27f cf301ce
release_version 1.48.0-SNAPSHOT~a39a27f5b6 1.48.0-SNAPSHOT~cf301cea71
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741872763 1741872763
ci_job_id 846323458 846323458
ci_pipeline_id 58696311 58696311
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-dgzduy7c-project-304-concurrent-1-xzvcznnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-dgzduy7c-project-304-concurrent-1-xzvcznnk 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042182
Total [baseline] (10.478 s) : 0, 10477887
Agent [candidate] (1.043 s) : 0, 1042602
Total [candidate] (10.522 s) : 0, 10522341
section appsec
Agent [baseline] (1.191 s) : 0, 1190631
Total [baseline] (10.8 s) : 0, 10799750
Agent [candidate] (1.183 s) : 0, 1182638
Total [candidate] (10.763 s) : 0, 10762791
section iast
Agent [baseline] (1.184 s) : 0, 1183556
Total [baseline] (11.1 s) : 0, 11099984
Agent [candidate] (1.173 s) : 0, 1173082
Total [candidate] (10.967 s) : 0, 10967361
section profiling
Agent [baseline] (1.262 s) : 0, 1262429
Total [baseline] (10.901 s) : 0, 10900931
Agent [candidate] (1.261 s) : 0, 1260883
Total [candidate] (10.921 s) : 0, 10920894
Loading
  • baseline results
Module Variant Duration Ξ” tracing
Agent tracing 1.042 s -
Agent appsec 1.191 s 148.449 ms (14.2%)
Agent iast 1.184 s 141.375 ms (13.6%)
Agent profiling 1.262 s 220.247 ms (21.1%)
Total tracing 10.478 s -
Total appsec 10.8 s 321.862 ms (3.1%)
Total iast 11.1 s 622.097 ms (5.9%)
Total profiling 10.901 s 423.044 ms (4.0%)
  • candidate results
Module Variant Duration Ξ” tracing
Agent tracing 1.043 s -
Agent appsec 1.183 s 140.036 ms (13.4%)
Agent iast 1.173 s 130.48 ms (12.5%)
Agent profiling 1.261 s 218.281 ms (20.9%)
Total tracing 10.522 s -
Total appsec 10.763 s 240.45 ms (2.3%)
Total iast 10.967 s 445.02 ms (4.2%)
Total profiling 10.921 s 398.552 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.603 ms) : 0, 717603
BytebuddyAgent [candidate] (719.3 ms) : 0, 719300
GlobalTracer [baseline] (239.339 ms) : 0, 239339
GlobalTracer [candidate] (240.402 ms) : 0, 240402
AppSec [baseline] (54.946 ms) : 0, 54946
AppSec [candidate] (54.758 ms) : 0, 54758
Remote Config [baseline] (686.906 Β΅s) : 0, 687
Remote Config [candidate] (690.496 Β΅s) : 0, 690
Telemetry [baseline] (14.703 ms) : 0, 14703
Telemetry [candidate] (12.183 ms) : 0, 12183
section appsec
BytebuddyAgent [baseline] (740.94 ms) : 0, 740940
BytebuddyAgent [candidate] (735.685 ms) : 0, 735685
GlobalTracer [baseline] (237.833 ms) : 0, 237833
GlobalTracer [candidate] (236.293 ms) : 0, 236293
AppSec [baseline] (177.087 ms) : 0, 177087
AppSec [candidate] (175.43 ms) : 0, 175430
Remote Config [baseline] (659.432 Β΅s) : 0, 659
Remote Config [candidate] (659.028 Β΅s) : 0, 659
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.609 ms) : 0, 8609
IAST [baseline] (21.814 ms) : 0, 21814
IAST [candidate] (21.44 ms) : 0, 21440
section iast
BytebuddyAgent [baseline] (846.809 ms) : 0, 846809
BytebuddyAgent [candidate] (837.984 ms) : 0, 837984
GlobalTracer [baseline] (232.283 ms) : 0, 232283
GlobalTracer [candidate] (231.317 ms) : 0, 231317
AppSec [baseline] (57.103 ms) : 0, 57103
AppSec [candidate] (56.29 ms) : 0, 56290
Remote Config [baseline] (611.123 Β΅s) : 0, 611
Remote Config [candidate] (608.956 Β΅s) : 0, 609
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.679 ms) : 0, 8679
IAST [baseline] (22.999 ms) : 0, 22999
IAST [candidate] (22.961 ms) : 0, 22961
section profiling
BytebuddyAgent [baseline] (710.505 ms) : 0, 710505
BytebuddyAgent [candidate] (710.43 ms) : 0, 710430
GlobalTracer [baseline] (350.091 ms) : 0, 350091
GlobalTracer [candidate] (350.439 ms) : 0, 350439
AppSec [baseline] (55.026 ms) : 0, 55026
AppSec [candidate] (53.315 ms) : 0, 53315
Remote Config [baseline] (679.288 Β΅s) : 0, 679
Remote Config [candidate] (665.298 Β΅s) : 0, 665
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (8.893 ms) : 0, 8893
ProfilingAgent [baseline] (96.804 ms) : 0, 96804
ProfilingAgent [candidate] (96.406 ms) : 0, 96406
Profiling [baseline] (96.829 ms) : 0, 96829
Profiling [candidate] (96.432 ms) : 0, 96432
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043787
Total [baseline] (8.674 s) : 0, 8673843
Agent [candidate] (1.039 s) : 0, 1039091
Total [candidate] (8.686 s) : 0, 8685577
section iast
Agent [baseline] (1.172 s) : 0, 1171643
Total [baseline] (9.241 s) : 0, 9241036
Agent [candidate] (1.171 s) : 0, 1171355
Total [candidate] (9.261 s) : 0, 9261128
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1176318
Total [baseline] (9.198 s) : 0, 9197848
Agent [candidate] (1.175 s) : 0, 1174754
Total [candidate] (9.216 s) : 0, 9215558
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166567
Total [baseline] (9.239 s) : 0, 9239093
Agent [candidate] (1.18 s) : 0, 1179599
Total [candidate] (9.298 s) : 0, 9297600
Loading
  • baseline results
Module Variant Duration Ξ” tracing
Agent tracing 1.044 s -
Agent iast 1.172 s 127.856 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.176 s 132.531 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.167 s 122.779 ms (11.8%)
Total tracing 8.674 s -
Total iast 9.241 s 567.194 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.198 s 524.005 ms (6.0%)
Total iast_TELEMETRY_OFF 9.239 s 565.251 ms (6.5%)
  • candidate results
Module Variant Duration Ξ” tracing
Agent tracing 1.039 s -
Agent iast 1.171 s 132.264 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 135.662 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.18 s 140.508 ms (13.5%)
Total tracing 8.686 s -
Total iast 9.261 s 575.551 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.216 s 529.981 ms (6.1%)
Total iast_TELEMETRY_OFF 9.298 s 612.023 ms (7.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.49 ms) : 0, 719490
BytebuddyAgent [candidate] (718.446 ms) : 0, 718446
GlobalTracer [baseline] (239.897 ms) : 0, 239897
GlobalTracer [candidate] (239.586 ms) : 0, 239586
AppSec [baseline] (55.055 ms) : 0, 55055
AppSec [candidate] (54.376 ms) : 0, 54376
Remote Config [baseline] (691.193 Β΅s) : 0, 691
Remote Config [candidate] (689.172 Β΅s) : 0, 689
Telemetry [baseline] (13.749 ms) : 0, 13749
Telemetry [candidate] (10.752 ms) : 0, 10752
section iast
BytebuddyAgent [baseline] (837.682 ms) : 0, 837682
BytebuddyAgent [candidate] (837.709 ms) : 0, 837709
GlobalTracer [baseline] (230.533 ms) : 0, 230533
GlobalTracer [candidate] (230.621 ms) : 0, 230621
AppSec [baseline] (56.612 ms) : 0, 56612
AppSec [candidate] (55.885 ms) : 0, 55885
Remote Config [baseline] (601.82 Β΅s) : 0, 602
Remote Config [candidate] (594.911 Β΅s) : 0, 595
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.625 ms) : 0, 8625
IAST [baseline] (22.693 ms) : 0, 22693
IAST [candidate] (22.667 ms) : 0, 22667
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.885 ms) : 0, 841885
BytebuddyAgent [candidate] (839.81 ms) : 0, 839810
GlobalTracer [baseline] (230.451 ms) : 0, 230451
GlobalTracer [candidate] (231.34 ms) : 0, 231340
AppSec [baseline] (55.954 ms) : 0, 55954
AppSec [candidate] (56.13 ms) : 0, 56130
Remote Config [baseline] (602.602 Β΅s) : 0, 603
Remote Config [candidate] (608.873 Β΅s) : 0, 609
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.654 ms) : 0, 8654
IAST [baseline] (23.675 ms) : 0, 23675
IAST [candidate] (22.919 ms) : 0, 22919
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.729 ms) : 0, 833729
BytebuddyAgent [candidate] (842.189 ms) : 0, 842189
GlobalTracer [baseline] (229.752 ms) : 0, 229752
GlobalTracer [candidate] (233.153 ms) : 0, 233153
AppSec [baseline] (56.638 ms) : 0, 56638
AppSec [candidate] (56.745 ms) : 0, 56745
Remote Config [baseline] (604.467 Β΅s) : 0, 604
Remote Config [candidate] (619.041 Β΅s) : 0, 619
Telemetry [baseline] (8.574 ms) : 0, 8574
Telemetry [candidate] (8.739 ms) : 0, 8739
IAST [baseline] (22.349 ms) : 0, 22349
IAST [candidate] (22.773 ms) : 0, 22773
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-13T13:05:59 2025-03-13T13:13:46
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741862989 1741870349
git_commit_sha a39a27f cf301ce
release_version 1.48.0-SNAPSHOT~a39a27f5b6 1.48.0-SNAPSHOT~cf301cea71
start_time 2025-03-13T13:05:45 2025-03-13T13:13:32
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741872025 1741872025
ci_job_id 846323459 846323459
ci_pipeline_id 58696311 58696311
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-gzhmqs6t-project-304-concurrent-1-v4tug8oi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-gzhmqs6t-project-304-concurrent-1-v4tug8oi 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (389.94 Β΅s) : 370, 410
.   : milestone, 390,
iast (525.101 Β΅s) : 501, 549
.   : milestone, 525,
iast_FULL (737.328 Β΅s) : 715, 759
.   : milestone, 737,
iast_GLOBAL (562.162 Β΅s) : 540, 584
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (516.608 Β΅s) : 495, 538
.   : milestone, 517,
iast_INACTIVE (470.308 Β΅s) : 449, 492
.   : milestone, 470,
iast_TELEMETRY_OFF (503.874 Β΅s) : 481, 526
.   : milestone, 504,
tracing (460.941 Β΅s) : 440, 481
.   : milestone, 461,
section candidate
no_agent (380.539 Β΅s) : 360, 401
.   : milestone, 381,
iast (514.481 Β΅s) : 493, 536
.   : milestone, 514,
iast_FULL (739.873 Β΅s) : 718, 762
.   : milestone, 740,
iast_GLOBAL (562.761 Β΅s) : 541, 584
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (520.855 Β΅s) : 499, 543
.   : milestone, 521,
iast_INACTIVE (468.195 Β΅s) : 446, 491
.   : milestone, 468,
iast_TELEMETRY_OFF (505.74 Β΅s) : 484, 527
.   : milestone, 506,
tracing (462.396 Β΅s) : 442, 483
.   : milestone, 462,
Loading
  • baseline results
Variant Request duration [CI 0.99] Ξ” no_agent
no_agent 389.94 Β΅s [370.275 Β΅s, 409.606 Β΅s] -
iast 525.101 Β΅s [501.39 Β΅s, 548.812 Β΅s] 135.16 Β΅s (34.7%)
iast_FULL 737.328 Β΅s [715.309 Β΅s, 759.346 Β΅s] 347.387 Β΅s (89.1%)
iast_GLOBAL 562.162 Β΅s [540.345 Β΅s, 583.979 Β΅s] 172.222 Β΅s (44.2%)
iast_HARDCODED_SECRET_DISABLED 516.608 Β΅s [494.942 Β΅s, 538.274 Β΅s] 126.668 Β΅s (32.5%)
iast_INACTIVE 470.308 Β΅s [448.603 Β΅s, 492.012 Β΅s] 80.367 Β΅s (20.6%)
iast_TELEMETRY_OFF 503.874 Β΅s [481.275 Β΅s, 526.473 Β΅s] 113.933 Β΅s (29.2%)
tracing 460.941 Β΅s [440.403 Β΅s, 481.48 Β΅s] 71.001 Β΅s (18.2%)
  • candidate results
Variant Request duration [CI 0.99] Ξ” no_agent
no_agent 380.539 Β΅s [360.3 Β΅s, 400.779 Β΅s] -
iast 514.481 Β΅s [492.877 Β΅s, 536.085 Β΅s] 133.942 Β΅s (35.2%)
iast_FULL 739.873 Β΅s [717.863 Β΅s, 761.883 Β΅s] 359.333 Β΅s (94.4%)
iast_GLOBAL 562.761 Β΅s [541.267 Β΅s, 584.254 Β΅s] 182.221 Β΅s (47.9%)
iast_HARDCODED_SECRET_DISABLED 520.855 Β΅s [499.112 Β΅s, 542.598 Β΅s] 140.316 Β΅s (36.9%)
iast_INACTIVE 468.195 Β΅s [445.567 Β΅s, 490.823 Β΅s] 87.655 Β΅s (23.0%)
iast_TELEMETRY_OFF 505.74 Β΅s [484.296 Β΅s, 527.185 Β΅s] 125.201 Β΅s (32.9%)
tracing 462.396 Β΅s [441.512 Β΅s, 483.28 Β΅s] 81.856 Β΅s (21.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.381 ms) : 1361, 1401
.   : milestone, 1381,
appsec (1.742 ms) : 1719, 1766
.   : milestone, 1742,
appsec_no_iast (1.754 ms) : 1730, 1778
.   : milestone, 1754,
code_origins (1.674 ms) : 1647, 1701
.   : milestone, 1674,
iast (1.534 ms) : 1511, 1558
.   : milestone, 1534,
profiling (1.519 ms) : 1495, 1543
.   : milestone, 1519,
tracing (1.522 ms) : 1498, 1546
.   : milestone, 1522,
section candidate
no_agent (1.372 ms) : 1353, 1392
.   : milestone, 1372,
appsec (1.761 ms) : 1737, 1785
.   : milestone, 1761,
appsec_no_iast (1.74 ms) : 1715, 1765
.   : milestone, 1740,
code_origins (1.689 ms) : 1662, 1716
.   : milestone, 1689,
iast (1.518 ms) : 1495, 1542
.   : milestone, 1518,
profiling (1.548 ms) : 1524, 1572
.   : milestone, 1548,
tracing (1.485 ms) : 1461, 1510
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Ξ” no_agent
no_agent 1.381 ms [1.361 ms, 1.401 ms] -
appsec 1.742 ms [1.719 ms, 1.766 ms] 361.159 Β΅s (26.2%)
appsec_no_iast 1.754 ms [1.73 ms, 1.778 ms] 373.274 Β΅s (27.0%)
code_origins 1.674 ms [1.647 ms, 1.701 ms] 293.065 Β΅s (21.2%)
iast 1.534 ms [1.511 ms, 1.558 ms] 153.531 Β΅s (11.1%)
profiling 1.519 ms [1.495 ms, 1.543 ms] 137.841 Β΅s (10.0%)
tracing 1.522 ms [1.498 ms, 1.546 ms] 140.837 Β΅s (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Ξ” no_agent
no_agent 1.372 ms [1.353 ms, 1.392 ms] -
appsec 1.761 ms [1.737 ms, 1.785 ms] 388.954 Β΅s (28.3%)
appsec_no_iast 1.74 ms [1.715 ms, 1.765 ms] 367.956 Β΅s (26.8%)
code_origins 1.689 ms [1.662 ms, 1.716 ms] 316.686 Β΅s (23.1%)
iast 1.518 ms [1.495 ms, 1.542 ms] 146.091 Β΅s (10.6%)
profiling 1.548 ms [1.524 ms, 1.572 ms] 175.658 Β΅s (12.8%)
tracing 1.485 ms [1.461 ms, 1.51 ms] 113.326 Β΅s (8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741862989 1741870349
git_commit_sha a39a27f cf301ce
release_version 1.48.0-SNAPSHOT~a39a27f5b6 1.48.0-SNAPSHOT~cf301cea71
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741872506 1741872506
ci_job_id 846323460 846323460
ci_pipeline_id 58696311 58696311
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-88rxttzv-project-304-concurrent-1-7cj6iaeb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-88rxttzv-project-304-concurrent-1-7cj6iaeb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.325 ms) : 2282, 2369
.   : milestone, 2325,
iast (2.114 ms) : 2058, 2169
.   : milestone, 2114,
iast_GLOBAL (2.16 ms) : 2103, 2216
.   : milestone, 2160,
profiling (1.967 ms) : 1924, 2011
.   : milestone, 1967,
tracing (1.943 ms) : 1900, 1985
.   : milestone, 1943,
section candidate
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.334 ms) : 2290, 2378
.   : milestone, 2334,
iast (2.117 ms) : 2061, 2172
.   : milestone, 2117,
iast_GLOBAL (2.161 ms) : 2104, 2217
.   : milestone, 2161,
profiling (1.981 ms) : 1936, 2027
.   : milestone, 1981,
tracing (1.94 ms) : 1898, 1983
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Ξ” no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.325 ms [2.282 ms, 2.369 ms] 857.967 Β΅s (58.5%)
iast 2.114 ms [2.058 ms, 2.169 ms] 646.316 Β΅s (44.1%)
iast_GLOBAL 2.16 ms [2.103 ms, 2.216 ms] 692.443 Β΅s (47.2%)
profiling 1.967 ms [1.924 ms, 2.011 ms] 500.298 Β΅s (34.1%)
tracing 1.943 ms [1.9 ms, 1.985 ms] 475.698 Β΅s (32.4%)
  • candidate results
Variant Execution Time [CI 0.99] Ξ” no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.334 ms [2.29 ms, 2.378 ms] 862.136 Β΅s (58.6%)
iast 2.117 ms [2.061 ms, 2.172 ms] 645.302 Β΅s (43.9%)
iast_GLOBAL 2.161 ms [2.104 ms, 2.217 ms] 689.389 Β΅s (46.9%)
profiling 1.981 ms [1.936 ms, 2.027 ms] 509.997 Β΅s (34.7%)
tracing 1.94 ms [1.898 ms, 1.983 ms] 468.782 Β΅s (31.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~cf301cea71, baseline=1.48.0-SNAPSHOT~a39a27f5b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.652 s) : 15652000, 15652000
.   : milestone, 15652000,
appsec (14.731 s) : 14731000, 14731000
.   : milestone, 14731000,
iast (18.553 s) : 18553000, 18553000
.   : milestone, 18553000,
iast_GLOBAL (18.111 s) : 18111000, 18111000
.   : milestone, 18111000,
profiling (15.08 s) : 15080000, 15080000
.   : milestone, 15080000,
tracing (15.015 s) : 15015000, 15015000
.   : milestone, 15015000,
section candidate
no_agent (15.374 s) : 15374000, 15374000
.   : milestone, 15374000,
appsec (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
iast (19.031 s) : 19031000, 19031000
.   : milestone, 19031000,
iast_GLOBAL (18.148 s) : 18148000, 18148000
.   : milestone, 18148000,
profiling (14.804 s) : 14804000, 14804000
.   : milestone, 14804000,
tracing (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Ξ” no_agent
no_agent 15.652 s [15.652 s, 15.652 s] -
appsec 14.731 s [14.731 s, 14.731 s] -921.0 ms (-5.9%)
iast 18.553 s [18.553 s, 18.553 s] 2.901 s (18.5%)
iast_GLOBAL 18.111 s [18.111 s, 18.111 s] 2.459 s (15.7%)
profiling 15.08 s [15.08 s, 15.08 s] -572.0 ms (-3.7%)
tracing 15.015 s [15.015 s, 15.015 s] -637.0 ms (-4.1%)
  • candidate results
Variant Execution Time [CI 0.99] Ξ” no_agent
no_agent 15.374 s [15.374 s, 15.374 s] -
appsec 14.928 s [14.928 s, 14.928 s] -446.0 ms (-2.9%)
iast 19.031 s [19.031 s, 19.031 s] 3.657 s (23.8%)
iast_GLOBAL 18.148 s [18.148 s, 18.148 s] 2.774 s (18.0%)
profiling 14.804 s [14.804 s, 14.804 s] -570.0 ms (-3.7%)
tracing 14.919 s [14.919 s, 14.919 s] -455.0 ms (-3.0%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from dc094dd to c4329c6 Compare February 27, 2025 17:20
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review February 28, 2025 09:14
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Allow login event SDK to be used with appsec disabled Allow login events SDK to be used with appsec disabled Feb 28, 2025
jandro996
jandro996 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! check my comment related with create constants for the tag names

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from c4329c6 to d0b259b Compare February 28, 2025 11:07
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch 5 times, most recently from 21dbd19 to f712970 Compare March 13, 2025 08:12
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from f712970 to cf301ce Compare March 13, 2025 12:52
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 7e831d5 into master Mar 13, 2025
220 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-sdk-appsec-inactive branch March 13, 2025 13:55
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 13, 2025
mtoffl01 pushed a commit that referenced this pull request Mar 24, 2025
@manuel-alvarez-alvarez @mtoffl01
Allow login events SDK to be used with appsec disabled (#8464)
3765fd1 
Allow login event SDK to be used with appsec disabled
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Apr 11, 2025
@github-cash-renovate-jvm-2 @svc-squareup-copybara
This PR contains the following updates:
d84dd5e 
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle
| minor | `11.6.0` -> `11.7.0` |
|
[com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`3.10.2` -> `3.11.0` |
| [com.squareup.okio:okio](https://github.com/square/okio) |
dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`3.10.2` -> `3.11.0` |
|
[com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin)
| plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` ->
`2.16.0` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.47.3` -> `1.48.1` |
| [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.47.3` -> `1.48.1` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.18` -> `2.31.20` |

---

### Release Notes

<details>
<summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary>

###
[`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110)

*2025-04-09*

-   Fix: Clear the deflater's byte array reference
-   New: Faster implementation of `String.decodeHex()` on Kotlin/JS.
- New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use
{}` and `FileSystem.read {}`.
-   Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20].

</details>

<details>
<summary>autonomousapps/dependency-analysis-android-gradle-plugin
(com.autonomousapps.dependency-analysis)</summary>

###
[`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160)

-   \[Feat]: support `com.android.test` projects.
-   \[Feat]: support typesafe project accessors with opt-in.

```kotlin
dependencyAnalysis {
  useTypesafeProjectAccessors(true) // false by default
}
```

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1):
1.48.1

### Components

#### Tracer internal logging

- πŸ› Remove print line causing unnecessary logs
([#&#8203;8687](DataDog/dd-trace-java#8687) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

###
[`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0):
1.48.0

### Known Bugs

> \[!NOTE]
> If you are experiencing issues with spamming timeout logs, please
update to the [latest
version](https://github.com/DataDog/dd-trace-java/releases/latest) or
set
[JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98)
to false.

### Components

#### Application Security Management (IAST)

- ✨ Fix vulnerability location org.jose4j.lang.HashUtil
([#&#8203;8610](DataDog/dd-trace-java#8610) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Fix weak randomness in oracle.ucp.util.OpaqueString
([#&#8203;8609](DataDog/dd-trace-java#8609) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Fix weak hash false positive in
oracle.security.o5logon.O5Logon
([#&#8203;8608](DataDog/dd-trace-java#8608) -
[@&#8203;jandro996](https://github.com/jandro996))
- πŸ› Prevent before callsites targeting constructors in super calls
([#&#8203;8549](DataDog/dd-trace-java#8549) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))

#### Application Security Management (WAF)

- ✨ Update login events public SDK to V2
([#&#8203;8620](DataDog/dd-trace-java#8620) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- πŸ› Send RASP LFI capability only when AppSec is statically enabled
([#&#8203;8573](DataDog/dd-trace-java#8573) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Improve detection of missing request end events
([#&#8203;8510](DataDog/dd-trace-java#8510) -
[@&#8203;smola](https://github.com/smola))
- 🧹 Remove remote configuration for API Security sampling rate
([#&#8203;8486](DataDog/dd-trace-java#8486) -
[@&#8203;smola](https://github.com/smola))
- ✨ Add setUser to user monitoring SDK
([#&#8203;8482](DataDog/dd-trace-java#8482) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Add missing address for signup event
([#&#8203;8469](DataDog/dd-trace-java#8469) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Allow login events SDK to be used with appsec disabled
([#&#8203;8464](DataDog/dd-trace-java#8464) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ Add support for endpoint discovery in spring mvc
([#&#8203;8352](DataDog/dd-trace-java#8352) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- ✨ New API Security sampling algorithm
([#&#8203;8178](DataDog/dd-trace-java#8178) -
[@&#8203;ValentinZakharov](https://github.com/ValentinZakharov))

#### Build & Tooling

- ✨ Add buffer size customizability to JDK UDS support
([#&#8203;8629](DataDog/dd-trace-java#8629) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- ✨ Add JDK built-in support for UDS on Java 16+
([#&#8203;8314](DataDog/dd-trace-java#8314) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

#### Configuration at Runtime

- πŸ› Send RASP LFI capability only when AppSec is statically enabled
([#&#8203;8573](DataDog/dd-trace-java#8573) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Continuous Integration Visibility

- πŸ› Prevent double reporting of Scalatest events when using SBT with
test forking
([#&#8203;8682](DataDog/dd-trace-java#8682) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- πŸ› Shutdown CI Visibility test event handlers before tracer
([#&#8203;8677](DataDog/dd-trace-java#8677) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- πŸ› Do not apply JUnit 4 instrumentation to MUnit runners
([#&#8203;8675](DataDog/dd-trace-java#8675),
[#&#8203;8683](DataDog/dd-trace-java#8683) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Remove error log when source path resolution fails on
isModified check
([#&#8203;8663](DataDog/dd-trace-java#8663) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Implement tests reordering for JUnit 4
([#&#8203;8650](DataDog/dd-trace-java#8650) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- πŸ› Set default Attempt to Fix retries if none provided from the
backend
([#&#8203;8615](DataDog/dd-trace-java#8615) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Allow to manually set PR info
([#&#8203;8566](DataDog/dd-trace-java#8566) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- πŸ› Fix Test Optimization init when repo root cannot be determined
([#&#8203;8533](DataDog/dd-trace-java#8533) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Add capabilities tagging
([#&#8203;8499](DataDog/dd-trace-java#8499),
[#&#8203;8540](DataDog/dd-trace-java#8540) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))

#### Crash tracking

- πŸ› Remove dependency on bash from crash/oome uploder scripts
([#&#8203;8652](DataDog/dd-trace-java#8652) -
[@&#8203;jbachorik](https://github.com/jbachorik))

#### Data Streams Monitoring

- ✨ e2e pipeline configuration when data jobs is enabled
([#&#8203;8553](DataDog/dd-trace-java#8553) -
[@&#8203;kr-igor](https://github.com/kr-igor))

#### Dynamic Instrumentation

- πŸ› Fix In-Product when config is empty
([#&#8203;8679](DataDog/dd-trace-java#8679) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add support for filtering shaded third-party libs
([#&#8203;8612](DataDog/dd-trace-java#8612) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add In-Product Enablement
([#&#8203;8587](DataDog/dd-trace-java#8587) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨⚑ Reduce footprint of SourceFile tracking
([#&#8203;8524](DataDog/dd-trace-java#8524) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨⚑ Optimize the SourceFile tracking
([#&#8203;8520](DataDog/dd-trace-java#8520) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### OpenTracing

- 🧹 Remove activeScope() use in OpenTracing shim
([#&#8203;8478](DataDog/dd-trace-java#8478) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Profiling

- ✨ Add profiler env check command to AgentCLI
([#&#8203;8671](DataDog/dd-trace-java#8671) -
[@&#8203;jbachorik](https://github.com/jbachorik))

- ✨ Bump ddprof to 1.23.0
([#&#8203;8668](DataDog/dd-trace-java#8668) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- Fix a crash related to ElfParser::loadSymbolTable
([#&#8203;191](DataDog/dd-trace-java#191)) by
[@&#8203;yanglong1010](https://github.com/yanglong1010) in
DataDog/java-profiler#192
- Unwind String.indexOf intrinsic on AArch64 by
[@&#8203;MattAlp](https://github.com/MattAlp) in
DataDog/java-profiler#193
- Fix Java 24 support by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#194
- A set of fixes related to clang, aarch64 and musl pecularities of
vmstructs stack unwinder by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#199

- πŸ› Remove process information from JFR recording
([#&#8203;8661](DataDog/dd-trace-java#8661) -
[@&#8203;r1viollet](https://github.com/r1viollet))

- πŸ› Make TempLocationManager USER aware
([#&#8203;8605](DataDog/dd-trace-java#8605) -
[@&#8203;jbachorik](https://github.com/jbachorik))

- ✨ Extract git tags from embedded git.properties and
datadog_git.properties
([#&#8203;8561](DataDog/dd-trace-java#8561) -
[@&#8203;wmouchere](https://github.com/wmouchere))

#### Telemetry

- πŸ› Fix appsec.rasp.error and appsec.waf.error telemetry metrics
([#&#8203;8624](DataDog/dd-trace-java#8624) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Create metric: appsec.rasp.rule.skipped
([#&#8203;8618](DataDog/dd-trace-java#8618) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Extract git tags from embedded git.properties and
datadog_git.properties
([#&#8203;8561](DataDog/dd-trace-java#8561) -
[@&#8203;wmouchere](https://github.com/wmouchere))

#### Testing

- 🧹 Simplify ssi tests one-pipeline
([#&#8203;8558](DataDog/dd-trace-java#8558) -
[@&#8203;robertomonteromiguel](https://github.com/robertomonteromiguel))
- ✨ Add smoke tests for java's concurrent API
([#&#8203;8438](DataDog/dd-trace-java#8438) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

#### Trace context propagation

- ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT`
([#&#8203;8535](DataDog/dd-trace-java#8535) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### Tracer core

- πŸ› Ensure shaded helpers have unique names
([#&#8203;8559](DataDog/dd-trace-java#8559) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Support common config sources for user-provided git info
([#&#8203;8547](DataDog/dd-trace-java#8547) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- ✨ Make the default config sources more robust when a security
manager is installed
([#&#8203;8544](DataDog/dd-trace-java#8544) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Support targeting services with configurations in stable
configuration file
([#&#8203;8526](DataDog/dd-trace-java#8526) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE`
([#&#8203;8296](DataDog/dd-trace-java#8296) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### Tracer internal logging

- πŸ› Add missing debug log for the cloudPayloadTaggingServices config
([#&#8203;8600](DataDog/dd-trace-java#8600) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Add the possibility to output the logs of the Java tracer
in JSON
([#&#8203;8083](DataDog/dd-trace-java#8083) -
[@&#8203;cecile75](https://github.com/cecile75))

#### Tracer public API

- ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config
([#&#8203;8536](DataDog/dd-trace-java#8536) -
[@&#8203;mhlidd](https://github.com/mhlidd))
- ✨ Config Consistency Round 2
([#&#8203;8489](DataDog/dd-trace-java#8489) -
[@&#8203;mhlidd](https://github.com/mhlidd))

### Instrumentations

####

- πŸ› Fix NPE in getMdcCopy of LoggingEventInstrumentation
([#&#8203;8599](DataDog/dd-trace-java#8599) -
[@&#8203;ygree](https://github.com/ygree))

#### Apache Spark instrumentation

- ✨ Instrument Runtime.exit() to finish spark application spans
([#&#8203;8572](DataDog/dd-trace-java#8572) -
[@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd))
- ✨ Configure OpenLineage if present in Spark instrumentation
([#&#8203;8541](DataDog/dd-trace-java#8541) -
[@&#8203;mobuchowski](https://github.com/mobuchowski))

#### Armeria Instrumentation

- ✨ Support armeria grpc 1.32.3
([#&#8203;8606](DataDog/dd-trace-java#8606) -
[@&#8203;github-actions](https://github.com/github-actions)\[bot])

#### AWS DynamoDB Instrumentation

- ✨ Create DynamoDB instrumentation + add span pointers for
`updateItem` and `deleteItem`
([#&#8203;8490](DataDog/dd-trace-java#8490) -
[@&#8203;nhulston](https://github.com/nhulston))

#### AWS SDK instrumentation

- ✨ Add DynamoDB in
DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES
([#&#8203;8595](DataDog/dd-trace-java#8595) -
[@&#8203;joeyzhao2018](https://github.com/joeyzhao2018))

#### Azure Functions instrumentation

- ✨ Enable tracer computed trace metrics by default for Azure
Functions
([#&#8203;8518](DataDog/dd-trace-java#8518) -
[@&#8203;duncanpharvey](https://github.com/duncanpharvey))
- πŸ’‘ Add azure-functions instrumentation
([#&#8203;8432](DataDog/dd-trace-java#8432) -
[@&#8203;duncanpharvey](https://github.com/duncanpharvey))

#### Core Java language instrumentation

- πŸ› Fix ForkJoinPool.execute() instrumentation on Java 21+
([#&#8203;8560](DataDog/dd-trace-java#8560) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Eclipse Vert.x instrumentation

- ✨ Add vertx postgresql client instrumentation
([#&#8203;8471](DataDog/dd-trace-java#8471) -
[@&#8203;vandonr](https://github.com/vandonr) - thanks for the
contribution!)

#### Kafka instrumentation

- ✨ Support and test kafka-clients 4
([#&#8203;8581](DataDog/dd-trace-java#8581) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Kotlin instrumentation

- ✨ Avoid disconnected traces when using Kotlin flowOn
([#&#8203;8651](DataDog/dd-trace-java#8651) -
[@&#8203;mcculls](https://github.com/mcculls))

#### OpenTelemetry instrumentation

- 🧹 Migrate OtelContext wrapper to new internal Context API
([#&#8203;8645](DataDog/dd-trace-java#8645) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Spring instrumentation

- πŸ› Support CompletableFuture on spring webmvc controllers
([#&#8203;8659](DataDog/dd-trace-java#8659) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add support for endpoint discovery in spring mvc
([#&#8203;8352](DataDog/dd-trace-java#8352) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))

#### WebSocket Instrumentation

- ✨ Instrument Jetty websocket pojo
([#&#8203;8562](DataDog/dd-trace-java#8562) -
[@&#8203;amarziali](https://github.com/amarziali))
- πŸ’‘ Instrument Java Websocket API (JSR356)
([#&#8203;8440](DataDog/dd-trace-java#8440) -
[@&#8203;amarziali](https://github.com/amarziali))

#### All other instrumentations

- ✨ Introduce cache for peer.hostname lookup
([#&#8203;8601](DataDog/dd-trace-java#8601) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Support pekko http 1.1
([#&#8203;8532](DataDog/dd-trace-java#8532) -
[@&#8203;amarziali](https://github.com/amarziali))

</details>

---

### Configuration

πŸ“… **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

β™» **Rebasing**: Never, or you tick the rebase/retry checkbox.

πŸ‘» **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@sezen-datadog sezen-datadog sezen-datadog approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @jandro996 @sezen-datadog