-
Notifications
You must be signed in to change notification settings - Fork 301
Preserve old logic to extract jar file name #8756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007791
Total [baseline] (10.562 s) : 0, 10561933
Agent [candidate] (1.006 s) : 0, 1006053
Total [candidate] (10.485 s) : 0, 10484680
section appsec
Agent [baseline] (1.148 s) : 0, 1147852
Total [baseline] (10.686 s) : 0, 10686482
Agent [candidate] (1.151 s) : 0, 1150604
Total [candidate] (10.703 s) : 0, 10703003
section iast
Agent [baseline] (1.135 s) : 0, 1135161
Total [baseline] (10.827 s) : 0, 10826542
Agent [candidate] (1.133 s) : 0, 1132885
Total [candidate] (10.826 s) : 0, 10825537
section profiling
Agent [baseline] (1.257 s) : 0, 1256593
Total [baseline] (10.833 s) : 0, 10833361
Agent [candidate] (1.255 s) : 0, 1254732
Total [candidate] (10.719 s) : 0, 10718831
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.588 ms) : 0, 671588
BytebuddyAgent [candidate] (670.053 ms) : 0, 670053
GlobalTracer [baseline] (240.453 ms) : 0, 240453
GlobalTracer [candidate] (239.856 ms) : 0, 239856
AppSec [baseline] (54.69 ms) : 0, 54690
AppSec [candidate] (54.503 ms) : 0, 54503
Debugger [baseline] (6.937 ms) : 0, 6937
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (694.36 µs) : 0, 694
Remote Config [candidate] (703.363 µs) : 0, 703
Telemetry [baseline] (9.874 ms) : 0, 9874
Telemetry [candidate] (11.377 ms) : 0, 11377
section appsec
BytebuddyAgent [baseline] (687.14 ms) : 0, 687140
BytebuddyAgent [candidate] (690.3 ms) : 0, 690300
GlobalTracer [baseline] (236.705 ms) : 0, 236705
GlobalTracer [candidate] (236.74 ms) : 0, 236740
AppSec [baseline] (174.492 ms) : 0, 174492
AppSec [candidate] (174.536 ms) : 0, 174536
Debugger [baseline] (5.898 ms) : 0, 5898
Debugger [candidate] (5.9 ms) : 0, 5900
Remote Config [baseline] (633.522 µs) : 0, 634
Remote Config [candidate] (641.833 µs) : 0, 642
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.149 ms) : 0, 8149
IAST [baseline] (21.978 ms) : 0, 21978
IAST [candidate] (21.793 ms) : 0, 21793
section iast
BytebuddyAgent [baseline] (789.036 ms) : 0, 789036
BytebuddyAgent [candidate] (787.13 ms) : 0, 787130
GlobalTracer [baseline] (229.529 ms) : 0, 229529
GlobalTracer [candidate] (229.33 ms) : 0, 229330
AppSec [baseline] (56.077 ms) : 0, 56077
AppSec [candidate] (56.311 ms) : 0, 56311
Debugger [baseline] (5.872 ms) : 0, 5872
Debugger [candidate] (5.835 ms) : 0, 5835
Remote Config [baseline] (579.312 µs) : 0, 579
Remote Config [candidate] (584.239 µs) : 0, 584
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.844 ms) : 0, 7844
IAST [baseline] (22.754 ms) : 0, 22754
IAST [candidate] (22.54 ms) : 0, 22540
section profiling
ProfilingAgent [baseline] (96.041 ms) : 0, 96041
ProfilingAgent [candidate] (96.311 ms) : 0, 96311
BytebuddyAgent [baseline] (661.986 ms) : 0, 661986
BytebuddyAgent [candidate] (660.37 ms) : 0, 660370
GlobalTracer [baseline] (378.077 ms) : 0, 378077
GlobalTracer [candidate] (378.337 ms) : 0, 378337
AppSec [baseline] (54.812 ms) : 0, 54812
AppSec [candidate] (53.809 ms) : 0, 53809
Debugger [baseline] (6.121 ms) : 0, 6121
Debugger [candidate] (6.132 ms) : 0, 6132
Remote Config [baseline] (658.003 µs) : 0, 658
Remote Config [candidate] (647.707 µs) : 0, 648
Telemetry [baseline] (8.107 ms) : 0, 8107
Telemetry [candidate] (8.18 ms) : 0, 8180
Profiling [baseline] (96.065 ms) : 0, 96065
Profiling [candidate] (96.335 ms) : 0, 96335
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013968
Total [baseline] (8.635 s) : 0, 8635485
Agent [candidate] (1.003 s) : 0, 1003133
Total [candidate] (8.628 s) : 0, 8628269
section iast
Agent [baseline] (1.134 s) : 0, 1134134
Total [baseline] (9.175 s) : 0, 9174642
Agent [candidate] (1.136 s) : 0, 1135656
Total [candidate] (9.239 s) : 0, 9238568
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.138 s) : 0, 1138093
Total [baseline] (9.22 s) : 0, 9219616
Agent [candidate] (1.135 s) : 0, 1135258
Total [candidate] (9.16 s) : 0, 9160100
section iast_TELEMETRY_OFF
Agent [baseline] (1.13 s) : 0, 1130109
Total [baseline] (9.205 s) : 0, 9204873
Agent [candidate] (1.132 s) : 0, 1131618
Total [candidate] (9.192 s) : 0, 9191530
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.442 ms) : 0, 675442
BytebuddyAgent [candidate] (668.799 ms) : 0, 668799
GlobalTracer [baseline] (241.793 ms) : 0, 241793
GlobalTracer [candidate] (239.7 ms) : 0, 239700
AppSec [baseline] (54.857 ms) : 0, 54857
AppSec [candidate] (54.523 ms) : 0, 54523
Debugger [baseline] (6.907 ms) : 0, 6907
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (696.529 µs) : 0, 697
Remote Config [candidate] (693.743 µs) : 0, 694
Telemetry [baseline] (10.608 ms) : 0, 10608
Telemetry [candidate] (9.74 ms) : 0, 9740
section iast
BytebuddyAgent [baseline] (788.447 ms) : 0, 788447
BytebuddyAgent [candidate] (789.136 ms) : 0, 789136
GlobalTracer [baseline] (229.023 ms) : 0, 229023
GlobalTracer [candidate] (229.728 ms) : 0, 229728
IAST [baseline] (22.753 ms) : 0, 22753
IAST [candidate] (22.661 ms) : 0, 22661
AppSec [baseline] (56.338 ms) : 0, 56338
AppSec [candidate] (56.378 ms) : 0, 56378
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.899 ms) : 0, 5899
Remote Config [baseline] (579.427 µs) : 0, 579
Remote Config [candidate] (587.378 µs) : 0, 587
Telemetry [baseline] (7.768 ms) : 0, 7768
Telemetry [candidate] (7.912 ms) : 0, 7912
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.859 ms) : 0, 790859
BytebuddyAgent [candidate] (788.813 ms) : 0, 788813
GlobalTracer [baseline] (230.13 ms) : 0, 230130
GlobalTracer [candidate] (229.815 ms) : 0, 229815
IAST [baseline] (22.762 ms) : 0, 22762
IAST [candidate] (22.74 ms) : 0, 22740
AppSec [baseline] (56.442 ms) : 0, 56442
AppSec [candidate] (56.138 ms) : 0, 56138
Debugger [baseline] (5.896 ms) : 0, 5896
Debugger [candidate] (5.922 ms) : 0, 5922
Remote Config [baseline] (603.095 µs) : 0, 603
Remote Config [candidate] (603.57 µs) : 0, 604
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.813 ms) : 0, 7813
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.952 ms) : 0, 784952
BytebuddyAgent [candidate] (785.635 ms) : 0, 785635
GlobalTracer [baseline] (229.045 ms) : 0, 229045
GlobalTracer [candidate] (229.677 ms) : 0, 229677
IAST [baseline] (22.227 ms) : 0, 22227
IAST [candidate] (22.267 ms) : 0, 22267
AppSec [baseline] (56.359 ms) : 0, 56359
AppSec [candidate] (56.276 ms) : 0, 56276
Debugger [baseline] (5.868 ms) : 0, 5868
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (594.092 µs) : 0, 594
Remote Config [candidate] (595.431 µs) : 0, 595
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.772 ms) : 0, 7772
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section baseline
no_agent (387.872 µs) : 368, 408
. : milestone, 388,
iast (516.07 µs) : 493, 539
. : milestone, 516,
iast_FULL (738.396 µs) : 715, 762
. : milestone, 738,
iast_GLOBAL (568.386 µs) : 545, 592
. : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (520.848 µs) : 497, 544
. : milestone, 521,
iast_INACTIVE (464.647 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (523.583 µs) : 500, 547
. : milestone, 524,
tracing (464.667 µs) : 442, 487
. : milestone, 465,
section candidate
no_agent (383.445 µs) : 362, 405
. : milestone, 383,
iast (517.714 µs) : 494, 541
. : milestone, 518,
iast_FULL (750.707 µs) : 727, 774
. : milestone, 751,
iast_GLOBAL (572.367 µs) : 549, 595
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (529.098 µs) : 506, 552
. : milestone, 529,
iast_INACTIVE (473.175 µs) : 451, 496
. : milestone, 473,
iast_TELEMETRY_OFF (508.554 µs) : 485, 532
. : milestone, 509,
tracing (464.961 µs) : 443, 487
. : milestone, 465,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section baseline
no_agent (1.363 ms) : 1343, 1382
. : milestone, 1363,
appsec (1.731 ms) : 1707, 1754
. : milestone, 1731,
appsec_no_iast (1.745 ms) : 1722, 1768
. : milestone, 1745,
code_origins (1.687 ms) : 1660, 1713
. : milestone, 1687,
iast (1.515 ms) : 1491, 1539
. : milestone, 1515,
profiling (1.536 ms) : 1513, 1560
. : milestone, 1536,
tracing (1.49 ms) : 1465, 1515
. : milestone, 1490,
section candidate
no_agent (1.354 ms) : 1334, 1373
. : milestone, 1354,
appsec (1.738 ms) : 1715, 1761
. : milestone, 1738,
appsec_no_iast (1.721 ms) : 1697, 1745
. : milestone, 1721,
code_origins (1.663 ms) : 1637, 1690
. : milestone, 1663,
iast (1.527 ms) : 1503, 1551
. : milestone, 1527,
profiling (1.503 ms) : 1480, 1527
. : milestone, 1503,
tracing (1.5 ms) : 1476, 1525
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section baseline
no_agent (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
appsec (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
iast (18.642 s) : 18642000, 18642000
. : milestone, 18642000,
iast_GLOBAL (18.063 s) : 18063000, 18063000
. : milestone, 18063000,
profiling (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
tracing (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
section candidate
no_agent (14.858 s) : 14858000, 14858000
. : milestone, 14858000,
appsec (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
iast (18.358 s) : 18358000, 18358000
. : milestone, 18358000,
iast_GLOBAL (18.116 s) : 18116000, 18116000
. : milestone, 18116000,
profiling (15.246 s) : 15246000, 15246000
. : milestone, 15246000,
tracing (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~0f18d386f2, baseline=1.49.0-SNAPSHOT~c87fa1b08d
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.403 ms) : 2354, 2453
. : milestone, 2403,
iast (2.199 ms) : 2137, 2262
. : milestone, 2199,
iast_GLOBAL (2.239 ms) : 2177, 2302
. : milestone, 2239,
profiling (2.043 ms) : 1993, 2092
. : milestone, 2043,
tracing (2.011 ms) : 1963, 2059
. : milestone, 2011,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.416 ms) : 2366, 2466
. : milestone, 2416,
iast (2.191 ms) : 2129, 2253
. : milestone, 2191,
iast_GLOBAL (2.244 ms) : 2181, 2306
. : milestone, 2244,
profiling (2.041 ms) : 1991, 2091
. : milestone, 2041,
tracing (2.013 ms) : 1965, 2061
. : milestone, 2013,
|
PerfectSlayer
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
During #8698 the
CapturedEnvironment
has been refactored to expose the jar file info. However, some logic has been improved (like matching case-insensitive filename extension or stripping the extension with substring instead of using replace).To avoid risks of changes in the default service naming algorithm, this PR uses the exact code that we had before
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]