Stable Config parsing: Treat empty environment variable or process argument values as empty string #8759

mtoffl01 · 2025-05-02T18:12:54Z

What Does This Do

Modifies stable config file parsing logic to return "" instead of "UNDEFINED".

Motivation

While "UNDEFINED" may have been meaningful or helpful for string-based configuration values, it doesn't make sense for non-string configurations. Non-string values can't transform "UNDEFINED", so they fall back to their defaults anyway. This change simplifies the behavior by returning an empty string ("") and logging a debug message to indicate what's happening.

In an environment where DD_ENV is not set....

DD_SERVICE: {{environment_variables: ['DD_ENV']}} resolves to DD_SERVICE: "". As a result, the default service name is used
DD_SERVICE: prefix-{{environment_variables: ['DD_ENV']}}-suffix resolves to DD_SERVICE: "prefix--suffix". As a result, "prefix--suffix" is the service name
DD_PROFILING_ENABLED: {{environment_variables: ['DD_ENV']}} resolves to DD_PROFILING_ENABLED: "". As a result, the default setting (false) is used

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…rying key-vals

…ith tests

…values in template variable

pr-commenter · 2025-05-02T18:57:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg_fix_2
git_commit_date	1746789389	1748505518
git_commit_sha	`ad6d5fe`	`4213b94`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~4213b94000

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748508043	1748508043
ci_job_id	959035352	959035352
ci_pipeline_id	66405712	66405712
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-jcqxzdvc-project-304-concurrent-0-w95rjnhb 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-jcqxzdvc-project-304-concurrent-0-w95rjnhb 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 52 metrics, 14 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Config	worse [+32.179µs; +83.510µs] or [+4.691%; +12.173%]	743.848µs	686.004µs
scenario:startup:petclinic:profiling:ProfilingAgent	better [-9.213ms; -2.864ms] or [-8.338%; -2.592%]	104.459ms	110.498ms
scenario:startup:petclinic:profiling:GlobalTracer	better [-23.816ms; -15.457ms] or [-6.274%; -4.072%]	359.943ms	379.580ms
scenario:startup:petclinic:profiling:AppSec	worse [+5.466ms; +8.635ms] or [+9.984%; +15.772%]	61.797ms	54.747ms
scenario:startup:petclinic:profiling:Profiling	better [-9.216ms; -2.867ms] or [-8.338%; -2.594%]	104.484ms	110.525ms

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029315
Total [baseline] (10.493 s) : 0, 10493408
Agent [candidate] (1.026 s) : 0, 1025680
Total [candidate] (10.523 s) : 0, 10523362
section appsec
Agent [baseline] (1.161 s) : 0, 1161367
Total [baseline] (10.688 s) : 0, 10687664
Agent [candidate] (1.172 s) : 0, 1171743
Total [candidate] (10.685 s) : 0, 10685029
section iast
Agent [baseline] (1.15 s) : 0, 1149861
Total [baseline] (10.906 s) : 0, 10905749
Agent [candidate] (1.161 s) : 0, 1160779
Total [candidate] (10.882 s) : 0, 10882054
section profiling
Agent [baseline] (1.29 s) : 0, 1289727
Total [baseline] (11.012 s) : 0, 11012408
Agent [candidate] (1.267 s) : 0, 1267271
Total [candidate] (10.807 s) : 0, 10806754

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.161 s	132.052 ms (12.8%)
Agent	iast	1.15 s	120.546 ms (11.7%)
Agent	profiling	1.29 s	260.412 ms (25.3%)
Total	tracing	10.493 s	-
Total	appsec	10.688 s	194.256 ms (1.9%)
Total	iast	10.906 s	412.341 ms (3.9%)
Total	profiling	11.012 s	519.0 ms (4.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.026 s	-
Agent	appsec	1.172 s	146.063 ms (14.2%)
Agent	iast	1.161 s	135.099 ms (13.2%)
Agent	profiling	1.267 s	241.591 ms (23.6%)
Total	tracing	10.523 s	-
Total	appsec	10.685 s	161.667 ms (1.5%)
Total	iast	10.882 s	358.692 ms (3.4%)
Total	profiling	10.807 s	283.392 ms (2.7%)

gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.327 ms) : 0, 688327
BytebuddyAgent [candidate] (686.277 ms) : 0, 686277
GlobalTracer [baseline] (241.508 ms) : 0, 241508
GlobalTracer [candidate] (241.296 ms) : 0, 241296
AppSec [baseline] (55.497 ms) : 0, 55497
AppSec [candidate] (56.559 ms) : 0, 56559
Debugger [baseline] (8.381 ms) : 0, 8381
Debugger [candidate] (6.169 ms) : 0, 6169
Remote Config [baseline] (692.837 µs) : 0, 693
Remote Config [candidate] (729.856 µs) : 0, 730
Telemetry [baseline] (11.23 ms) : 0, 11230
Telemetry [candidate] (11.139 ms) : 0, 11139
section appsec
BytebuddyAgent [baseline] (700.348 ms) : 0, 700348
BytebuddyAgent [candidate] (706.921 ms) : 0, 706921
GlobalTracer [baseline] (236.368 ms) : 0, 236368
GlobalTracer [candidate] (239.513 ms) : 0, 239513
AppSec [baseline] (176.291 ms) : 0, 176291
AppSec [candidate] (176.62 ms) : 0, 176620
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (5.984 ms) : 0, 5984
Remote Config [baseline] (629.137 µs) : 0, 629
Remote Config [candidate] (643.385 µs) : 0, 643
Telemetry [baseline] (7.424 ms) : 0, 7424
Telemetry [candidate] (7.336 ms) : 0, 7336
IAST [baseline] (21.641 ms) : 0, 21641
IAST [candidate] (22.141 ms) : 0, 22141
section iast
BytebuddyAgent [baseline] (802.804 ms) : 0, 802804
BytebuddyAgent [candidate] (810.623 ms) : 0, 810623
GlobalTracer [baseline] (230.621 ms) : 0, 230621
GlobalTracer [candidate] (232.837 ms) : 0, 232837
AppSec [baseline] (50.225 ms) : 0, 50225
AppSec [candidate] (52.097 ms) : 0, 52097
Debugger [baseline] (5.907 ms) : 0, 5907
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (603.397 µs) : 0, 603
Remote Config [candidate] (591.97 µs) : 0, 592
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (7.956 ms) : 0, 7956
IAST [baseline] (28.265 ms) : 0, 28265
IAST [candidate] (27.023 ms) : 0, 27023
section profiling
BytebuddyAgent [baseline] (678.926 ms) : 0, 678926
BytebuddyAgent [candidate] (675.465 ms) : 0, 675465
GlobalTracer [baseline] (379.58 ms) : 0, 379580
GlobalTracer [candidate] (359.943 ms) : 0, 359943
AppSec [baseline] (54.747 ms) : 0, 54747
AppSec [candidate] (61.797 ms) : 0, 61797
Debugger [baseline] (6.18 ms) : 0, 6180
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (668.26 µs) : 0, 668
Remote Config [candidate] (638.853 µs) : 0, 639
Telemetry [baseline] (8.2 ms) : 0, 8200
Telemetry [candidate] (8.087 ms) : 0, 8087
ProfilingAgent [baseline] (110.498 ms) : 0, 110498
ProfilingAgent [candidate] (104.459 ms) : 0, 104459
Profiling [baseline] (110.525 ms) : 0, 110525
Profiling [candidate] (104.484 ms) : 0, 104484

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021006
Total [baseline] (8.646 s) : 0, 8645950
Agent [candidate] (1.024 s) : 0, 1024231
Total [candidate] (8.652 s) : 0, 8651705
section iast
Agent [baseline] (1.149 s) : 0, 1149351
Total [baseline] (9.217 s) : 0, 9217424
Agent [candidate] (1.151 s) : 0, 1150549
Total [candidate] (9.243 s) : 0, 9243259
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.151 s) : 0, 1150809
Total [baseline] (9.173 s) : 0, 9172563
Agent [candidate] (1.149 s) : 0, 1148846
Total [candidate] (9.189 s) : 0, 9188858
section iast_TELEMETRY_OFF
Agent [baseline] (1.151 s) : 0, 1150900
Total [baseline] (9.197 s) : 0, 9196888
Agent [candidate] (1.147 s) : 0, 1146819
Total [candidate] (9.216 s) : 0, 9216152

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	iast	1.149 s	128.345 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.151 s	129.803 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.151 s	129.894 ms (12.7%)
Total	tracing	8.646 s	-
Total	iast	9.217 s	571.474 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.173 s	526.613 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.197 s	550.938 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.024 s	-
Agent	iast	1.151 s	126.318 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.149 s	124.615 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.147 s	122.588 ms (12.0%)
Total	tracing	8.652 s	-
Total	iast	9.243 s	591.553 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.189 s	537.152 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.216 s	564.447 ms (6.5%)

gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.966 ms) : 0, 682966
BytebuddyAgent [candidate] (684.784 ms) : 0, 684784
GlobalTracer [baseline] (240.105 ms) : 0, 240105
GlobalTracer [candidate] (241.332 ms) : 0, 241332
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (57.051 ms) : 0, 57051
Debugger [baseline] (7.603 ms) : 0, 7603
Debugger [candidate] (6.283 ms) : 0, 6283
Remote Config [baseline] (686.004 µs) : 0, 686
Remote Config [candidate] (743.848 µs) : 0, 744
Telemetry [baseline] (10.557 ms) : 0, 10557
Telemetry [candidate] (10.534 ms) : 0, 10534
section iast
BytebuddyAgent [baseline] (802.466 ms) : 0, 802466
BytebuddyAgent [candidate] (803.166 ms) : 0, 803166
GlobalTracer [baseline] (230.275 ms) : 0, 230275
GlobalTracer [candidate] (231.243 ms) : 0, 231243
AppSec [baseline] (49.593 ms) : 0, 49593
AppSec [candidate] (50.066 ms) : 0, 50066
Debugger [baseline] (5.921 ms) : 0, 5921
Debugger [candidate] (5.898 ms) : 0, 5898
Remote Config [baseline] (602.556 µs) : 0, 603
Remote Config [candidate] (647.806 µs) : 0, 648
Telemetry [baseline] (7.865 ms) : 0, 7865
Telemetry [candidate] (7.849 ms) : 0, 7849
IAST [baseline] (29.161 ms) : 0, 29161
IAST [candidate] (28.186 ms) : 0, 28186
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (803.068 ms) : 0, 803068
BytebuddyAgent [candidate] (801.446 ms) : 0, 801446
GlobalTracer [baseline] (230.916 ms) : 0, 230916
GlobalTracer [candidate] (231.11 ms) : 0, 231110
AppSec [baseline] (49.525 ms) : 0, 49525
AppSec [candidate] (51.606 ms) : 0, 51606
Debugger [baseline] (5.906 ms) : 0, 5906
Debugger [candidate] (5.94 ms) : 0, 5940
Remote Config [baseline] (600.004 µs) : 0, 600
Remote Config [candidate] (591.272 µs) : 0, 591
Telemetry [baseline] (7.981 ms) : 0, 7981
Telemetry [candidate] (7.864 ms) : 0, 7864
IAST [baseline] (28.504 ms) : 0, 28504
IAST [candidate] (26.79 ms) : 0, 26790
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.597 ms) : 0, 804597
BytebuddyAgent [candidate] (799.682 ms) : 0, 799682
GlobalTracer [baseline] (230.138 ms) : 0, 230138
GlobalTracer [candidate] (231.025 ms) : 0, 231025
AppSec [baseline] (54.258 ms) : 0, 54258
AppSec [candidate] (49.386 ms) : 0, 49386
Debugger [baseline] (5.936 ms) : 0, 5936
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (609.432 µs) : 0, 609
Remote Config [candidate] (602.542 µs) : 0, 603
Telemetry [baseline] (7.806 ms) : 0, 7806
Telemetry [candidate] (7.831 ms) : 0, 7831
IAST [baseline] (23.929 ms) : 0, 23929
IAST [candidate] (28.777 ms) : 0, 28777

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-29T08:11:08	2025-05-29T08:18:53
git_branch	master	mtoff/scfg_fix_2
git_commit_date	1746789389	1748505518
git_commit_sha	`ad6d5fe`	`4213b94`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~4213b94000
start_time	2025-05-29T08:10:53	2025-05-29T08:18:39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1748507134	1748507134
ci_job_id	959035353	959035353
ci_pipeline_id	66405712	66405712
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-1degwskk-project-304-concurrent-0-xathmmdx 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-1degwskk-project-304-concurrent-0-xathmmdx 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1349, 1389
.   : milestone, 1369,
appsec (1.723 ms) : 1699, 1746
.   : milestone, 1723,
appsec_no_iast (1.729 ms) : 1706, 1752
.   : milestone, 1729,
code_origins (1.679 ms) : 1652, 1705
.   : milestone, 1679,
iast (1.532 ms) : 1509, 1556
.   : milestone, 1532,
profiling (1.522 ms) : 1499, 1546
.   : milestone, 1522,
tracing (1.506 ms) : 1482, 1531
.   : milestone, 1506,
section candidate
no_agent (1.351 ms) : 1330, 1372
.   : milestone, 1351,
appsec (1.751 ms) : 1727, 1774
.   : milestone, 1751,
appsec_no_iast (1.751 ms) : 1727, 1775
.   : milestone, 1751,
code_origins (1.692 ms) : 1664, 1719
.   : milestone, 1692,
iast (1.545 ms) : 1520, 1570
.   : milestone, 1545,
profiling (1.521 ms) : 1498, 1545
.   : milestone, 1521,
tracing (1.488 ms) : 1464, 1513
.   : milestone, 1488,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.369 ms [1.349 ms, 1.389 ms]	-
appsec	1.723 ms [1.699 ms, 1.746 ms]	353.705 µs (25.8%)
appsec_no_iast	1.729 ms [1.706 ms, 1.752 ms]	359.788 µs (26.3%)
code_origins	1.679 ms [1.652 ms, 1.705 ms]	309.758 µs (22.6%)
iast	1.532 ms [1.509 ms, 1.556 ms]	163.339 µs (11.9%)
profiling	1.522 ms [1.499 ms, 1.546 ms]	153.249 µs (11.2%)
tracing	1.506 ms [1.482 ms, 1.531 ms]	137.248 µs (10.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.33 ms, 1.372 ms]	-
appsec	1.751 ms [1.727 ms, 1.774 ms]	400.118 µs (29.6%)
appsec_no_iast	1.751 ms [1.727 ms, 1.775 ms]	399.964 µs (29.6%)
code_origins	1.692 ms [1.664 ms, 1.719 ms]	341.055 µs (25.2%)
iast	1.545 ms [1.52 ms, 1.57 ms]	194.167 µs (14.4%)
profiling	1.521 ms [1.498 ms, 1.545 ms]	170.663 µs (12.6%)
tracing	1.488 ms [1.464 ms, 1.513 ms]	137.76 µs (10.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (386.576 µs) : 367, 406
.   : milestone, 387,
iast (533.469 µs) : 510, 557
.   : milestone, 533,
iast_FULL (737.524 µs) : 715, 760
.   : milestone, 738,
iast_GLOBAL (564.004 µs) : 542, 586
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (530.499 µs) : 508, 553
.   : milestone, 530,
iast_INACTIVE (473.709 µs) : 451, 496
.   : milestone, 474,
iast_TELEMETRY_OFF (505.492 µs) : 482, 529
.   : milestone, 505,
tracing (466.848 µs) : 444, 490
.   : milestone, 467,
section candidate
no_agent (387.858 µs) : 368, 408
.   : milestone, 388,
iast (526.528 µs) : 505, 548
.   : milestone, 527,
iast_FULL (733.71 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (585.063 µs) : 562, 608
.   : milestone, 585,
iast_HARDCODED_SECRET_DISABLED (522.128 µs) : 500, 544
.   : milestone, 522,
iast_INACTIVE (472.341 µs) : 449, 495
.   : milestone, 472,
iast_TELEMETRY_OFF (514.432 µs) : 492, 537
.   : milestone, 514,
tracing (461.671 µs) : 440, 484
.   : milestone, 462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.576 µs [366.851 µs, 406.302 µs]	-
iast	533.469 µs [509.901 µs, 557.037 µs]	146.893 µs (38.0%)
iast_FULL	737.524 µs [715.499 µs, 759.549 µs]	350.948 µs (90.8%)
iast_GLOBAL	564.004 µs [542.416 µs, 585.593 µs]	177.428 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED	530.499 µs [507.691 µs, 553.307 µs]	143.922 µs (37.2%)
iast_INACTIVE	473.709 µs [451.094 µs, 496.325 µs]	87.133 µs (22.5%)
iast_TELEMETRY_OFF	505.492 µs [482.373 µs, 528.611 µs]	118.916 µs (30.8%)
tracing	466.848 µs [444.1 µs, 489.597 µs]	80.272 µs (20.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.858 µs [368.101 µs, 407.616 µs]	-
iast	526.528 µs [504.769 µs, 548.287 µs]	138.669 µs (35.8%)
iast_FULL	733.71 µs [711.755 µs, 755.665 µs]	345.851 µs (89.2%)
iast_GLOBAL	585.063 µs [561.694 µs, 608.431 µs]	197.204 µs (50.8%)
iast_HARDCODED_SECRET_DISABLED	522.128 µs [500.174 µs, 544.083 µs]	134.27 µs (34.6%)
iast_INACTIVE	472.341 µs [449.414 µs, 495.269 µs]	84.483 µs (21.8%)
iast_TELEMETRY_OFF	514.432 µs [491.742 µs, 537.122 µs]	126.574 µs (32.6%)
tracing	461.671 µs [439.513 µs, 483.829 µs]	73.812 µs (19.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/scfg_fix_2
git_commit_date	1746789389	1748505518
git_commit_sha	`ad6d5fe`	`4213b94`
release_version	1.50.0-SNAPSHOT~ad6d5fef42	1.50.0-SNAPSHOT~4213b94000

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1748507643	1748507643
ci_job_id	959035354	959035354
ci_pipeline_id	66405712	66405712
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-1kw1trhr-project-304-concurrent-0-9ln68ybh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-1kw1trhr-project-304-concurrent-0-9ln68ybh 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.384 ms) : 2336, 2431
.   : milestone, 2384,
iast (2.174 ms) : 2113, 2234
.   : milestone, 2174,
iast_GLOBAL (2.219 ms) : 2158, 2280
.   : milestone, 2219,
profiling (2.023 ms) : 1973, 2072
.   : milestone, 2023,
tracing (1.995 ms) : 1948, 2043
.   : milestone, 1995,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.385 ms) : 2337, 2433
.   : milestone, 2385,
iast (2.168 ms) : 2107, 2228
.   : milestone, 2168,
iast_GLOBAL (2.212 ms) : 2151, 2273
.   : milestone, 2212,
profiling (2.04 ms) : 1991, 2090
.   : milestone, 2040,
tracing (1.994 ms) : 1948, 2041
.   : milestone, 1994,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.384 ms [2.336 ms, 2.431 ms]	913.305 µs (62.1%)
iast	2.174 ms [2.113 ms, 2.234 ms]	703.162 µs (47.8%)
iast_GLOBAL	2.219 ms [2.158 ms, 2.28 ms]	748.494 µs (50.9%)
profiling	2.023 ms [1.973 ms, 2.072 ms]	552.308 µs (37.6%)
tracing	1.995 ms [1.948 ms, 2.043 ms]	525.015 µs (35.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	2.385 ms [2.337 ms, 2.433 ms]	913.396 µs (62.1%)
iast	2.168 ms [2.107 ms, 2.228 ms]	695.946 µs (47.3%)
iast_GLOBAL	2.212 ms [2.151 ms, 2.273 ms]	740.132 µs (50.3%)
profiling	2.04 ms [1.991 ms, 2.09 ms]	568.417 µs (38.6%)
tracing	1.994 ms [1.948 ms, 2.041 ms]	522.617 µs (35.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4213b94000, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.957 s) : 14957000, 14957000
.   : milestone, 14957000,
appsec (15.103 s) : 15103000, 15103000
.   : milestone, 15103000,
iast (19.047 s) : 19047000, 19047000
.   : milestone, 19047000,
iast_GLOBAL (18.01 s) : 18010000, 18010000
.   : milestone, 18010000,
profiling (15.051 s) : 15051000, 15051000
.   : milestone, 15051000,
tracing (15.244 s) : 15244000, 15244000
.   : milestone, 15244000,
section candidate
no_agent (15.559 s) : 15559000, 15559000
.   : milestone, 15559000,
appsec (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
iast (19.052 s) : 19052000, 19052000
.   : milestone, 19052000,
iast_GLOBAL (18.066 s) : 18066000, 18066000
.   : milestone, 18066000,
profiling (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
tracing (14.89 s) : 14890000, 14890000
.   : milestone, 14890000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.957 s [14.957 s, 14.957 s]	-
appsec	15.103 s [15.103 s, 15.103 s]	146.0 ms (1.0%)
iast	19.047 s [19.047 s, 19.047 s]	4.09 s (27.3%)
iast_GLOBAL	18.01 s [18.01 s, 18.01 s]	3.053 s (20.4%)
profiling	15.051 s [15.051 s, 15.051 s]	94.0 ms (0.6%)
tracing	15.244 s [15.244 s, 15.244 s]	287.0 ms (1.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.559 s [15.559 s, 15.559 s]	-
appsec	14.962 s [14.962 s, 14.962 s]	-597.0 ms (-3.8%)
iast	19.052 s [19.052 s, 19.052 s]	3.493 s (22.5%)
iast_GLOBAL	18.066 s [18.066 s, 18.066 s]	2.507 s (16.1%)
profiling	15.011 s [15.011 s, 15.011 s]	-548.0 ms (-3.5%)
tracing	14.89 s [14.89 s, 14.89 s]	-669.0 ms (-4.3%)

github-actions · 2025-05-06T17:02:20Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java

mcculls

+1 but I'd recommend leaving out the debug messages for now

…nto mtoff/scfg_fix_2

mcculls

LGTM

mtoffl01 and others added 17 commits April 10, 2025 12:38

migrate CLIHelper to use a Map, parse system properties in key-vals

d112dc7

Fix processTemplateVar logic to remove superfluous ':'

3ba99af

nits: javadocs

9caeb5d

Move writeFileRaw helper to testutils

d0f194b

Add YamlParser tests

457c288

Revert CLIHelper to use List<String>; lazily load a Map cache for que…

06ae9ac

…rying key-vals

reuse logic for adding to the vm args cache

06712dc

apply github suggestions

0a1da8f

Move processTemplate yaml helper fns into StableConfigParser, along w…

e106416

…ith tests

Remove changes to CLIHelper; rely on System.getProperty instead

48adeaa

optimize: return from processTemplate early if no {{ found

24b8615

Add more test coverage to StableConfigParserTest

cc76954

Merge branch 'master' into mtoff/scfg_fix

afddf95

Optimize template processing to reduce use of substrings

fc4652c

Introduce constants for repeated strings

e633f26

Change UNDEFINED_VALUE to empty string

b5deffd

Add log messages for empty environment_variable and process_argument …

9104f0d

…values in template variable

mtoffl01 mentioned this pull request May 2, 2025

Stable Config file: target system properties in process_arguments and support template variables in YamlParser #8690

Merged

mtoffl01 added 2 commits May 5, 2025 10:25

Remove FileUtils and all its references

ecb5a15

resolve merge conflicts w. master

5b46087

mtoffl01 marked this pull request as ready for review May 6, 2025 17:02

mtoffl01 requested a review from a team as a code owner May 6, 2025 17:02

mtoffl01 requested a review from ygree May 6, 2025 17:02

mtoffl01 assigned mcculls May 6, 2025

Merge branch 'master' into mtoff/scfg_fix_2

fbf809a

mcculls reviewed May 9, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java Outdated Show resolved Hide resolved

mcculls reviewed May 9, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java Outdated Show resolved Hide resolved

mcculls approved these changes May 9, 2025

View reviewed changes

mtoffl01 and others added 4 commits May 27, 2025 12:26

Remove noisy debug logs on UNDEFINED case

a1bba89

Merge branch 'mtoff/scfg_fix_2' of github.com:DataDog/dd-trace-java i…

6dacba4

…nto mtoff/scfg_fix_2

merge with master

eb5e375

Merge branch 'master' into mtoff/scfg_fix_2

4213b94

mcculls approved these changes May 29, 2025

View reviewed changes

mcculls added type: enhancement Enhancements and improvements comp: core Tracer core tag: no release notes Changes to exclude from release notes labels May 29, 2025

mcculls merged commit 631e296 into master May 29, 2025
539 of 548 checks passed

mcculls deleted the mtoff/scfg_fix_2 branch May 29, 2025 09:55

github-actions bot added this to the 1.50.0 milestone May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stable Config parsing: Treat empty environment variable or process argument values as empty string #8759

Stable Config parsing: Treat empty environment variable or process argument values as empty string #8759

Uh oh!

mtoffl01 commented May 2, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented May 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

mcculls left a comment

Uh oh!

mcculls left a comment

Uh oh!

Uh oh!

Uh oh!

Stable Config parsing: Treat empty environment variable or process argument values as empty string #8759

Stable Config parsing: Treat empty environment variable or process argument values as empty string #8759

Uh oh!

Conversation

mtoffl01 commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mtoffl01 commented May 2, 2025 •

edited

Loading

pr-commenter bot commented May 2, 2025 •

edited

Loading

github-actions bot commented May 6, 2025 •

edited

Loading