-
Notifications
You must be signed in to change notification settings - Fork 301
check for spark.openlineage.run.tags
in OL Spark conf in AbstractSparkListenerTest
#8767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…arkListenerTest Signed-off-by: Maciej Obuchowski <[email protected]>
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 7 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1011225
Total [baseline] (8.63 s) : 0, 8629617
Agent [candidate] (1.009 s) : 0, 1008690
Total [candidate] (8.632 s) : 0, 8631862
section iast
Agent [baseline] (1.142 s) : 0, 1141736
Total [baseline] (9.174 s) : 0, 9174453
Agent [candidate] (1.134 s) : 0, 1134322
Total [candidate] (9.229 s) : 0, 9229348
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.138 s) : 0, 1137821
Total [baseline] (9.177 s) : 0, 9176570
Agent [candidate] (1.164 s) : 0, 1164189
Total [candidate] (9.275 s) : 0, 9275271
section iast_TELEMETRY_OFF
Agent [baseline] (1.138 s) : 0, 1138234
Total [baseline] (9.19 s) : 0, 9190177
Agent [candidate] (1.133 s) : 0, 1133178
Total [candidate] (9.203 s) : 0, 9203100
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.996 ms) : 0, 673996
BytebuddyAgent [candidate] (673.539 ms) : 0, 673539
GlobalTracer [baseline] (240.573 ms) : 0, 240573
GlobalTracer [candidate] (240.732 ms) : 0, 240732
AppSec [baseline] (54.881 ms) : 0, 54881
AppSec [candidate] (54.783 ms) : 0, 54783
Debugger [baseline] (7.648 ms) : 0, 7648
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (704.86 µs) : 0, 705
Remote Config [candidate] (695.28 µs) : 0, 695
Telemetry [baseline] (9.888 ms) : 0, 9888
Telemetry [candidate] (9.238 ms) : 0, 9238
section iast
BytebuddyAgent [baseline] (795.208 ms) : 0, 795208
BytebuddyAgent [candidate] (787.618 ms) : 0, 787618
GlobalTracer [baseline] (230.403 ms) : 0, 230403
GlobalTracer [candidate] (229.972 ms) : 0, 229972
IAST [baseline] (22.695 ms) : 0, 22695
IAST [candidate] (22.743 ms) : 0, 22743
AppSec [baseline] (55.68 ms) : 0, 55680
AppSec [candidate] (56.315 ms) : 0, 56315
Debugger [baseline] (5.859 ms) : 0, 5859
Debugger [candidate] (5.863 ms) : 0, 5863
Remote Config [baseline] (585.638 µs) : 0, 586
Remote Config [candidate] (587.33 µs) : 0, 587
Telemetry [baseline] (7.834 ms) : 0, 7834
Telemetry [candidate] (7.782 ms) : 0, 7782
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.196 ms) : 0, 790196
BytebuddyAgent [candidate] (810.094 ms) : 0, 810094
GlobalTracer [baseline] (230.383 ms) : 0, 230383
GlobalTracer [candidate] (235.285 ms) : 0, 235285
IAST [baseline] (22.9 ms) : 0, 22900
IAST [candidate] (23.472 ms) : 0, 23472
AppSec [baseline] (56.424 ms) : 0, 56424
AppSec [candidate] (56.981 ms) : 0, 56981
Debugger [baseline] (5.922 ms) : 0, 5922
Debugger [candidate] (6.029 ms) : 0, 6029
Remote Config [baseline] (599.806 µs) : 0, 600
Remote Config [candidate] (610.889 µs) : 0, 611
Telemetry [baseline] (7.933 ms) : 0, 7933
Telemetry [candidate] (8.139 ms) : 0, 8139
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (791.072 ms) : 0, 791072
BytebuddyAgent [candidate] (786.711 ms) : 0, 786711
GlobalTracer [baseline] (230.352 ms) : 0, 230352
GlobalTracer [candidate] (229.954 ms) : 0, 229954
IAST [baseline] (22.327 ms) : 0, 22327
IAST [candidate] (22.379 ms) : 0, 22379
AppSec [baseline] (56.493 ms) : 0, 56493
AppSec [candidate] (56.471 ms) : 0, 56471
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (5.903 ms) : 0, 5903
Remote Config [baseline] (611.365 µs) : 0, 611
Remote Config [candidate] (593.02 µs) : 0, 593
Telemetry [baseline] (7.853 ms) : 0, 7853
Telemetry [candidate] (7.735 ms) : 0, 7735
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003743
Total [baseline] (10.446 s) : 0, 10446225
Agent [candidate] (1.008 s) : 0, 1008472
Total [candidate] (10.468 s) : 0, 10467895
section appsec
Agent [baseline] (1.155 s) : 0, 1154631
Total [baseline] (10.67 s) : 0, 10669827
Agent [candidate] (1.148 s) : 0, 1147655
Total [candidate] (10.647 s) : 0, 10646579
section iast
Agent [baseline] (1.137 s) : 0, 1136761
Total [baseline] (10.773 s) : 0, 10773221
Agent [candidate] (1.136 s) : 0, 1135874
Total [candidate] (10.792 s) : 0, 10791778
section profiling
Agent [baseline] (1.269 s) : 0, 1269172
Total [baseline] (10.771 s) : 0, 10771453
Agent [candidate] (1.255 s) : 0, 1254832
Total [candidate] (10.829 s) : 0, 10829292
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.27 ms) : 0, 669270
BytebuddyAgent [candidate] (671.184 ms) : 0, 671184
GlobalTracer [baseline] (239.668 ms) : 0, 239668
GlobalTracer [candidate] (240.815 ms) : 0, 240815
AppSec [baseline] (54.557 ms) : 0, 54557
AppSec [candidate] (54.673 ms) : 0, 54673
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.146 ms) : 0, 6146
Remote Config [baseline] (697.124 µs) : 0, 697
Remote Config [candidate] (689.27 µs) : 0, 689
Telemetry [baseline] (9.887 ms) : 0, 9887
Telemetry [candidate] (11.541 ms) : 0, 11541
section appsec
BytebuddyAgent [baseline] (692.884 ms) : 0, 692884
BytebuddyAgent [candidate] (687.838 ms) : 0, 687838
GlobalTracer [baseline] (237.619 ms) : 0, 237619
GlobalTracer [candidate] (236.501 ms) : 0, 236501
AppSec [baseline] (175.43 ms) : 0, 175430
AppSec [candidate] (175.072 ms) : 0, 175072
Debugger [baseline] (5.878 ms) : 0, 5878
Debugger [candidate] (5.891 ms) : 0, 5891
Remote Config [baseline] (636.817 µs) : 0, 637
Remote Config [candidate] (635.174 µs) : 0, 635
Telemetry [baseline] (7.771 ms) : 0, 7771
Telemetry [candidate] (7.401 ms) : 0, 7401
IAST [baseline] (21.697 ms) : 0, 21697
IAST [candidate] (21.781 ms) : 0, 21781
section iast
BytebuddyAgent [baseline] (789.994 ms) : 0, 789994
BytebuddyAgent [candidate] (788.552 ms) : 0, 788552
GlobalTracer [baseline] (230.074 ms) : 0, 230074
GlobalTracer [candidate] (230.089 ms) : 0, 230089
AppSec [baseline] (56.041 ms) : 0, 56041
AppSec [candidate] (56.564 ms) : 0, 56564
Debugger [baseline] (5.903 ms) : 0, 5903
Debugger [candidate] (5.902 ms) : 0, 5902
Remote Config [baseline] (584.7 µs) : 0, 585
Remote Config [candidate] (590.652 µs) : 0, 591
Telemetry [baseline] (7.884 ms) : 0, 7884
Telemetry [candidate] (7.896 ms) : 0, 7896
IAST [baseline] (22.791 ms) : 0, 22791
IAST [candidate] (22.871 ms) : 0, 22871
section profiling
BytebuddyAgent [baseline] (668.068 ms) : 0, 668068
BytebuddyAgent [candidate] (660.608 ms) : 0, 660608
GlobalTracer [baseline] (380.927 ms) : 0, 380927
GlobalTracer [candidate] (379.064 ms) : 0, 379064
AppSec [baseline] (54.806 ms) : 0, 54806
AppSec [candidate] (53.801 ms) : 0, 53801
Debugger [baseline] (6.251 ms) : 0, 6251
Debugger [candidate] (6.176 ms) : 0, 6176
Remote Config [baseline] (685.116 µs) : 0, 685
Remote Config [candidate] (639.596 µs) : 0, 640
Telemetry [baseline] (9.037 ms) : 0, 9037
Telemetry [candidate] (8.162 ms) : 0, 8162
ProfilingAgent [baseline] (98.203 ms) : 0, 98203
ProfilingAgent [candidate] (96.143 ms) : 0, 96143
Profiling [baseline] (98.227 ms) : 0, 98227
Profiling [candidate] (96.167 ms) : 0, 96167
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
. : milestone, 1369,
appsec (1.744 ms) : 1721, 1767
. : milestone, 1744,
appsec_no_iast (1.769 ms) : 1746, 1793
. : milestone, 1769,
code_origins (1.685 ms) : 1658, 1712
. : milestone, 1685,
iast (1.521 ms) : 1497, 1546
. : milestone, 1521,
profiling (1.526 ms) : 1502, 1549
. : milestone, 1526,
tracing (1.476 ms) : 1452, 1500
. : milestone, 1476,
section candidate
no_agent (1.377 ms) : 1357, 1397
. : milestone, 1377,
appsec (1.741 ms) : 1718, 1764
. : milestone, 1741,
appsec_no_iast (1.761 ms) : 1737, 1785
. : milestone, 1761,
code_origins (1.676 ms) : 1649, 1703
. : milestone, 1676,
iast (1.534 ms) : 1509, 1558
. : milestone, 1534,
profiling (1.527 ms) : 1504, 1551
. : milestone, 1527,
tracing (1.497 ms) : 1472, 1522
. : milestone, 1497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (398.188 µs) : 378, 418
. : milestone, 398,
iast (536.853 µs) : 514, 560
. : milestone, 537,
iast_FULL (740.011 µs) : 716, 764
. : milestone, 740,
iast_GLOBAL (581.823 µs) : 558, 605
. : milestone, 582,
iast_HARDCODED_SECRET_DISABLED (524.443 µs) : 502, 547
. : milestone, 524,
iast_INACTIVE (474.464 µs) : 452, 497
. : milestone, 474,
iast_TELEMETRY_OFF (526.435 µs) : 503, 549
. : milestone, 526,
tracing (470.553 µs) : 449, 492
. : milestone, 471,
section candidate
no_agent (392.093 µs) : 372, 412
. : milestone, 392,
iast (531.999 µs) : 509, 555
. : milestone, 532,
iast_FULL (742.029 µs) : 718, 766
. : milestone, 742,
iast_GLOBAL (565.842 µs) : 543, 589
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (533.803 µs) : 511, 557
. : milestone, 534,
iast_INACTIVE (479.169 µs) : 456, 502
. : milestone, 479,
iast_TELEMETRY_OFF (514.56 µs) : 491, 538
. : milestone, 515,
tracing (462.805 µs) : 442, 484
. : milestone, 463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
appsec (14.91 s) : 14910000, 14910000
. : milestone, 14910000,
iast (19.065 s) : 19065000, 19065000
. : milestone, 19065000,
iast_GLOBAL (18.33 s) : 18330000, 18330000
. : milestone, 18330000,
profiling (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
tracing (15.185 s) : 15185000, 15185000
. : milestone, 15185000,
section candidate
no_agent (15.625 s) : 15625000, 15625000
. : milestone, 15625000,
appsec (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
iast (18.527 s) : 18527000, 18527000
. : milestone, 18527000,
iast_GLOBAL (18.233 s) : 18233000, 18233000
. : milestone, 18233000,
profiling (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
tracing (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~37fb874289, baseline=1.49.0-SNAPSHOT~12da6fe499
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.381 ms) : 2334, 2428
. : milestone, 2381,
iast (2.167 ms) : 2107, 2227
. : milestone, 2167,
iast_GLOBAL (2.208 ms) : 2148, 2268
. : milestone, 2208,
profiling (2.021 ms) : 1972, 2069
. : milestone, 2021,
tracing (2.0 ms) : 1954, 2046
. : milestone, 2000,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.381 ms) : 2334, 2428
. : milestone, 2381,
iast (2.159 ms) : 2100, 2219
. : milestone, 2159,
iast_GLOBAL (2.205 ms) : 2146, 2265
. : milestone, 2205,
profiling (2.002 ms) : 1955, 2049
. : milestone, 2002,
tracing (1.994 ms) : 1948, 2040
. : milestone, 1994,
|
What Does This Do
Re-adds assertion that was removed to fix master branch on https://github.com/DataDog/dd-trace-java/pull/8731/files#diff-895ee41410a61d443a629b6b16bd26015bb63a5dfd1161be772b93a92c6adf97
Properly sets up
InstanceStore
so that relevant condition gets tested.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]