Fixed `Error` handling for trace interceptors. #9097

AlexeyKuznetsov-DD · 2025-07-03T18:31:23Z

What Does This Do

Improved error handling for custom TraceInterceptor to gracefully handle cases where user code throws an Error.

Motivation

This PR addresses an issue where user code may throw an Error instead of an Exception. Since Error is not a subclass of Exception, such cases are not caught by standard exception handling logic. As a result, this can lead to the application hanging on exit, due to unhandled errors disrupting proper shutdown procedures.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-03T19:02:17Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/fixed-error-handling-telemetry-interceptor
git_commit_date	1751890694	1751893562
git_commit_sha	`796bf33`	`20dbdb7`
release_version	1.51.0-SNAPSHOT~796bf33ae2	1.51.0-SNAPSHOT~20dbdb752f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751895363	1751895363
ci_job_id	1015910677	1015910677
ci_pipeline_id	69771216	69771216
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7fl2ppmi 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7fl2ppmi 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (993.067 ms) : 0, 993067
Total [baseline] (10.576 s) : 0, 10575703
Agent [candidate] (992.852 ms) : 0, 992852
Total [candidate] (10.588 s) : 0, 10587917
section appsec
Agent [baseline] (1.172 s) : 0, 1172343
Total [baseline] (10.804 s) : 0, 10803580
Agent [candidate] (1.172 s) : 0, 1172449
Total [candidate] (10.813 s) : 0, 10813212
section iast
Agent [baseline] (1.135 s) : 0, 1134622
Total [baseline] (10.835 s) : 0, 10834761
Agent [candidate] (1.135 s) : 0, 1134966
Total [candidate] (10.792 s) : 0, 10791640
section profiling
Agent [baseline] (1.245 s) : 0, 1244809
Total [baseline] (10.841 s) : 0, 10841428
Agent [candidate] (1.264 s) : 0, 1263744
Total [candidate] (11.053 s) : 0, 11052758

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	993.067 ms	-
Agent	appsec	1.172 s	179.276 ms (18.1%)
Agent	iast	1.135 s	141.555 ms (14.3%)
Agent	profiling	1.245 s	251.742 ms (25.3%)
Total	tracing	10.576 s	-
Total	appsec	10.804 s	227.876 ms (2.2%)
Total	iast	10.835 s	259.058 ms (2.4%)
Total	profiling	10.841 s	265.725 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	992.852 ms	-
Agent	appsec	1.172 s	179.597 ms (18.1%)
Agent	iast	1.135 s	142.114 ms (14.3%)
Agent	profiling	1.264 s	270.892 ms (27.3%)
Total	tracing	10.588 s	-
Total	appsec	10.813 s	225.295 ms (2.1%)
Total	iast	10.792 s	203.724 ms (1.9%)
Total	profiling	11.053 s	464.842 ms (4.4%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.744 ms) : 0, 685744
BytebuddyAgent [candidate] (685.985 ms) : 0, 685985
GlobalTracer [baseline] (241.398 ms) : 0, 241398
GlobalTracer [candidate] (241.136 ms) : 0, 241136
AppSec [baseline] (30.151 ms) : 0, 30151
AppSec [candidate] (30.072 ms) : 0, 30072
Debugger [baseline] (6.017 ms) : 0, 6017
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (682.598 µs) : 0, 683
Remote Config [candidate] (666.426 µs) : 0, 666
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.166 ms) : 0, 8166
section appsec
BytebuddyAgent [baseline] (708.192 ms) : 0, 708192
BytebuddyAgent [candidate] (708.154 ms) : 0, 708154
GlobalTracer [baseline] (234.486 ms) : 0, 234486
GlobalTracer [candidate] (234.878 ms) : 0, 234878
AppSec [baseline] (171.381 ms) : 0, 171381
AppSec [candidate] (171.035 ms) : 0, 171035
Debugger [baseline] (5.783 ms) : 0, 5783
Debugger [candidate] (5.764 ms) : 0, 5764
Remote Config [baseline] (605.319 µs) : 0, 605
Remote Config [candidate] (613.995 µs) : 0, 614
Telemetry [baseline] (8.094 ms) : 0, 8094
Telemetry [candidate] (8.094 ms) : 0, 8094
IAST [baseline] (23.057 ms) : 0, 23057
IAST [candidate] (23.166 ms) : 0, 23166
section iast
BytebuddyAgent [baseline] (809.038 ms) : 0, 809038
BytebuddyAgent [candidate] (808.792 ms) : 0, 808792
GlobalTracer [baseline] (233.115 ms) : 0, 233115
GlobalTracer [candidate] (233.307 ms) : 0, 233307
AppSec [baseline] (29.68 ms) : 0, 29680
AppSec [candidate] (28.758 ms) : 0, 28758
Debugger [baseline] (5.799 ms) : 0, 5799
Debugger [candidate] (5.817 ms) : 0, 5817
Remote Config [baseline] (571.657 µs) : 0, 572
Remote Config [candidate] (584.056 µs) : 0, 584
Telemetry [baseline] (7.943 ms) : 0, 7943
Telemetry [candidate] (8.072 ms) : 0, 8072
IAST [baseline] (27.672 ms) : 0, 27672
IAST [candidate] (28.822 ms) : 0, 28822
section profiling
BytebuddyAgent [baseline] (677.503 ms) : 0, 677503
BytebuddyAgent [candidate] (687.326 ms) : 0, 687326
GlobalTracer [baseline] (361.468 ms) : 0, 361468
GlobalTracer [candidate] (366.461 ms) : 0, 366461
AppSec [baseline] (32.959 ms) : 0, 32959
AppSec [candidate] (34.558 ms) : 0, 34558
Debugger [baseline] (10.728 ms) : 0, 10728
Debugger [candidate] (9.269 ms) : 0, 9269
Remote Config [baseline] (661.293 µs) : 0, 661
Remote Config [candidate] (678.289 µs) : 0, 678
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (9.605 ms) : 0, 9605
ProfilingAgent [baseline] (104.111 ms) : 0, 104111
ProfilingAgent [candidate] (106.807 ms) : 0, 106807
Profiling [baseline] (104.134 ms) : 0, 104134
Profiling [candidate] (106.831 ms) : 0, 106831

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (992.363 ms) : 0, 992363
Total [baseline] (8.567 s) : 0, 8567291
Agent [candidate] (996.615 ms) : 0, 996615
Total [candidate] (8.538 s) : 0, 8538108
section iast
Agent [baseline] (1.133 s) : 0, 1133325
Total [baseline] (9.261 s) : 0, 9260516
Agent [candidate] (1.133 s) : 0, 1132980
Total [candidate] (9.25 s) : 0, 9250128

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	992.363 ms	-
Agent	iast	1.133 s	140.962 ms (14.2%)
Total	tracing	8.567 s	-
Total	iast	9.261 s	693.225 ms (8.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	996.615 ms	-
Agent	iast	1.133 s	136.366 ms (13.7%)
Total	tracing	8.538 s	-
Total	iast	9.25 s	712.02 ms (8.3%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.407 ms) : 0, 685407
BytebuddyAgent [candidate] (687.696 ms) : 0, 687696
GlobalTracer [baseline] (241.022 ms) : 0, 241022
GlobalTracer [candidate] (242.649 ms) : 0, 242649
AppSec [baseline] (30.213 ms) : 0, 30213
AppSec [candidate] (30.36 ms) : 0, 30360
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.06 ms) : 0, 6060
Remote Config [baseline] (666.308 µs) : 0, 666
Remote Config [candidate] (678.504 µs) : 0, 679
Telemetry [baseline] (8.166 ms) : 0, 8166
Telemetry [candidate] (8.268 ms) : 0, 8268
section iast
BytebuddyAgent [baseline] (808.453 ms) : 0, 808453
BytebuddyAgent [candidate] (808.032 ms) : 0, 808032
GlobalTracer [baseline] (232.978 ms) : 0, 232978
GlobalTracer [candidate] (232.782 ms) : 0, 232782
AppSec [baseline] (27.818 ms) : 0, 27818
AppSec [candidate] (26.874 ms) : 0, 26874
Debugger [baseline] (5.785 ms) : 0, 5785
Debugger [candidate] (5.853 ms) : 0, 5853
Remote Config [baseline] (575.515 µs) : 0, 576
Remote Config [candidate] (577.903 µs) : 0, 578
Telemetry [baseline] (7.944 ms) : 0, 7944
Telemetry [candidate] (7.921 ms) : 0, 7921
IAST [baseline] (29.049 ms) : 0, 29049
IAST [candidate] (30.226 ms) : 0, 30226

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/fixed-error-handling-telemetry-interceptor
git_commit_date	1751890694	1751893562
git_commit_sha	`796bf33`	`20dbdb7`
release_version	1.51.0-SNAPSHOT~796bf33ae2	1.51.0-SNAPSHOT~20dbdb752f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1751895051	1751895051
ci_job_id	1015910678	1015910678
ci_pipeline_id	69771216	69771216
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-fufbc0n8 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-fufbc0n8 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+211.782µs; +508.070µs] or [+2.460%; +5.901%]	unstable [-81.645op/s; +38.708op/s] or [-15.162%; +7.188%]	8.970ms	517.031op/s	8.610ms	538.500op/s
scenario:load:petclinic:profiling:high_load	worse [+1.516ms; +2.544ms] or [+3.149%; +5.285%]	unstable [-11.199op/s; +3.374op/s] or [-11.520%; +3.471%]	50.168ms	93.300op/s	48.138ms	97.213op/s
scenario:load:petclinic:iast:high_load	worse [+1.407ms; +2.254ms] or [+3.200%; +5.129%]	unstable [-11.899op/s; +3.474op/s] or [-11.181%; +3.264%]	45.788ms	102.213op/s	43.958ms	106.425op/s
scenario:load:petclinic:appsec:high_load	worse [+2.866ms; +3.792ms] or [+6.189%; +8.189%]	unstable [-14.844op/s; -1.239op/s] or [-14.510%; -1.211%]	49.633ms	94.263op/s	46.304ms	102.304op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.383 ms) : 4328, 4438
.   : milestone, 4383,
iast (9.293 ms) : 9140, 9446
.   : milestone, 9293,
iast_FULL (14.278 ms) : 13996, 14560
.   : milestone, 14278,
iast_GLOBAL (10.476 ms) : 10284, 10667
.   : milestone, 10476,
profiling (8.61 ms) : 8476, 8745
.   : milestone, 8610,
tracing (7.884 ms) : 7774, 7995
.   : milestone, 7884,
section candidate
no_agent (4.409 ms) : 4357, 4461
.   : milestone, 4409,
iast (9.604 ms) : 9445, 9763
.   : milestone, 9604,
iast_FULL (13.716 ms) : 13447, 13984
.   : milestone, 13716,
iast_GLOBAL (10.536 ms) : 10349, 10722
.   : milestone, 10536,
profiling (8.97 ms) : 8829, 9111
.   : milestone, 8970,
tracing (7.874 ms) : 7753, 7994
.   : milestone, 7874,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.383 ms [4.328 ms, 4.438 ms]	-
iast	9.293 ms [9.14 ms, 9.446 ms]	4.91 ms (112.0%)
iast_FULL	14.278 ms [13.996 ms, 14.56 ms]	9.895 ms (225.8%)
iast_GLOBAL	10.476 ms [10.284 ms, 10.667 ms]	6.093 ms (139.0%)
profiling	8.61 ms [8.476 ms, 8.745 ms]	4.227 ms (96.4%)
tracing	7.884 ms [7.774 ms, 7.995 ms]	3.501 ms (79.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.409 ms [4.357 ms, 4.461 ms]	-
iast	9.604 ms [9.445 ms, 9.763 ms]	5.195 ms (117.8%)
iast_FULL	13.716 ms [13.447 ms, 13.984 ms]	9.307 ms (211.1%)
iast_GLOBAL	10.536 ms [10.349 ms, 10.722 ms]	6.127 ms (139.0%)
profiling	8.97 ms [8.829 ms, 9.111 ms]	4.561 ms (103.5%)
tracing	7.874 ms [7.753 ms, 7.994 ms]	3.465 ms (78.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.469 ms) : 36174, 36765
.   : milestone, 36469,
appsec (46.304 ms) : 45898, 46710
.   : milestone, 46304,
code_origins (46.001 ms) : 45603, 46399
.   : milestone, 46001,
iast (43.958 ms) : 43572, 44344
.   : milestone, 43958,
profiling (48.138 ms) : 47644, 48633
.   : milestone, 48138,
tracing (43.372 ms) : 43005, 43740
.   : milestone, 43372,
section candidate
no_agent (36.526 ms) : 36226, 36826
.   : milestone, 36526,
appsec (49.633 ms) : 49180, 50086
.   : milestone, 49633,
code_origins (45.436 ms) : 45044, 45828
.   : milestone, 45436,
iast (45.788 ms) : 45386, 46190
.   : milestone, 45788,
profiling (50.168 ms) : 49708, 50628
.   : milestone, 50168,
tracing (44.266 ms) : 43899, 44634
.   : milestone, 44266,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.469 ms [36.174 ms, 36.765 ms]	-
appsec	46.304 ms [45.898 ms, 46.71 ms]	9.835 ms (27.0%)
code_origins	46.001 ms [45.603 ms, 46.399 ms]	9.532 ms (26.1%)
iast	43.958 ms [43.572 ms, 44.344 ms]	7.489 ms (20.5%)
profiling	48.138 ms [47.644 ms, 48.633 ms]	11.669 ms (32.0%)
tracing	43.372 ms [43.005 ms, 43.74 ms]	6.903 ms (18.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.526 ms [36.226 ms, 36.826 ms]	-
appsec	49.633 ms [49.18 ms, 50.086 ms]	13.107 ms (35.9%)
code_origins	45.436 ms [45.044 ms, 45.828 ms]	8.91 ms (24.4%)
iast	45.788 ms [45.386 ms, 46.19 ms]	9.262 ms (25.4%)
profiling	50.168 ms [49.708 ms, 50.628 ms]	13.642 ms (37.3%)
tracing	44.266 ms [43.899 ms, 44.634 ms]	7.74 ms (21.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alexeyk/fixed-error-handling-telemetry-interceptor
git_commit_date	1751890694	1751893562
git_commit_sha	`796bf33`	`20dbdb7`
release_version	1.51.0-SNAPSHOT~796bf33ae2	1.51.0-SNAPSHOT~20dbdb752f

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1751895617	1751895617
ci_job_id	1015910679	1015910679
ci_pipeline_id	69771216	69771216
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-g6t4nw8l 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-g6t4nw8l 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.555 s) : 15555000, 15555000
.   : milestone, 15555000,
appsec (14.832 s) : 14832000, 14832000
.   : milestone, 14832000,
iast (18.433 s) : 18433000, 18433000
.   : milestone, 18433000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
.   : milestone, 17997000,
profiling (15.36 s) : 15360000, 15360000
.   : milestone, 15360000,
tracing (15.132 s) : 15132000, 15132000
.   : milestone, 15132000,
section candidate
no_agent (15.677 s) : 15677000, 15677000
.   : milestone, 15677000,
appsec (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
iast (18.172 s) : 18172000, 18172000
.   : milestone, 18172000,
iast_GLOBAL (17.741 s) : 17741000, 17741000
.   : milestone, 17741000,
profiling (15.106 s) : 15106000, 15106000
.   : milestone, 15106000,
tracing (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.555 s [15.555 s, 15.555 s]	-
appsec	14.832 s [14.832 s, 14.832 s]	-723.0 ms (-4.6%)
iast	18.433 s [18.433 s, 18.433 s]	2.878 s (18.5%)
iast_GLOBAL	17.997 s [17.997 s, 17.997 s]	2.442 s (15.7%)
profiling	15.36 s [15.36 s, 15.36 s]	-195.0 ms (-1.3%)
tracing	15.132 s [15.132 s, 15.132 s]	-423.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.677 s [15.677 s, 15.677 s]	-
appsec	14.922 s [14.922 s, 14.922 s]	-755.0 ms (-4.8%)
iast	18.172 s [18.172 s, 18.172 s]	2.495 s (15.9%)
iast_GLOBAL	17.741 s [17.741 s, 17.741 s]	2.064 s (13.2%)
profiling	15.106 s [15.106 s, 15.106 s]	-571.0 ms (-3.6%)
tracing	15.004 s [15.004 s, 15.004 s]	-673.0 ms (-4.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~20dbdb752f, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.42 ms) : 2371, 2470
.   : milestone, 2420,
iast (2.2 ms) : 2137, 2262
.   : milestone, 2200,
iast_GLOBAL (2.235 ms) : 2173, 2298
.   : milestone, 2235,
profiling (2.482 ms) : 2309, 2655
.   : milestone, 2482,
tracing (2.012 ms) : 1964, 2060
.   : milestone, 2012,
section candidate
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (2.42 ms) : 2370, 2469
.   : milestone, 2420,
iast (2.202 ms) : 2139, 2264
.   : milestone, 2202,
iast_GLOBAL (2.24 ms) : 2177, 2303
.   : milestone, 2240,
profiling (2.057 ms) : 2006, 2108
.   : milestone, 2057,
tracing (2.017 ms) : 1969, 2066
.   : milestone, 2017,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.42 ms [2.371 ms, 2.47 ms]	944.399 µs (64.0%)
iast	2.2 ms [2.137 ms, 2.262 ms]	723.528 µs (49.0%)
iast_GLOBAL	2.235 ms [2.173 ms, 2.298 ms]	759.312 µs (51.4%)
profiling	2.482 ms [2.309 ms, 2.655 ms]	1.006 ms (68.1%)
tracing	2.012 ms [1.964 ms, 2.06 ms]	536.118 µs (36.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	2.42 ms [2.37 ms, 2.469 ms]	938.501 µs (63.4%)
iast	2.202 ms [2.139 ms, 2.264 ms]	720.565 µs (48.6%)
iast_GLOBAL	2.24 ms [2.177 ms, 2.303 ms]	758.848 µs (51.2%)
profiling	2.057 ms [2.006 ms, 2.108 ms]	576.057 µs (38.9%)
tracing	2.017 ms [1.969 ms, 2.066 ms]	536.225 µs (36.2%)

bric3

Some wording nitpicks but overall LGTM

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

Co-authored-by: Brice Dutheil <[email protected]>

…erceptor

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#9083](DataDog/dd-trace-java#9083) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#9028](DataDog/dd-trace-java#9028) - [@jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#8984](DataDog/dd-trace-java#8984) - [@smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#8885](DataDog/dd-trace-java#8885) - [@jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#9022](DataDog/dd-trace-java#9022) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#9015](DataDog/dd-trace-java#9015) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#9009](DataDog/dd-trace-java#9009) - [@smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#8980](DataDog/dd-trace-java#8980) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#8937](DataDog/dd-trace-java#8937) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#9023](DataDog/dd-trace-java#9023) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#8807](DataDog/dd-trace-java#8807) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#9114](DataDog/dd-trace-java#9114) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#9033](DataDog/dd-trace-java#9033) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#8990](DataDog/dd-trace-java#8990) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#8923](DataDog/dd-trace-java#8923) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#8776](DataDog/dd-trace-java#8776) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#9025](DataDog/dd-trace-java#9025) - [@natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#9115](DataDog/dd-trace-java#9115) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#9111](DataDog/dd-trace-java#9111) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#9047](DataDog/dd-trace-java#9047) - [@jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#9034](DataDog/dd-trace-java#9034) - [@jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#8959](DataDog/dd-trace-java#8959) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#8940](DataDog/dd-trace-java#8940) - [@jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang), [@nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#9082](DataDog/dd-trace-java#9082) - [@amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#8394](DataDog/dd-trace-java#8394) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#9071](DataDog/dd-trace-java#9071) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#9119](DataDog/dd-trace-java#9119) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#8988](DataDog/dd-trace-java#8988) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#9110](DataDog/dd-trace-java#9110) - [@PerfectSlayer](https://github.com/PerfectSlayer) [@amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#9045](DataDog/dd-trace-java#9045) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#8875](DataDog/dd-trace-java#8875) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#9037](DataDog/dd-trace-java#9037) - [@mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#9032](DataDog/dd-trace-java#9032) - [@mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#9097](DataDog/dd-trace-java#9097) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#9067](DataDog/dd-trace-java#9067) - [@mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#9019](DataDog/dd-trace-java#9019) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#8952](DataDog/dd-trace-java#8952) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#9030](DataDog/dd-trace-java#9030) - [@bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#9016](DataDog/dd-trace-java#9016) - [@amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e

Fixed Error handling for trace interceptors.

adbd0ad

AlexeyKuznetsov-DD added type: bug Bug report and fix comp: core Tracer core labels Jul 3, 2025

AlexeyKuznetsov-DD marked this pull request as ready for review July 3, 2025 18:31

AlexeyKuznetsov-DD requested a review from a team as a code owner July 3, 2025 18:31

AlexeyKuznetsov-DD requested review from smola and dougqh July 3, 2025 18:31

bric3 reviewed Jul 7, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD and others added 2 commits July 7, 2025 09:05

Update dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java

174d630

Co-authored-by: Brice Dutheil <[email protected]>

Merge branch 'master' into alexeyk/fixed-error-handling-telemetry-int…

20dbdb7

…erceptor

AlexeyKuznetsov-DD requested a review from bric3 July 7, 2025 13:25

dougqh approved these changes Jul 7, 2025

View reviewed changes

bric3 approved these changes Jul 7, 2025

View reviewed changes

AlexeyKuznetsov-DD merged commit 2ee59a9 into master Jul 7, 2025
508 checks passed

AlexeyKuznetsov-DD deleted the alexeyk/fixed-error-handling-telemetry-interceptor branch July 7, 2025 14:49

github-actions bot added this to the 1.51.0 milestone Jul 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed `Error` handling for trace interceptors. #9097

Fixed `Error` handling for trace interceptors. #9097

Uh oh!

AlexeyKuznetsov-DD commented Jul 3, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

bric3 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fixed Error handling for trace interceptors. #9097

Fixed Error handling for trace interceptors. #9097

Uh oh!

Conversation

AlexeyKuznetsov-DD commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fixed `Error` handling for trace interceptors. #9097

Fixed `Error` handling for trace interceptors. #9097

AlexeyKuznetsov-DD commented Jul 3, 2025 •

edited

Loading

pr-commenter bot commented Jul 3, 2025 •

edited

Loading