Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

amarziali
Copy link
Contributor

What Does This Do

The datadog agent already calculates the stats not only if the span is top level or measured but also if its span kind is among the one eligible.

Those span kinds are returned by the agent through the info endpoint response.
This PR enable including span with eligible kind in the stats computation

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added the type: enhancement Enhancements and improvements label Jul 11, 2025
@amarziali amarziali requested a review from a team as a code owner July 11, 2025 08:59
@amarziali amarziali added the comp: metrics Metrics label Jul 11, 2025
@amarziali amarziali requested review from dougqh and bric3 July 11, 2025 08:59
@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/css-spankind
git_commit_date 1752173281 1752224232
git_commit_sha ad6d6b9 316c552
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~316c552bf7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752226112 1752226112
ci_job_id 1024541493 1024541493
ci_pipeline_id 70276450 70276450
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-h1h76s20 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-h1h76s20 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (996.134 ms) : 0, 996134
Total [baseline] (10.595 s) : 0, 10594892
Agent [candidate] (994.613 ms) : 0, 994613
Total [candidate] (10.552 s) : 0, 10551901
section appsec
Agent [baseline] (1.176 s) : 0, 1175673
Total [baseline] (10.785 s) : 0, 10784918
Agent [candidate] (1.18 s) : 0, 1179794
Total [candidate] (10.827 s) : 0, 10827248
section iast
Agent [baseline] (1.139 s) : 0, 1138686
Total [baseline] (10.968 s) : 0, 10967726
Agent [candidate] (1.135 s) : 0, 1134563
Total [candidate] (10.852 s) : 0, 10852262
section profiling
Agent [baseline] (1.253 s) : 0, 1253285
Total [baseline] (11.122 s) : 0, 11122289
Agent [candidate] (1.247 s) : 0, 1247390
Total [candidate] (11.009 s) : 0, 11009253
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 996.134 ms -
Agent appsec 1.176 s 179.538 ms (18.0%)
Agent iast 1.139 s 142.552 ms (14.3%)
Agent profiling 1.253 s 257.151 ms (25.8%)
Total tracing 10.595 s -
Total appsec 10.785 s 190.026 ms (1.8%)
Total iast 10.968 s 372.834 ms (3.5%)
Total profiling 11.122 s 527.397 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 994.613 ms -
Agent appsec 1.18 s 185.18 ms (18.6%)
Agent iast 1.135 s 139.949 ms (14.1%)
Agent profiling 1.247 s 252.777 ms (25.4%)
Total tracing 10.552 s -
Total appsec 10.827 s 275.347 ms (2.6%)
Total iast 10.852 s 300.362 ms (2.8%)
Total profiling 11.009 s 457.353 ms (4.3%)
gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.886 ms) : 0, 687886
BytebuddyAgent [candidate] (686.327 ms) : 0, 686327
GlobalTracer [baseline] (242.291 ms) : 0, 242291
GlobalTracer [candidate] (242.497 ms) : 0, 242497
AppSec [baseline] (30.308 ms) : 0, 30308
AppSec [candidate] (30.16 ms) : 0, 30160
Debugger [baseline] (6.0 ms) : 0, 6000
Debugger [candidate] (5.958 ms) : 0, 5958
Remote Config [baseline] (680.516 µs) : 0, 681
Remote Config [candidate] (672.775 µs) : 0, 673
Telemetry [baseline] (8.179 ms) : 0, 8179
Telemetry [candidate] (8.21 ms) : 0, 8210
section appsec
BytebuddyAgent [baseline] (710.174 ms) : 0, 710174
BytebuddyAgent [candidate] (713.287 ms) : 0, 713287
GlobalTracer [baseline] (235.491 ms) : 0, 235491
GlobalTracer [candidate] (235.975 ms) : 0, 235975
IAST [baseline] (23.625 ms) : 0, 23625
IAST [candidate] (23.658 ms) : 0, 23658
AppSec [baseline] (171.125 ms) : 0, 171125
AppSec [candidate] (171.545 ms) : 0, 171545
Debugger [baseline] (5.714 ms) : 0, 5714
Debugger [candidate] (5.736 ms) : 0, 5736
Remote Config [baseline] (609.816 µs) : 0, 610
Remote Config [candidate] (602.017 µs) : 0, 602
Telemetry [baseline] (8.01 ms) : 0, 8010
Telemetry [candidate] (8.057 ms) : 0, 8057
section iast
BytebuddyAgent [baseline] (811.747 ms) : 0, 811747
BytebuddyAgent [candidate] (808.993 ms) : 0, 808993
GlobalTracer [baseline] (233.734 ms) : 0, 233734
GlobalTracer [candidate] (232.627 ms) : 0, 232627
IAST [baseline] (27.35 ms) : 0, 27350
IAST [candidate] (29.823 ms) : 0, 29823
AppSec [baseline] (30.532 ms) : 0, 30532
AppSec [candidate] (28.022 ms) : 0, 28022
Debugger [baseline] (5.772 ms) : 0, 5772
Debugger [candidate] (5.728 ms) : 0, 5728
Remote Config [baseline] (578.915 µs) : 0, 579
Remote Config [candidate] (575.995 µs) : 0, 576
Telemetry [baseline] (7.926 ms) : 0, 7926
Telemetry [candidate] (7.953 ms) : 0, 7953
section profiling
BytebuddyAgent [baseline] (682.955 ms) : 0, 682955
BytebuddyAgent [candidate] (679.207 ms) : 0, 679207
GlobalTracer [baseline] (363.613 ms) : 0, 363613
GlobalTracer [candidate] (362.301 ms) : 0, 362301
AppSec [baseline] (33.804 ms) : 0, 33804
AppSec [candidate] (32.382 ms) : 0, 32382
Debugger [baseline] (10.05 ms) : 0, 10050
Debugger [candidate] (11.365 ms) : 0, 11365
Remote Config [baseline] (670.132 µs) : 0, 670
Remote Config [candidate] (673.069 µs) : 0, 673
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.019 ms) : 0, 8019
ProfilingAgent [baseline] (104.396 ms) : 0, 104396
ProfilingAgent [candidate] (104.081 ms) : 0, 104081
Profiling [baseline] (104.42 ms) : 0, 104420
Profiling [candidate] (104.106 ms) : 0, 104106
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (995.455 ms) : 0, 995455
Total [baseline] (8.588 s) : 0, 8587801
Agent [candidate] (1.0 s) : 0, 1000446
Total [candidate] (8.582 s) : 0, 8582446
section iast
Agent [baseline] (1.133 s) : 0, 1133333
Total [baseline] (9.255 s) : 0, 9255437
Agent [candidate] (1.132 s) : 0, 1131705
Total [candidate] (9.268 s) : 0, 9267662
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 995.455 ms -
Agent iast 1.133 s 137.878 ms (13.9%)
Total tracing 8.588 s -
Total iast 9.255 s 667.636 ms (7.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.0 s -
Agent iast 1.132 s 131.259 ms (13.1%)
Total tracing 8.582 s -
Total iast 9.268 s 685.217 ms (8.0%)
gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.978 ms) : 0, 686978
BytebuddyAgent [candidate] (691.738 ms) : 0, 691738
GlobalTracer [baseline] (242.259 ms) : 0, 242259
GlobalTracer [candidate] (242.816 ms) : 0, 242816
AppSec [baseline] (30.403 ms) : 0, 30403
AppSec [candidate] (30.099 ms) : 0, 30099
Debugger [baseline] (6.036 ms) : 0, 6036
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (687.319 µs) : 0, 687
Remote Config [candidate] (675.81 µs) : 0, 676
Telemetry [baseline] (8.218 ms) : 0, 8218
Telemetry [candidate] (8.231 ms) : 0, 8231
section iast
BytebuddyAgent [baseline] (807.405 ms) : 0, 807405
BytebuddyAgent [candidate] (807.069 ms) : 0, 807069
GlobalTracer [baseline] (232.581 ms) : 0, 232581
GlobalTracer [candidate] (232.432 ms) : 0, 232432
IAST [baseline] (25.748 ms) : 0, 25748
IAST [candidate] (29.557 ms) : 0, 29557
AppSec [baseline] (31.758 ms) : 0, 31758
AppSec [candidate] (27.721 ms) : 0, 27721
Debugger [baseline] (6.551 ms) : 0, 6551
Debugger [candidate] (5.718 ms) : 0, 5718
Remote Config [baseline] (565.308 µs) : 0, 565
Remote Config [candidate] (572.702 µs) : 0, 573
Telemetry [baseline] (7.918 ms) : 0, 7918
Telemetry [candidate] (7.913 ms) : 0, 7913
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/css-spankind
git_commit_date 1752173281 1752224232
git_commit_sha ad6d6b9 316c552
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~316c552bf7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1752225787 1752225787
ci_job_id 1024541494 1024541494
ci_pipeline_id 70276450 70276450
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-ixdhir8j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-ixdhir8j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load worse
[+131.149µs; +252.217µs] or [+3.048%; +5.861%]
unstable
[-167.755op/s; +79.067op/s] or [-15.736%; +7.417%]
4.495ms 1021.688op/s 4.303ms 1066.031op/s
scenario:load:petclinic:iast:high_load better
[-2.268ms; -1.456ms] or [-5.095%; -3.270%]
unstable
[-3.117op/s; +12.217op/s] or [-2.967%; +11.627%]
42.651ms 109.625op/s 44.513ms 105.075op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.832 ms) : 37513, 38151
.   : milestone, 37832,
appsec (47.772 ms) : 47344, 48200
.   : milestone, 47772,
code_origins (46.341 ms) : 45951, 46730
.   : milestone, 46341,
iast (44.513 ms) : 44121, 44904
.   : milestone, 44513,
profiling (51.077 ms) : 50603, 51551
.   : milestone, 51077,
tracing (43.946 ms) : 43579, 44313
.   : milestone, 43946,
section candidate
no_agent (36.858 ms) : 36558, 37157
.   : milestone, 36858,
appsec (46.992 ms) : 46573, 47411
.   : milestone, 46992,
code_origins (45.634 ms) : 45233, 46036
.   : milestone, 45634,
iast (42.651 ms) : 42288, 43014
.   : milestone, 42651,
profiling (49.794 ms) : 49315, 50274
.   : milestone, 49794,
tracing (44.357 ms) : 43981, 44734
.   : milestone, 44357,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.832 ms [37.513 ms, 38.151 ms] -
appsec 47.772 ms [47.344 ms, 48.2 ms] 9.939 ms (26.3%)
code_origins 46.341 ms [45.951 ms, 46.73 ms] 8.508 ms (22.5%)
iast 44.513 ms [44.121 ms, 44.904 ms] 6.68 ms (17.7%)
profiling 51.077 ms [50.603 ms, 51.551 ms] 13.245 ms (35.0%)
tracing 43.946 ms [43.579 ms, 44.313 ms] 6.114 ms (16.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.858 ms [36.558 ms, 37.157 ms] -
appsec 46.992 ms [46.573 ms, 47.411 ms] 10.134 ms (27.5%)
code_origins 45.634 ms [45.233 ms, 46.036 ms] 8.777 ms (23.8%)
iast 42.651 ms [42.288 ms, 43.014 ms] 5.793 ms (15.7%)
profiling 49.794 ms [49.315 ms, 50.274 ms] 12.937 ms (35.1%)
tracing 44.357 ms [43.981 ms, 44.734 ms] 7.5 ms (20.3%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.303 ms) : 4255, 4351
.   : milestone, 4303,
iast (9.338 ms) : 9184, 9491
.   : milestone, 9338,
iast_FULL (14.403 ms) : 14117, 14689
.   : milestone, 14403,
iast_GLOBAL (10.161 ms) : 9981, 10341
.   : milestone, 10161,
profiling (8.797 ms) : 8646, 8948
.   : milestone, 8797,
tracing (7.631 ms) : 7516, 7746
.   : milestone, 7631,
section candidate
no_agent (4.495 ms) : 4431, 4558
.   : milestone, 4495,
iast (9.645 ms) : 9488, 9803
.   : milestone, 9645,
iast_FULL (14.025 ms) : 13748, 14302
.   : milestone, 14025,
iast_GLOBAL (10.271 ms) : 10090, 10452
.   : milestone, 10271,
profiling (8.594 ms) : 8455, 8734
.   : milestone, 8594,
tracing (7.416 ms) : 7308, 7523
.   : milestone, 7416,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.303 ms [4.255 ms, 4.351 ms] -
iast 9.338 ms [9.184 ms, 9.491 ms] 5.035 ms (117.0%)
iast_FULL 14.403 ms [14.117 ms, 14.689 ms] 10.1 ms (234.7%)
iast_GLOBAL 10.161 ms [9.981 ms, 10.341 ms] 5.858 ms (136.1%)
profiling 8.797 ms [8.646 ms, 8.948 ms] 4.494 ms (104.4%)
tracing 7.631 ms [7.516 ms, 7.746 ms] 3.328 ms (77.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.495 ms [4.431 ms, 4.558 ms] -
iast 9.645 ms [9.488 ms, 9.803 ms] 5.151 ms (114.6%)
iast_FULL 14.025 ms [13.748 ms, 14.302 ms] 9.53 ms (212.0%)
iast_GLOBAL 10.271 ms [10.09 ms, 10.452 ms] 5.776 ms (128.5%)
profiling 8.594 ms [8.455 ms, 8.734 ms] 4.1 ms (91.2%)
tracing 7.416 ms [7.308 ms, 7.523 ms] 2.921 ms (65.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/css-spankind
git_commit_date 1752173281 1752224232
git_commit_sha ad6d6b9 316c552
release_version 1.52.0-SNAPSHOT~ad6d6b9786 1.52.0-SNAPSHOT~316c552bf7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1752226169 1752226169
ci_job_id 1024541495 1024541495
ci_pipeline_id 70276450 70276450
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-hifsv32z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-hifsv32z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.477 s) : 15477000, 15477000
.   : milestone, 15477000,
appsec (14.671 s) : 14671000, 14671000
.   : milestone, 14671000,
iast (18.537 s) : 18537000, 18537000
.   : milestone, 18537000,
iast_GLOBAL (17.823 s) : 17823000, 17823000
.   : milestone, 17823000,
profiling (15.738 s) : 15738000, 15738000
.   : milestone, 15738000,
tracing (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
section candidate
no_agent (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
appsec (14.727 s) : 14727000, 14727000
.   : milestone, 14727000,
iast (18.392 s) : 18392000, 18392000
.   : milestone, 18392000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
.   : milestone, 17972000,
profiling (15.171 s) : 15171000, 15171000
.   : milestone, 15171000,
tracing (14.739 s) : 14739000, 14739000
.   : milestone, 14739000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.477 s [15.477 s, 15.477 s] -
appsec 14.671 s [14.671 s, 14.671 s] -806.0 ms (-5.2%)
iast 18.537 s [18.537 s, 18.537 s] 3.06 s (19.8%)
iast_GLOBAL 17.823 s [17.823 s, 17.823 s] 2.346 s (15.2%)
profiling 15.738 s [15.738 s, 15.738 s] 261.0 ms (1.7%)
tracing 14.901 s [14.901 s, 14.901 s] -576.0 ms (-3.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.336 s [15.336 s, 15.336 s] -
appsec 14.727 s [14.727 s, 14.727 s] -609.0 ms (-4.0%)
iast 18.392 s [18.392 s, 18.392 s] 3.056 s (19.9%)
iast_GLOBAL 17.972 s [17.972 s, 17.972 s] 2.636 s (17.2%)
profiling 15.171 s [15.171 s, 15.171 s] -165.0 ms (-1.1%)
tracing 14.739 s [14.739 s, 14.739 s] -597.0 ms (-3.9%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.486 ms) : 1474, 1497
.   : milestone, 1486,
appsec (2.423 ms) : 2373, 2473
.   : milestone, 2423,
iast (2.207 ms) : 2144, 2270
.   : milestone, 2207,
iast_GLOBAL (2.247 ms) : 2184, 2310
.   : milestone, 2247,
profiling (2.534 ms) : 2356, 2713
.   : milestone, 2534,
tracing (2.031 ms) : 1982, 2079
.   : milestone, 2031,
section candidate
no_agent (1.483 ms) : 1472, 1495
.   : milestone, 1483,
appsec (2.424 ms) : 2374, 2474
.   : milestone, 2424,
iast (2.213 ms) : 2151, 2276
.   : milestone, 2213,
iast_GLOBAL (2.25 ms) : 2187, 2313
.   : milestone, 2250,
profiling (2.042 ms) : 1992, 2092
.   : milestone, 2042,
tracing (2.03 ms) : 1981, 2080
.   : milestone, 2030,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.486 ms [1.474 ms, 1.497 ms] -
appsec 2.423 ms [2.373 ms, 2.473 ms] 937.096 µs (63.1%)
iast 2.207 ms [2.144 ms, 2.27 ms] 721.83 µs (48.6%)
iast_GLOBAL 2.247 ms [2.184 ms, 2.31 ms] 761.508 µs (51.3%)
profiling 2.534 ms [2.356 ms, 2.713 ms] 1.049 ms (70.6%)
tracing 2.031 ms [1.982 ms, 2.079 ms] 545.226 µs (36.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.472 ms, 1.495 ms] -
appsec 2.424 ms [2.374 ms, 2.474 ms] 940.316 µs (63.4%)
iast 2.213 ms [2.151 ms, 2.276 ms] 730.022 µs (49.2%)
iast_GLOBAL 2.25 ms [2.187 ms, 2.313 ms] 766.128 µs (51.6%)
profiling 2.042 ms [1.992 ms, 2.092 ms] 558.992 µs (37.7%)
tracing 2.03 ms [1.981 ms, 2.08 ms] 547.022 µs (36.9%)

Comment on lines +305 to +307
span_kinds instanceof List
? unmodifiableSet(new HashSet<>((List<String>) span_kinds))
: emptySet();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Indeed that's better to use an instance check if the paylaod ever changes 👍

@amarziali amarziali merged commit 2a4f690 into master Jul 11, 2025
510 checks passed
@amarziali amarziali deleted the andrea.marziali/css-spankind branch July 11, 2025 14:43
@github-actions github-actions bot added this to the 1.52.0 milestone Jul 11, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Aug 5, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| [redis.clients:jedis](https://github.com/redis/jedis) | dependencies |
misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` |
|
[com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.59.2` -> `2.60.0` |
|
[com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.58.2` -> `2.59.0` |
|
[com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.58.2` -> `2.59.0` |
| [com.google.api:gax](https://github.com/googleapis/sdk-platform-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.68.2` -> `2.69.0` |
| [com.squareup.wire](https://github.com/square/wire) | plugin |
misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` |
| [com.squareup.wire:wire-schema](https://github.com/square/wire) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5`
-> `5.3.6` |
| [com.squareup.wire:wire-runtime](https://github.com/square/wire) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5`
-> `5.3.6` |
| [com.squareup.wire:wire-reflector](https://github.com/square/wire) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5`
-> `5.3.6` |
| [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`5.3.5` -> `5.3.6` |
| [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5`
-> `5.3.6` |
| [com.squareup.wire:wire-bom](https://github.com/square/wire) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5`
-> `5.3.6` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.51.2` -> `1.52.0` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.32.14` -> `2.32.15` |

---

### Release Notes

<details>
<summary>redis/jedis (redis.clients:jedis)</summary>

### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0):
6.1.0

### Changes

#### 🚀 New Features

- Add support for SVS-VAMANA vector indexing
([#&#8203;4222](redis/jedis#4222))
- Clarify why new stream entries aren't deleted with XDELEX
([#&#8203;4218](redis/jedis#4218))
- Add support for new stream commands
([#&#8203;4211](redis/jedis#4211))
- Add Support for New BITOP Operations in Redis 8.2
([#&#8203;4188](redis/jedis#4188))
([#&#8203;4190](redis/jedis#4190))
- Add binary stream support for XREAD and XREADGROUP
([#&#8203;3566](redis/jedis#3566))
([#&#8203;4152](redis/jedis#4152))
- Run pipeline in current thread if all the keys on same node
([#&#8203;4149](redis/jedis#4149))

#### 🐛 Bug Fixes

- Restore binary compatibility of SetParams
([#&#8203;4225](redis/jedis#4225))
- Fix memory leak in JedisClusterInfoCache - replica nodes not cleared
([#&#8203;4205](redis/jedis#4205))
- Fix:JedisCluster throws NullPointerException when maxAttempts is set
to 0 ([#&#8203;4186](redis/jedis#4186))

#### 🧰 Maintenance

- DOC-5471 time series doc examples
([#&#8203;4210](redis/jedis#4210))
- Bump jackson.version from 2.19.1 to 2.19.2
([#&#8203;4208](redis/jedis#4208))
- Fix flaky test ClientCommandsTest.killSkipmeYesNo
([#&#8203;4206](redis/jedis#4206))
- Bump org.junit:junit-bom from 5.13.2 to 5.13.3
([#&#8203;4198](redis/jedis#4198))
- Migrate publishing to Maven Central Portal
([#&#8203;4199](redis/jedis#4199))
- Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8
([#&#8203;4197](redis/jedis#4197))
- Bump org.junit:junit-bom from 5.13.1 to 5.13.2
([#&#8203;4192](redis/jedis#4192))
- DOC-5227 added probabilistic data type examples
([#&#8203;4184](redis/jedis#4184))
- Bump jackson.version from 2.19.0 to 2.19.1
([#&#8203;4180](redis/jedis#4180))
- Update test infra to use latest Redis
([#&#8203;4179](redis/jedis#4179))
- Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1
([#&#8203;4174](redis/jedis#4174))
- Bump org.json:json from
[`2025010`](redis/jedis@20250107) to
[`2025051`](redis/jedis@20250517)
([#&#8203;4171](redis/jedis#4171))
- Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4
to 5.5 ([#&#8203;4170](redis/jedis#4170))
- Fix flaky tests in DocumentTest
([#&#8203;3617](redis/jedis#3617))
- Add retryable command execution example
([#&#8203;3780](redis/jedis#3780))
- Bump jackson.version from 2.18.3 to 2.19.0
([#&#8203;4160](redis/jedis#4160))
- Bump com.google.code.gson:gson from 2.12.1 to 2.13.1
([#&#8203;4161](redis/jedis#4161))

#### Contributors

We'd like to thank all the contributors who worked on this release!

[@&#8203;219sansim](https://github.com/219sansim),
[@&#8203;YoHanKi](https://github.com/YoHanKi),
[@&#8203;andy-stark-redis](https://github.com/andy-stark-redis),
[@&#8203;ggivo](https://github.com/ggivo),
[@&#8203;jujn](https://github.com/jujn),
[@&#8203;thachlp](https://github.com/thachlp),
[@&#8203;uglide](https://github.com/uglide) and
[@&#8203;xrayw](https://github.com/xrayw)

</details>

<details>
<summary>googleapis/sdk-platform-java
(com.google.api.grpc:proto-google-common-protos)</summary>

###
[`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23)

##### Features

- handle auto pagination for BigQuery v2
([#&#8203;3829](googleapis/sdk-platform-java#3829))
([025c84c](googleapis/sdk-platform-java@025c84c))

##### Dependencies

- update google auth library dependencies to v1.37.1
([#&#8203;3846](googleapis/sdk-platform-java#3846))
([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5))
- update google http client dependencies to v1.47.1
([#&#8203;3848](googleapis/sdk-platform-java#3848))
([a9a39d7](googleapis/sdk-platform-java@a9a39d7))

</details>

<details>
<summary>square/wire (com.squareup.wire)</summary>

###
[`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536)

[Compare Source](square/wire@5.3.5...5.3.6)

*2025-08-05*

##### CLI

- New CLI option `--ignore_unused_roots_and_prunes`
([#&#8203;3354](square/wire#3354))

##### JVM

- Fix: Handle negative hexadecimal in default values
([#&#8203;3355](square/wire#3355))
- Optimization: Avoid copying of repeated and map types when
mutableTypes are being used
([#&#8203;3352](square/wire#3352) by \[Rahul
Ravikumar]\[tikurahul])

##### Swift

- Fix: Properly disambiguate OneOf enum if it has the same name as
enclosing type
([#&#8203;3350](square/wire#3350) by
\[Dimitris Koutsogiorgas]\[dnkoutso])

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0):
1.52.0

### Components

#### Application Security Management (WAF)

- ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when
AppSec is enabled
([#&#8203;9260](DataDog/dd-trace-java#9260) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- 🐛 Fix NPE in AppSecConfigServiceImpl
([#&#8203;9165](DataDog/dd-trace-java#9165) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))
- 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6
([#&#8203;9160](DataDog/dd-trace-java#9160) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))

#### Build & Tooling

- ✨📖 Automatically register crashtracking via native
extensions
([#&#8203;8851](DataDog/dd-trace-java#8851) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Configuration at Runtime

- ✨ Create activation origin config for telemetry
([#&#8203;9064](DataDog/dd-trace-java#9064) -
[@&#8203;sezen-datadog](https://github.com/sezen-datadog))

#### Continuous Integration Visibility

- ✨ Update GitLab provided tags
([#&#8203;9275](DataDog/dd-trace-java#9275) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🐛 Fix base branch SHA usage in GitHub Actions
([#&#8203;9257](DataDog/dd-trace-java#9257) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add `ci.job.id` tag
([#&#8203;9256](DataDog/dd-trace-java#9256) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add new org to Weaver instrumentation
([#&#8203;9235](DataDog/dd-trace-java#9235) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano) - thanks
for the contribution!)
- ✨ Improve Git commit info building
([#&#8203;9210](DataDog/dd-trace-java#9210) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Update Attempt to Fix to v5
([#&#8203;9145](DataDog/dd-trace-java#9145) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))

#### Crash tracking

- ✨📖 Automatically register crashtracking via native
extensions
([#&#8203;8851](DataDog/dd-trace-java#8851) -
[@&#8203;MattAlp](https://github.com/MattAlp))

#### Data Streams Monitoring

- ✨ Reduce DSM CPU overheard
([#&#8203;9151](DataDog/dd-trace-java#9151) -
[@&#8203;kr-igor](https://github.com/kr-igor))
- ✨⚡ DSM optimizations for high throughput scenarios
([#&#8203;9137](DataDog/dd-trace-java#9137) -
[@&#8203;kr-igor](https://github.com/kr-igor))

#### Database Monitoring

- 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full
propagation mode
([#&#8203;9224](DataDog/dd-trace-java#9224) -
[@&#8203;lu-zhengda](https://github.com/lu-zhengda))

#### Dynamic Instrumentation

- 🐛 Add URI in string primitives
([#&#8203;9285](DataDog/dd-trace-java#9285) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Increase SourceFile tracking max queue size
([#&#8203;9271](DataDog/dd-trace-java#9271) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add capping on SourceFile tracking queue
([#&#8203;9245](DataDog/dd-trace-java#9245) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- ✨ Add third-party filtering in SourceFile tracking
([#&#8203;9205](DataDog/dd-trace-java#9205) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### ML Observability (LLMObs)

- ✨ Add methods to capture embedding and retrieval spans
([#&#8203;9297](DataDog/dd-trace-java#9297) -
[@&#8203;nayeem-kamal](https://github.com/nayeem-kamal))

#### Metrics

- ✨ Change primary client stats configuration key
([#&#8203;9196](DataDog/dd-trace-java#9196) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Calculate client stats also if the span kind is eligible
([#&#8203;9157](DataDog/dd-trace-java#9157) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Backpropagate peer tags
([#&#8203;9144](DataDog/dd-trace-java#9144) -
[@&#8203;bric3](https://github.com/bric3))
- 🐛 Make client stats reliable in case of downgrade
([#&#8203;9136](DataDog/dd-trace-java#9136) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Platform components

- 🐛 Fix VM options parsing from /proc/fs
([#&#8203;9255](DataDog/dd-trace-java#9255) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Profiling

- ✨ Switch profile compression to zstd default
([#&#8203;9293](DataDog/dd-trace-java#9293) -
[@&#8203;jbachorik](https://github.com/jbachorik))

- ✨ Bump ddprof to 1.29.0
([#&#8203;9262](DataDog/dd-trace-java#9262) -
[@&#8203;zhengyu123](https://github.com/zhengyu123))
- Potential memory leak and race with the JVMTI wallclock sampler by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#234
- Downport async-profiler no-allocation changes by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#245
- Adopt openjdk safefetch by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#246
- Safe fetch 64-bit value and pointer by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#247
- Rebase on Async-Profiler 4.1 by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#252
- Patch upstream stackWalker.cpp not to fail on unaligned access by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#218
- Remap thread id to avoid bitmap contention by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#229
- Improve performance using Unsafe to activate/deactivate thread filter
by [@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#230
- Unify context propagation by
[@&#8203;zhengyu123](https://github.com/zhengyu123) in
DataDog/java-profiler#231

- 🐛 Fix the profiler stackdepth setting propagation in recent (22+)
Java versions
([#&#8203;9130](DataDog/dd-trace-java#9130) -
[@&#8203;jbachorik](https://github.com/jbachorik))

#### Realtime User Monitoring

- ✨ Wrap servlet original PrintWriter on rum injector
([#&#8203;9146](DataDog/dd-trace-java#9146) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Telemetry

- ✨ Create activation origin config for telemetry
([#&#8203;9064](DataDog/dd-trace-java#9064) -
[@&#8203;sezen-datadog](https://github.com/sezen-datadog))

#### Tracer core

- ✨⚡ Reduce span construction overhead by switching to
optimized TagMap
([#&#8203;8589](DataDog/dd-trace-java#8589) -
[@&#8203;dougqh](https://github.com/dougqh))
- 🐛 Match Hands Off Config selectors on process\_arguments value
([#&#8203;9201](DataDog/dd-trace-java#9201) -
[@&#8203;paullegranddc](https://github.com/paullegranddc))
- ✨ Move JSON generation to sender thread to improve startup
time.
([#&#8203;9197](DataDog/dd-trace-java#9197) -
[@&#8203;AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD))
- ✨ Improve agent to avoid loading global config on main thread
([#&#8203;9190](DataDog/dd-trace-java#9190) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨ add injection metadata fields to telemetry forwarder
([#&#8203;9185](DataDog/dd-trace-java#9185) -
[@&#8203;sydney-tung](https://github.com/sydney-tung))
- 🐛 Avoid race conditions on feature discovery during Writer
creation
([#&#8203;9173](DataDog/dd-trace-java#9173) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Surface potential root cause when agent initialization
errors
([#&#8203;9170](DataDog/dd-trace-java#9170) -
[@&#8203;AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD))
- 💡 Support adding W3C baggage as span tags
([#&#8203;9169](DataDog/dd-trace-java#9169) -
[@&#8203;rachelyangdog](https://github.com/rachelyangdog))
- ✨⚡ Align our default classloader excludes with OTel
([#&#8203;9161](DataDog/dd-trace-java#9161) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Backpropagate container tags hash coming from the info
endpoint
([#&#8203;9156](DataDog/dd-trace-java#9156) -
[@&#8203;amarziali](https://github.com/amarziali))
- 🐛 Avoid race conditions and multiple agent discovery feature
states
([#&#8203;9135](DataDog/dd-trace-java#9135) -
[@&#8203;amarziali](https://github.com/amarziali))

### Instrumentations

#### AWS SDK instrumentation

- ✨ Enhance Service Representation for Serverless
([#&#8203;9203](DataDog/dd-trace-java#9203) -
[@&#8203;zarirhamza](https://github.com/zarirhamza))

#### gRPC instrumentation

- 🐛 Add check to prevent injection of repeated GRPC headers
([#&#8203;9246](DataDog/dd-trace-java#9246) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### JDBC instrumentation

- 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full
propagation mode
([#&#8203;9224](DataDog/dd-trace-java#9224) -
[@&#8203;lu-zhengda](https://github.com/lu-zhengda))

#### Play Framework instrumentation

- 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6
([#&#8203;9160](DataDog/dd-trace-java#9160) -
[@&#8203;manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: metrics Metrics type: enhancement Enhancements and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants