-
Notifications
You must be signed in to change notification settings - Fork 312
🍒 9201 - Match Hands Off Config selectors on process_arguments value #9238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* feat: match stable config java properties on other operator than 'contains' * fix: lowercase match value * fix: extra parameter * fix: remove duplicate values * fix: lint * fi: wrong variable * fix lint * fix: tests * fix: null matches with exist should work * feat: add tests for equal operator on arguments * fix: use equal method instead of operator * Update internal-api/src/main/java/datadog/trace/bootstrap/config/provider/StableConfigParser.java Co-authored-by: Bruce Bujon <[email protected]> * apply PR suggestions * fix typo * Add missing locale * add matches == null check back in to avoid NPE --------- Co-authored-by: Mikayla Toffler <[email protected]> Co-authored-by: Bruce Bujon <[email protected]> Co-authored-by: Mikayla Toffler <[email protected]>
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 9 performance improvements and 4 performance regressions! Performance is the same for 26 metrics, 14 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043528
Total [baseline] (10.701 s) : 0, 10701476
Agent [candidate] (1.028 s) : 0, 1027585
Total [candidate] (10.614 s) : 0, 10613711
section appsec
Agent [baseline] (1.226 s) : 0, 1225756
Total [baseline] (10.726 s) : 0, 10726142
Agent [candidate] (1.173 s) : 0, 1173322
Total [candidate] (10.686 s) : 0, 10686299
section iast
Agent [baseline] (1.176 s) : 0, 1175682
Total [baseline] (10.967 s) : 0, 10967218
Agent [candidate] (1.152 s) : 0, 1151968
Total [candidate] (10.895 s) : 0, 10894922
section profiling
Agent [baseline] (1.189 s) : 0, 1189044
Total [baseline] (10.79 s) : 0, 10790035
Agent [candidate] (1.269 s) : 0, 1268668
Total [candidate] (10.96 s) : 0, 10960283
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (728.846 ms) : 0, 728846
BytebuddyAgent [candidate] (686.993 ms) : 0, 686993
GlobalTracer [baseline] (241.313 ms) : 0, 241313
GlobalTracer [candidate] (242.603 ms) : 0, 242603
AppSec [baseline] (30.24 ms) : 0, 30240
AppSec [candidate] (58.994 ms) : 0, 58994
Debugger [baseline] (5.973 ms) : 0, 5973
Debugger [candidate] (6.237 ms) : 0, 6237
Remote Config [baseline] (645.238 µs) : 0, 645
Remote Config [candidate] (653.898 µs) : 0, 654
Telemetry [baseline] (14.13 ms) : 0, 14130
Telemetry [candidate] (11.124 ms) : 0, 11124
crashtracking [baseline] (1.431 ms) : 0, 1431
section appsec
BytebuddyAgent [baseline] (757.5 ms) : 0, 757500
BytebuddyAgent [candidate] (707.333 ms) : 0, 707333
GlobalTracer [baseline] (235.858 ms) : 0, 235858
GlobalTracer [candidate] (234.865 ms) : 0, 234865
AppSec [baseline] (169.182 ms) : 0, 169182
AppSec [candidate] (174.888 ms) : 0, 174888
Debugger [baseline] (7.96 ms) : 0, 7960
Debugger [candidate] (5.893 ms) : 0, 5893
Remote Config [baseline] (623.966 µs) : 0, 624
Remote Config [candidate] (610.509 µs) : 0, 611
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (7.195 ms) : 0, 7195
crashtracking [baseline] (1.435 ms) : 0, 1435
IAST [baseline] (23.62 ms) : 0, 23620
IAST [candidate] (21.846 ms) : 0, 21846
section iast
BytebuddyAgent [baseline] (848.914 ms) : 0, 848914
BytebuddyAgent [candidate] (806.249 ms) : 0, 806249
GlobalTracer [baseline] (231.579 ms) : 0, 231579
GlobalTracer [candidate] (231.661 ms) : 0, 231661
AppSec [baseline] (29.074 ms) : 0, 29074
AppSec [candidate] (53.588 ms) : 0, 53588
Debugger [baseline] (5.744 ms) : 0, 5744
Debugger [candidate] (5.918 ms) : 0, 5918
Remote Config [baseline] (585.599 µs) : 0, 586
Remote Config [candidate] (613.704 µs) : 0, 614
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (7.971 ms) : 0, 7971
crashtracking [baseline] (1.423 ms) : 0, 1423
IAST [baseline] (29.16 ms) : 0, 29160
IAST [candidate] (25.12 ms) : 0, 25120
section profiling
BytebuddyAgent [baseline] (758.158 ms) : 0, 758158
BytebuddyAgent [candidate] (677.259 ms) : 0, 677259
GlobalTracer [baseline] (220.455 ms) : 0, 220455
GlobalTracer [candidate] (360.445 ms) : 0, 360445
AppSec [baseline] (30.104 ms) : 0, 30104
AppSec [candidate] (61.65 ms) : 0, 61650
Debugger [baseline] (6.195 ms) : 0, 6195
Debugger [candidate] (6.087 ms) : 0, 6087
Remote Config [baseline] (717.145 µs) : 0, 717
Remote Config [candidate] (694.493 µs) : 0, 694
Telemetry [baseline] (15.08 ms) : 0, 15080
Telemetry [candidate] (8.099 ms) : 0, 8099
crashtracking [baseline] (1.396 ms) : 0, 1396
ProfilingAgent [baseline] (108.537 ms) : 0, 108537
ProfilingAgent [candidate] (105.848 ms) : 0, 105848
Profiling [baseline] (108.561 ms) : 0, 108561
Profiling [candidate] (105.875 ms) : 0, 105875
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047463
Total [baseline] (8.612 s) : 0, 8611656
Agent [candidate] (1.025 s) : 0, 1024882
Total [candidate] (8.557 s) : 0, 8557191
section iast
Agent [baseline] (1.177 s) : 0, 1177229
Total [baseline] (9.304 s) : 0, 9304408
Agent [candidate] (1.154 s) : 0, 1154135
Total [candidate] (9.205 s) : 0, 9205102
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (731.993 ms) : 0, 731993
BytebuddyAgent [candidate] (686.087 ms) : 0, 686087
GlobalTracer [baseline] (243.033 ms) : 0, 243033
GlobalTracer [candidate] (242.263 ms) : 0, 242263
AppSec [baseline] (30.692 ms) : 0, 30692
AppSec [candidate] (56.723 ms) : 0, 56723
Debugger [baseline] (6.037 ms) : 0, 6037
Debugger [candidate] (7.892 ms) : 0, 7892
Remote Config [baseline] (655.536 µs) : 0, 656
Remote Config [candidate] (684.691 µs) : 0, 685
Telemetry [baseline] (12.64 ms) : 0, 12640
Telemetry [candidate] (10.382 ms) : 0, 10382
crashtracking [baseline] (1.428 ms) : 0, 1428
section iast
BytebuddyAgent [baseline] (849.101 ms) : 0, 849101
BytebuddyAgent [candidate] (807.803 ms) : 0, 807803
GlobalTracer [baseline] (232.936 ms) : 0, 232936
GlobalTracer [candidate] (232.147 ms) : 0, 232147
AppSec [baseline] (30.642 ms) : 0, 30642
AppSec [candidate] (51.298 ms) : 0, 51298
Debugger [baseline] (6.633 ms) : 0, 6633
Debugger [candidate] (5.883 ms) : 0, 5883
Remote Config [baseline] (592.959 µs) : 0, 593
Remote Config [candidate] (601.677 µs) : 0, 602
Telemetry [baseline] (8.156 ms) : 0, 8156
Telemetry [candidate] (7.994 ms) : 0, 7994
crashtracking [baseline] (1.426 ms) : 0, 1426
IAST [baseline] (26.705 ms) : 0, 26705
IAST [candidate] (27.585 ms) : 0, 27585
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section baseline
no_agent (38.342 ms) : 38037, 38646
. : milestone, 38342,
appsec (47.701 ms) : 47277, 48125
. : milestone, 47701,
code_origins (45.314 ms) : 44937, 45692
. : milestone, 45314,
iast (43.149 ms) : 42779, 43518
. : milestone, 43149,
profiling (47.349 ms) : 46928, 47771
. : milestone, 47349,
tracing (46.316 ms) : 45935, 46698
. : milestone, 46316,
section candidate
no_agent (36.815 ms) : 36513, 37117
. : milestone, 36815,
appsec (47.53 ms) : 47096, 47965
. : milestone, 47530,
code_origins (44.122 ms) : 43743, 44502
. : milestone, 44122,
iast (46.098 ms) : 45696, 46499
. : milestone, 46098,
profiling (49.54 ms) : 49100, 49980
. : milestone, 49540,
tracing (45.506 ms) : 45109, 45903
. : milestone, 45506,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section baseline
no_agent (4.377 ms) : 4327, 4426
. : milestone, 4377,
iast (9.179 ms) : 9030, 9328
. : milestone, 9179,
iast_FULL (13.837 ms) : 13561, 14112
. : milestone, 13837,
iast_GLOBAL (10.352 ms) : 10170, 10534
. : milestone, 10352,
profiling (9.463 ms) : 9310, 9615
. : milestone, 9463,
tracing (7.828 ms) : 7717, 7940
. : milestone, 7828,
section candidate
no_agent (4.338 ms) : 4288, 4388
. : milestone, 4338,
iast (9.798 ms) : 9634, 9961
. : milestone, 9798,
iast_FULL (14.335 ms) : 14051, 14620
. : milestone, 14335,
iast_GLOBAL (9.962 ms) : 9791, 10132
. : milestone, 9962,
profiling (8.872 ms) : 8729, 9014
. : milestone, 8872,
tracing (7.753 ms) : 7639, 7868
. : milestone, 7753,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.615 ms) : 3402, 3827
. : milestone, 3615,
iast (2.214 ms) : 2151, 2277
. : milestone, 2214,
iast_GLOBAL (2.252 ms) : 2188, 2315
. : milestone, 2252,
profiling (2.073 ms) : 2021, 2125
. : milestone, 2073,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
section candidate
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (2.416 ms) : 2367, 2465
. : milestone, 2416,
iast (2.209 ms) : 2146, 2271
. : milestone, 2209,
iast_GLOBAL (2.246 ms) : 2184, 2309
. : milestone, 2246,
profiling (2.054 ms) : 2003, 2105
. : milestone, 2054,
tracing (2.028 ms) : 1980, 2076
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~a5169598dc, baseline=1.51.1-SNAPSHOT~4fde84fc67
dateFormat X
axisFormat %s
section baseline
no_agent (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
appsec (14.691 s) : 14691000, 14691000
. : milestone, 14691000,
iast (19.022 s) : 19022000, 19022000
. : milestone, 19022000,
iast_GLOBAL (17.887 s) : 17887000, 17887000
. : milestone, 17887000,
profiling (15.333 s) : 15333000, 15333000
. : milestone, 15333000,
tracing (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
section candidate
no_agent (15.464 s) : 15464000, 15464000
. : milestone, 15464000,
appsec (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
iast (18.899 s) : 18899000, 18899000
. : milestone, 18899000,
iast_GLOBAL (17.84 s) : 17840000, 17840000
. : milestone, 17840000,
profiling (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
tracing (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
|
We no longer need to proceed with the 1.50.2 release. |
Backport #9201 to release/v1.50.x