Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Stable Config improvements #9259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Aug 15, 2025
Merged

Stable Config improvements #9259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
370e894
Refactor matchOperator to use method reference comparator for efficiency
mtoffl01 Jul 28, 2025
df4da2f
Implement better exception handling and debug logging for StableConfi…
mtoffl01 Jul 28, 2025
7049d36
Add a debug log about no rules getting applied
mtoffl01 Jul 28, 2025
e730cbe
Improve test file logic and cleanup in StableConfigSourceTest class
mtoffl01 Jul 29, 2025
5b639aa
Github suggestions: Use static factory methods as constructors for R…
mtoffl01 Jul 31, 2025
85d11cf
Improve exception message: include value of object that caused the fa…
mtoffl01 Aug 1, 2025
6ab4b6c
Add more test cases to StableConfigSourceTest to improve codecov
mtoffl01 Aug 1, 2025
007f58a
Add test coverage for StableConfigMappingException
mtoffl01 Aug 1, 2025
ac69f2d
Merge branch 'master' into mtoff/scfg-improvements
mtoffl01 Aug 4, 2025
473c59b
Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
mtoffl01 Aug 8, 2025
feb1ba0
Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
mtoffl01 Aug 8, 2025
f93546a
Use safeToString when printing stableconfig map
mtoffl01 Aug 8, 2025
780aee3
rearrange logic in selectors creation for better readability
mtoffl01 Aug 8, 2025
ac5e05a
delete superfluous else
mtoffl01 Aug 8, 2025
bcebbcb
Use constant to represent max length in safeToString
mtoffl01 Aug 8, 2025
0baccfd
use throwStableConfigMappingException helper function
mtoffl01 Aug 11, 2025
957d9c9
refactor exception catching in StableConfigSource
mtoffl01 Aug 11, 2025
b9870bd
restore semicolon in calls to throwStableConfigMappingException
mtoffl01 Aug 11, 2025
5019584
Use static import for throwStableConfigMappingException
mtoffl01 Aug 11, 2025
e8d6e8f
test other kinds of exceptions in StableConfigSource
mtoffl01 Aug 11, 2025
1fefb17
remove duplicate cfg assignments
mtoffl01 Aug 11, 2025
058cbda
fix missing operator test case
mtoffl01 Aug 12, 2025
5460c8a
Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
mtoffl01 Aug 12, 2025
37da711
Improve readability of StableConfigMappingException and its function …
mtoffl01 Aug 12, 2025
5dac7f8
modify safeToString logic to print first 50 and last 50 chars
mtoffl01 Aug 12, 2025
5104ac5
Merge branch 'mtoff/scfg-improvements' of github.com:DataDog/dd-trace…
mtoffl01 Aug 12, 2025
13bef8d
remove extra placeholder in string message when printing exception
mtoffl01 Aug 12, 2025
2706bca
Update internal-api/src/main/java/datadog/trace/bootstrap/config/prov…
mtoffl01 Aug 12, 2025
4dde216
refactor Rules.from to perform type assertions before heavyweight lis…
mtoffl01 Aug 14, 2025
bfd5d7b
Merge branch 'mtoff/scfg-improvements' of github.com:DataDog/dd-trace…
mtoffl01 Aug 14, 2025
16d5f36
run spotless
mtoffl01 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore semicolon in calls to throwStableConfigMappingException
  • Loading branch information
@mtoffl01
mtoffl01 committed Aug 11, 2025
commit b9870bd0c5d1cf98ec5f38fcf0c0fca15b0c34a2
2 changes: 1 addition & 1 deletion internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public static Rule from(Map<?, ?> map) {
Object configObj = map.get("configuration");
if (configObj == null) {
StableConfigMappingException.throwStableConfigMappingException(
"Missing 'configuration' in rule", map);
"Missing 'configuration' in rule:", map);
}
if (!(configObj instanceof Map)) {
StableConfigMappingException.throwStableConfigMappingException(
Expand Down
4 changes: 2 additions & 2 deletions ...rnal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public static Selector from(Map<?, ?> map) {
Object originObj = map.get("origin");
if (originObj == null) {
StableConfigMappingException.throwStableConfigMappingException(
"Missing 'origin' in selector", map);
"Missing 'origin' in selector:", map);
}
if (!(originObj instanceof String)) {
StableConfigMappingException.throwStableConfigMappingException(
Expand All @@ -45,7 +45,7 @@ public static Selector from(Map<?, ?> map) {
Object operatorObj = map.get("operator");
if (operatorObj == null) {
StableConfigMappingException.throwStableConfigMappingException(
"Missing 'operator' in selector", map);
"Missing 'operator' in selector:", map);
}
if (!(operatorObj instanceof String)) {
StableConfigMappingException.throwStableConfigMappingException(
Expand Down