-
Notifications
You must be signed in to change notification settings - Fork 312
π 9353 - Avoid NPE on featureDiscovery creation #9354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backportig Stuart's review
Code coverage: total 58.81%, base diff 1.69%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.π Commit SHA: da823f8 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044427
Total [baseline] (8.587 s) : 0, 8587318
Agent [candidate] (1.052 s) : 0, 1052337
Total [candidate] (8.595 s) : 0, 8594763
section iast
Agent [baseline] (1.176 s) : 0, 1176066
Total [baseline] (9.304 s) : 0, 9304182
Agent [candidate] (1.181 s) : 0, 1180509
Total [candidate] (9.332 s) : 0, 9332208
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (729.916 ms) : 0, 729916
BytebuddyAgent [candidate] (737.336 ms) : 0, 737336
GlobalTracer [baseline] (241.345 ms) : 0, 241345
GlobalTracer [candidate] (243.395 ms) : 0, 243395
AppSec [baseline] (29.989 ms) : 0, 29989
AppSec [candidate] (30.439 ms) : 0, 30439
Debugger [baseline] (6.023 ms) : 0, 6023
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (647.934 Β΅s) : 0, 648
Remote Config [candidate] (652.493 Β΅s) : 0, 652
Telemetry [baseline] (14.2 ms) : 0, 14200
Telemetry [candidate] (11.881 ms) : 0, 11881
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (848.966 ms) : 0, 848966
BytebuddyAgent [candidate] (853.85 ms) : 0, 853850
GlobalTracer [baseline] (232.395 ms) : 0, 232395
GlobalTracer [candidate] (233.216 ms) : 0, 233216
AppSec [baseline] (25.096 ms) : 0, 25096
AppSec [candidate] (27.724 ms) : 0, 27724
Debugger [baseline] (7.511 ms) : 0, 7511
Debugger [candidate] (5.854 ms) : 0, 5854
Remote Config [baseline] (597.574 Β΅s) : 0, 598
Remote Config [candidate] (590.859 Β΅s) : 0, 591
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.099 ms) : 0, 8099
IAST [baseline] (30.92 ms) : 0, 30920
IAST [candidate] (28.794 ms) : 0, 28794
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045457
Total [baseline] (10.772 s) : 0, 10771782
Agent [candidate] (1.042 s) : 0, 1042095
Total [candidate] (10.732 s) : 0, 10731673
section appsec
Agent [baseline] (1.224 s) : 0, 1224111
Total [baseline] (10.817 s) : 0, 10816628
Agent [candidate] (1.224 s) : 0, 1223737
Total [candidate] (10.78 s) : 0, 10779565
section iast
Agent [baseline] (1.185 s) : 0, 1184771
Total [baseline] (10.905 s) : 0, 10904753
Agent [candidate] (1.183 s) : 0, 1183200
Total [candidate] (10.926 s) : 0, 10925767
section profiling
Agent [baseline] (1.198 s) : 0, 1197791
Total [baseline] (10.934 s) : 0, 10934035
Agent [candidate] (1.199 s) : 0, 1199407
Total [candidate] (10.907 s) : 0, 10907001
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (731.682 ms) : 0, 731682
BytebuddyAgent [candidate] (729.926 ms) : 0, 729926
GlobalTracer [baseline] (241.849 ms) : 0, 241849
GlobalTracer [candidate] (241.167 ms) : 0, 241167
AppSec [baseline] (30.082 ms) : 0, 30082
AppSec [candidate] (30.042 ms) : 0, 30042
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (646.118 Β΅s) : 0, 646
Remote Config [candidate] (643.78 Β΅s) : 0, 644
Telemetry [baseline] (12.733 ms) : 0, 12733
Telemetry [candidate] (11.912 ms) : 0, 11912
section appsec
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (757.537 ms) : 0, 757537
BytebuddyAgent [candidate] (756.337 ms) : 0, 756337
GlobalTracer [baseline] (234.573 ms) : 0, 234573
GlobalTracer [candidate] (235.166 ms) : 0, 235166
IAST [baseline] (23.443 ms) : 0, 23443
IAST [candidate] (23.482 ms) : 0, 23482
AppSec [baseline] (169.773 ms) : 0, 169773
AppSec [candidate] (167.816 ms) : 0, 167816
Debugger [baseline] (5.781 ms) : 0, 5781
Debugger [candidate] (9.495 ms) : 0, 9495
Remote Config [baseline] (614.849 Β΅s) : 0, 615
Remote Config [candidate] (619.592 Β΅s) : 0, 620
Telemetry [baseline] (9.823 ms) : 0, 9823
Telemetry [candidate] (8.236 ms) : 0, 8236
section iast
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (855.621 ms) : 0, 855621
BytebuddyAgent [candidate] (855.172 ms) : 0, 855172
GlobalTracer [baseline] (233.805 ms) : 0, 233805
GlobalTracer [candidate] (232.938 ms) : 0, 232938
IAST [baseline] (27.082 ms) : 0, 27082
IAST [candidate] (29.115 ms) : 0, 29115
AppSec [baseline] (28.321 ms) : 0, 28321
AppSec [candidate] (28.808 ms) : 0, 28808
Debugger [baseline] (8.282 ms) : 0, 8282
Debugger [candidate] (5.801 ms) : 0, 5801
Remote Config [baseline] (583.969 Β΅s) : 0, 584
Remote Config [candidate] (611.575 Β΅s) : 0, 612
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (8.263 ms) : 0, 8263
section profiling
crashtracking [baseline] (1.408 ms) : 0, 1408
crashtracking [candidate] (1.41 ms) : 0, 1410
BytebuddyAgent [baseline] (761.706 ms) : 0, 761706
BytebuddyAgent [candidate] (764.36 ms) : 0, 764360
GlobalTracer [baseline] (222.97 ms) : 0, 222970
GlobalTracer [candidate] (222.168 ms) : 0, 222168
AppSec [baseline] (30.251 ms) : 0, 30251
AppSec [candidate] (30.258 ms) : 0, 30258
Debugger [baseline] (6.349 ms) : 0, 6349
Debugger [candidate] (6.308 ms) : 0, 6308
Remote Config [baseline] (684.811 Β΅s) : 0, 685
Remote Config [candidate] (675.845 Β΅s) : 0, 676
Telemetry [baseline] (15.487 ms) : 0, 15487
Telemetry [candidate] (16.044 ms) : 0, 16044
ProfilingAgent [baseline] (109.296 ms) : 0, 109296
ProfilingAgent [candidate] (108.4 ms) : 0, 108400
Profiling [baseline] (109.931 ms) : 0, 109931
Profiling [candidate] (109.038 ms) : 0, 109038
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section baseline
no_agent (4.364 ms) : 4314, 4414
. : milestone, 4364,
iast (9.696 ms) : 9535, 9856
. : milestone, 9696,
iast_FULL (14.007 ms) : 13721, 14293
. : milestone, 14007,
iast_GLOBAL (10.444 ms) : 10257, 10631
. : milestone, 10444,
profiling (8.733 ms) : 8584, 8882
. : milestone, 8733,
tracing (7.444 ms) : 7339, 7548
. : milestone, 7444,
section candidate
no_agent (4.301 ms) : 4253, 4350
. : milestone, 4301,
iast (9.562 ms) : 9405, 9719
. : milestone, 9562,
iast_FULL (13.938 ms) : 13662, 14213
. : milestone, 13938,
iast_GLOBAL (10.322 ms) : 10139, 10505
. : milestone, 10322,
profiling (8.709 ms) : 8557, 8861
. : milestone, 8709,
tracing (7.615 ms) : 7499, 7731
. : milestone, 7615,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section baseline
no_agent (36.857 ms) : 36561, 37153
. : milestone, 36857,
appsec (45.632 ms) : 45228, 46035
. : milestone, 45632,
code_origins (44.689 ms) : 44303, 45074
. : milestone, 44689,
iast (43.786 ms) : 43410, 44163
. : milestone, 43786,
profiling (48.527 ms) : 48088, 48966
. : milestone, 48527,
tracing (43.783 ms) : 43409, 44158
. : milestone, 43783,
section candidate
no_agent (35.551 ms) : 35262, 35840
. : milestone, 35551,
appsec (47.438 ms) : 47026, 47850
. : milestone, 47438,
code_origins (46.642 ms) : 46252, 47032
. : milestone, 46642,
iast (44.501 ms) : 44111, 44890
. : milestone, 44501,
profiling (47.718 ms) : 47292, 48144
. : milestone, 47718,
tracing (45.479 ms) : 45105, 45854
. : milestone, 45479,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section baseline
no_agent (15.517 s) : 15517000, 15517000
. : milestone, 15517000,
appsec (14.532 s) : 14532000, 14532000
. : milestone, 14532000,
iast (18.384 s) : 18384000, 18384000
. : milestone, 18384000,
iast_GLOBAL (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
profiling (15.31 s) : 15310000, 15310000
. : milestone, 15310000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
section candidate
no_agent (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
appsec (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
iast (18.641 s) : 18641000, 18641000
. : milestone, 18641000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.178 s) : 15178000, 15178000
. : milestone, 15178000,
tracing (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~da823f86dd, baseline=1.53.0-SNAPSHOT~8d4316af7d
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.632 ms) : 3417, 3847
. : milestone, 3632,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.486 ms) : 2317, 2655
. : milestone, 2486,
tracing (2.022 ms) : 1973, 2070
. : milestone, 2022,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.572 ms) : 3362, 3782
. : milestone, 3572,
iast (2.195 ms) : 2133, 2258
. : milestone, 2195,
iast_GLOBAL (2.238 ms) : 2175, 2301
. : milestone, 2238,
profiling (2.033 ms) : 1983, 2083
. : milestone, 2033,
tracing (2.022 ms) : 1974, 2071
. : milestone, 2022,
|
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.mockito:mockito-core](https://github.com/mockito/mockito) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.18.0` -> `5.19.0` | | [com.google.api-client:google-api-client](https://github.com/googleapis/google-api-java-client) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.8.0` -> `2.8.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.52.0` -> `1.52.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.22` -> `2.32.23` | --- ### Release Notes <details> <summary>mockito/mockito (org.mockito:mockito-core)</summary> ### [`v5.19.0`](https://github.com/mockito/mockito/releases/tag/v5.19.0) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.19.0 - 2025-08-15 - [37 commit(s)](mockito/mockito@v5.18.0...v5.19.0) by Adrian-Kim, Tim van der Lippe, Tran Ngoc Nhan, dependabot\[bot], juyeop - feat: Add support for JDK21 Sequenced Collections. [(#​3708)](mockito/mockito#3708) - Bump actions/checkout from 4 to 5 [(#​3707)](mockito/mockito#3707) - build: Allow overriding 'Created-By' for reproducible builds [(#​3704)](mockito/mockito#3704) - Bump org.assertj:assertj-core from 3.27.3 to 3.27.4 [(#​3703)](mockito/mockito#3703) - Bump androidx.test:runner from 1.6.2 to 1.7.0 [(#​3697)](mockito/mockito#3697) - Bump org.junit.platform:junit-platform-launcher from 1.13.3 to 1.13.4 [(#​3694)](mockito/mockito#3694) - Bump com.diffplug.spotless:spotless-plugin-gradle from 7.1.0 to 7.2.1 [(#​3693)](mockito/mockito#3693) - Bump junit-jupiter from 5.13.3 to 5.13.4 [(#​3691)](mockito/mockito#3691) - Bump com.gradle.develocity from 4.0.2 to 4.1 [(#​3689)](mockito/mockito#3689) - Bump com.google.googlejavaformat:google-java-format from 1.27.0 to 1.28.0 [(#​3688)](mockito/mockito#3688) - Bump com.google.googlejavaformat:google-java-format from 1.25.2 to 1.27.0 [(#​3686)](mockito/mockito#3686) - Bump com.diffplug.spotless:spotless-plugin-gradle from 7.0.4 to 7.1.0 [(#​3685)](mockito/mockito#3685) - Bump junit-jupiter from 5.13.2 to 5.13.3 [(#​3684)](mockito/mockito#3684) - Bump org.shipkit:shipkit-auto-version from 2.1.0 to 2.1.2 [(#​3683)](mockito/mockito#3683) - Bump com.diffplug.spotless:spotless-plugin-gradle from 7.0.2 to 7.0.4 [(#​3682)](mockito/mockito#3682) - Only run release after both Java and Android tests have finished [(#​3681)](mockito/mockito#3681) - Bump org.junit.platform:junit-platform-launcher from 1.12.2 to 1.13.3 [(#​3680)](mockito/mockito#3680) - Bump org.codehaus.groovy:groovy from 3.0.24 to 3.0.25 [(#​3679)](mockito/mockito#3679) - Bump org.eclipse.platform:org.eclipse.osgi from 3.23.0 to 3.23.100 [(#​3678)](mockito/mockito#3678) - Can no longer publish snapshot releases [(#​3677)](mockito/mockito#3677) - Update Gradle to 8.14.2 [(#​3676)](mockito/mockito#3676) - Bump errorprone from 2.23.0 to 2.39.0 [(#​3674)](mockito/mockito#3674) - Correct Junit docs link [(#​3672)](mockito/mockito#3672) - Bump net.ltgt.gradle:gradle-errorprone-plugin from 4.1.0 to 4.3.0 [(#​3670)](mockito/mockito#3670) - Bump junit-jupiter from 5.13.1 to 5.13.2 [(#​3669)](mockito/mockito#3669) - Bump bytebuddy from 1.17.5 to 1.17.6 [(#​3668)](mockito/mockito#3668) - Bump junit-jupiter from 5.12.2 to 5.13.1 [(#​3666)](mockito/mockito#3666) - Bump org.jetbrains.kotlin:kotlin-stdlib from 2.0.21 to 2.2.0 [(#​3665)](mockito/mockito#3665) - Bump org.gradle.toolchains.foojay-resolver-convention from 0.9.0 to 1.0.0 [(#​3661)](mockito/mockito#3661) - Bump org.junit.platform:junit-platform-launcher from 1.11.4 to 1.12.2 [(#​3660)](mockito/mockito#3660) - Add JDK21 sequenced collections for ReturnsEmptyValues [(#​3659)](mockito/mockito#3659) - Bump com.gradle.develocity from 3.19.1 to 4.0.2 [(#​3658)](mockito/mockito#3658) - Bump ru.vyarus:gradle-animalsniffer-plugin from 1.7.2 to 2.0.1 [(#​3657)](mockito/mockito#3657) - Bump org.eclipse.platform:org.eclipse.osgi from 3.22.0 to 3.23.0 [(#​3656)](mockito/mockito#3656) - Bump org.codehaus.groovy:groovy from 3.0.23 to 3.0.24 [(#​3655)](mockito/mockito#3655) - Bump junit-jupiter from 5.11.4 to 5.12.2 [(#​3653)](mockito/mockito#3653) - Reproducible Build: need to inject JDK distribution details to rebuild [(#​3563)](mockito/mockito#3563) </details> <details> <summary>googleapis/google-api-java-client (com.google.api-client:google-api-client)</summary> ### [`v2.8.1`](https://github.com/googleapis/google-api-java-client/blob/HEAD/CHANGELOG.md#281-2025-08-14) ##### Bug Fixes - **deps:** Update project.http.version to v2 ([#​2598](googleapis/google-api-java-client#2598)) ([4874da1](googleapis/google-api-java-client@4874da1)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.1): 1.52.1 ### Components #### Application Security Management (WAF) - π Fix NullPointerException log in AppSec ([#​9356](DataDog/dd-trace-java#9356) - [@​jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - β¨β‘ Do not follow symlinks by default when building repository index ([#​9322](DataDog/dd-trace-java#9322) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) #### GraalVM native-image - π Update GraalVM config to reflect TempLocationManager's new package ([#​9338](DataDog/dd-trace-java#9338) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Profiling - π Properly handle trace agent IPv6 URL in profiling ([#​9339](DataDog/dd-trace-java#9339) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - β¨ Support async servlet for RUM injection ([#​9343](DataDog/dd-trace-java#9343) - [@​amarziali](https://github.com/amarziali)) - π Improve RUM injection matching and avoid truncating responses ([#​9342](DataDog/dd-trace-java#9342) - [@​amarziali](https://github.com/amarziali)) - β¨ Make rum injector stream/writer more resilient to errors ([#​9340](DataDog/dd-trace-java#9340) - [@​amarziali](https://github.com/amarziali)) #### Tracer core - π Avoid NPE on featureDiscovery creation ([#​9354](DataDog/dd-trace-java#9354) - [@​amarziali](https://github.com/amarziali)) </details> --- ### Configuration π **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). π¦ **Automerge**: Enabled. β» **Rebasing**: Never, or you tick the rebase/retry checkbox. π» **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 74bf02ba96add7578dbd1f225449c2f86de0c99d
Backport #9353 to release/v1.52.x