Pool unionmap for log injection #9555

amarziali · 2025-09-17T14:17:07Z

What Does This Do

UnionMaps are used to provide a multimap view backed on original logger's mdc.

The mdc is used to be bound to a thread locality. In recent heap dumps I noticed that we largely allocate instances of this class. Specifically wrt MDC, those objects can be pooled

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-official · 2025-09-17T14:40:13Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.05% (+3.24%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 5a47b6f | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-17T14:50:14Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1758193224	1758210502
git_commit_sha	`f44ec39`	`5a47b6f`
release_version	1.54.0-SNAPSHOT~f44ec39f9b	1.54.0-SNAPSHOT~5a47b6fa89

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758212294	1758212294
ci_job_id	1136510423	1136510423
ci_pipeline_id	76886452	76886452
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-qf8y1a94 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-qf8y1a94 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068763
Total [baseline] (10.728 s) : 0, 10727817
Agent [candidate] (1.061 s) : 0, 1060803
Total [candidate] (10.637 s) : 0, 10637383
section appsec
Agent [baseline] (1.243 s) : 0, 1242945
Total [baseline] (11.04 s) : 0, 11039793
Agent [candidate] (1.234 s) : 0, 1234065
Total [candidate] (11.106 s) : 0, 11105738
section iast
Agent [baseline] (1.192 s) : 0, 1192209
Total [baseline] (11.105 s) : 0, 11105288
Agent [candidate] (1.199 s) : 0, 1199240
Total [candidate] (11.145 s) : 0, 11144730
section profiling
Agent [baseline] (1.212 s) : 0, 1211848
Total [baseline] (10.957 s) : 0, 10956638
Agent [candidate] (1.209 s) : 0, 1208642
Total [candidate] (11.014 s) : 0, 11013894

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.069 s	-
Agent	appsec	1.243 s	174.182 ms (16.3%)
Agent	iast	1.192 s	123.446 ms (11.6%)
Agent	profiling	1.212 s	143.086 ms (13.4%)
Total	tracing	10.728 s	-
Total	appsec	11.04 s	311.976 ms (2.9%)
Total	iast	11.105 s	377.471 ms (3.5%)
Total	profiling	10.957 s	228.821 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.234 s	173.262 ms (16.3%)
Agent	iast	1.199 s	138.437 ms (13.1%)
Agent	profiling	1.209 s	147.839 ms (13.9%)
Total	tracing	10.637 s	-
Total	appsec	11.106 s	468.355 ms (4.4%)
Total	iast	11.145 s	507.347 ms (4.8%)
Total	profiling	11.014 s	376.511 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (737.193 ms) : 0, 737193
BytebuddyAgent [candidate] (730.653 ms) : 0, 730653
GlobalTracer [baseline] (254.269 ms) : 0, 254269
GlobalTracer [candidate] (253.305 ms) : 0, 253305
AppSec [baseline] (30.891 ms) : 0, 30891
AppSec [candidate] (30.813 ms) : 0, 30813
Debugger [baseline] (6.458 ms) : 0, 6458
Debugger [candidate] (6.468 ms) : 0, 6468
Remote Config [baseline] (701.66 µs) : 0, 702
Remote Config [candidate] (696.893 µs) : 0, 697
Telemetry [baseline] (16.641 ms) : 0, 16641
Telemetry [candidate] (16.343 ms) : 0, 16343
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (760.474 ms) : 0, 760474
BytebuddyAgent [candidate] (754.492 ms) : 0, 754492
GlobalTracer [baseline] (247.478 ms) : 0, 247478
GlobalTracer [candidate] (245.527 ms) : 0, 245527
IAST [baseline] (24.18 ms) : 0, 24180
IAST [candidate] (23.961 ms) : 0, 23961
AppSec [baseline] (172.814 ms) : 0, 172814
AppSec [candidate] (171.405 ms) : 0, 171405
Debugger [baseline] (5.988 ms) : 0, 5988
Debugger [candidate] (6.85 ms) : 0, 6850
Remote Config [baseline] (640.712 µs) : 0, 641
Remote Config [candidate] (629.128 µs) : 0, 629
Telemetry [baseline] (8.579 ms) : 0, 8579
Telemetry [candidate] (8.558 ms) : 0, 8558
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (853.872 ms) : 0, 853872
BytebuddyAgent [candidate] (858.629 ms) : 0, 858629
GlobalTracer [baseline] (244.288 ms) : 0, 244288
GlobalTracer [candidate] (244.283 ms) : 0, 244283
IAST [baseline] (31.211 ms) : 0, 31211
IAST [candidate] (30.975 ms) : 0, 30975
AppSec [baseline] (25.486 ms) : 0, 25486
AppSec [candidate] (26.635 ms) : 0, 26635
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.976 ms) : 0, 6976
Remote Config [baseline] (604.351 µs) : 0, 604
Remote Config [candidate] (621.755 µs) : 0, 622
Telemetry [baseline] (8.174 ms) : 0, 8174
Telemetry [candidate] (8.453 ms) : 0, 8453
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (763.205 ms) : 0, 763205
BytebuddyAgent [candidate] (760.291 ms) : 0, 760291
GlobalTracer [baseline] (232.912 ms) : 0, 232912
GlobalTracer [candidate] (232.438 ms) : 0, 232438
AppSec [baseline] (30.479 ms) : 0, 30479
AppSec [candidate] (30.498 ms) : 0, 30498
Debugger [baseline] (12.044 ms) : 0, 12044
Debugger [candidate] (11.251 ms) : 0, 11251
Remote Config [baseline] (1.502 ms) : 0, 1502
Remote Config [candidate] (739.685 µs) : 0, 740
Telemetry [baseline] (10.298 ms) : 0, 10298
Telemetry [candidate] (11.849 ms) : 0, 11849
ProfilingAgent [baseline] (108.704 ms) : 0, 108704
ProfilingAgent [candidate] (108.973 ms) : 0, 108973
Profiling [baseline] (109.331 ms) : 0, 109331
Profiling [candidate] (109.62 ms) : 0, 109620

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064738
Total [baseline] (8.701 s) : 0, 8700694
Agent [candidate] (1.062 s) : 0, 1061859
Total [candidate] (8.668 s) : 0, 8667656
section iast
Agent [baseline] (1.194 s) : 0, 1193783
Total [baseline] (9.322 s) : 0, 9321870
Agent [candidate] (1.19 s) : 0, 1189618
Total [candidate] (9.335 s) : 0, 9334616

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.065 s	-
Agent	iast	1.194 s	129.045 ms (12.1%)
Total	tracing	8.701 s	-
Total	iast	9.322 s	621.176 ms (7.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.19 s	127.759 ms (12.0%)
Total	tracing	8.668 s	-
Total	iast	9.335 s	666.959 ms (7.7%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (733.839 ms) : 0, 733839
BytebuddyAgent [candidate] (732.999 ms) : 0, 732999
GlobalTracer [baseline] (253.898 ms) : 0, 253898
GlobalTracer [candidate] (252.991 ms) : 0, 252991
AppSec [baseline] (30.926 ms) : 0, 30926
AppSec [candidate] (30.811 ms) : 0, 30811
Debugger [baseline] (6.446 ms) : 0, 6446
Debugger [candidate] (6.449 ms) : 0, 6449
Remote Config [baseline] (700.588 µs) : 0, 701
Remote Config [candidate] (695.388 µs) : 0, 695
Telemetry [baseline] (16.442 ms) : 0, 16442
Telemetry [candidate] (15.461 ms) : 0, 15461
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (854.526 ms) : 0, 854526
BytebuddyAgent [candidate] (850.163 ms) : 0, 850163
GlobalTracer [baseline] (246.802 ms) : 0, 246802
GlobalTracer [candidate] (248.232 ms) : 0, 248232
AppSec [baseline] (25.406 ms) : 0, 25406
AppSec [candidate] (24.809 ms) : 0, 24809
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (6.176 ms) : 0, 6176
Remote Config [baseline] (618.401 µs) : 0, 618
Remote Config [candidate] (612.799 µs) : 0, 613
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (8.262 ms) : 0, 8262
IAST [baseline] (29.699 ms) : 0, 29699
IAST [candidate] (28.997 ms) : 0, 28997

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1758193224	1758210502
git_commit_sha	`f44ec39`	`5a47b6f`
release_version	1.54.0-SNAPSHOT~f44ec39f9b	1.54.0-SNAPSHOT~5a47b6fa89

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758211877	1758211877
ci_job_id	1136510426	1136510426
ci_pipeline_id	76886452	76886452
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-gbqbmgiz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-gbqbmgiz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-448.490µs; -218.176µs] or [-5.780%; -2.812%]	unstable [-51.319op/s; +104.381op/s] or [-8.597%; +17.487%]	7.426ms	623.438op/s	7.759ms	596.906op/s
scenario:load:petclinic:appsec:high_load	better [-2.800ms; -1.936ms] or [-5.808%; -4.016%]	unstable [-2.420op/s; +12.395op/s] or [-2.492%; +12.762%]	45.832ms	102.112op/s	48.200ms	97.125op/s
scenario:load:petclinic:tracing:high_load	better [-1.867ms; -1.053ms] or [-4.181%; -2.358%]	unstable [-4.077op/s; +11.127op/s] or [-3.890%; +10.618%]	43.193ms	108.312op/s	44.653ms	104.787op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.462 ms) : 4410, 4514
.   : milestone, 4462,
iast (9.62 ms) : 9457, 9782
.   : milestone, 9620,
iast_FULL (13.752 ms) : 13479, 14025
.   : milestone, 13752,
iast_GLOBAL (10.862 ms) : 10664, 11060
.   : milestone, 10862,
profiling (9.03 ms) : 8886, 9174
.   : milestone, 9030,
tracing (7.759 ms) : 7649, 7870
.   : milestone, 7759,
section candidate
no_agent (4.344 ms) : 4295, 4393
.   : milestone, 4344,
iast (9.445 ms) : 9292, 9599
.   : milestone, 9445,
iast_FULL (14.17 ms) : 13890, 14450
.   : milestone, 14170,
iast_GLOBAL (10.762 ms) : 10565, 10960
.   : milestone, 10762,
profiling (9.225 ms) : 9079, 9370
.   : milestone, 9225,
tracing (7.426 ms) : 7322, 7530
.   : milestone, 7426,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.462 ms [4.41 ms, 4.514 ms]	-
iast	9.62 ms [9.457 ms, 9.782 ms]	5.158 ms (115.6%)
iast_FULL	13.752 ms [13.479 ms, 14.025 ms]	9.29 ms (208.2%)
iast_GLOBAL	10.862 ms [10.664 ms, 11.06 ms]	6.4 ms (143.4%)
profiling	9.03 ms [8.886 ms, 9.174 ms]	4.568 ms (102.4%)
tracing	7.759 ms [7.649 ms, 7.87 ms]	3.297 ms (73.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.344 ms [4.295 ms, 4.393 ms]	-
iast	9.445 ms [9.292 ms, 9.599 ms]	5.102 ms (117.4%)
iast_FULL	14.17 ms [13.89 ms, 14.45 ms]	9.826 ms (226.2%)
iast_GLOBAL	10.762 ms [10.565 ms, 10.96 ms]	6.418 ms (147.8%)
profiling	9.225 ms [9.079 ms, 9.37 ms]	4.881 ms (112.4%)
tracing	7.426 ms [7.322 ms, 7.53 ms]	3.082 ms (71.0%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.894 ms) : 36593, 37194
.   : milestone, 36894,
appsec (48.2 ms) : 47793, 48606
.   : milestone, 48200,
code_origins (46.393 ms) : 45977, 46809
.   : milestone, 46393,
iast (46.468 ms) : 46057, 46880
.   : milestone, 46468,
profiling (48.311 ms) : 47884, 48738
.   : milestone, 48311,
tracing (44.653 ms) : 44257, 45049
.   : milestone, 44653,
section candidate
no_agent (36.791 ms) : 36499, 37084
.   : milestone, 36791,
appsec (45.832 ms) : 45436, 46228
.   : milestone, 45832,
code_origins (46.099 ms) : 45705, 46492
.   : milestone, 46099,
iast (45.658 ms) : 45259, 46057
.   : milestone, 45658,
profiling (47.763 ms) : 47300, 48226
.   : milestone, 47763,
tracing (43.193 ms) : 42833, 43552
.   : milestone, 43193,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.894 ms [36.593 ms, 37.194 ms]	-
appsec	48.2 ms [47.793 ms, 48.606 ms]	11.306 ms (30.6%)
code_origins	46.393 ms [45.977 ms, 46.809 ms]	9.499 ms (25.7%)
iast	46.468 ms [46.057 ms, 46.88 ms]	9.575 ms (26.0%)
profiling	48.311 ms [47.884 ms, 48.738 ms]	11.418 ms (30.9%)
tracing	44.653 ms [44.257 ms, 45.049 ms]	7.759 ms (21.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.791 ms [36.499 ms, 37.084 ms]	-
appsec	45.832 ms [45.436 ms, 46.228 ms]	9.041 ms (24.6%)
code_origins	46.099 ms [45.705 ms, 46.492 ms]	9.308 ms (25.3%)
iast	45.658 ms [45.259 ms, 46.057 ms]	8.867 ms (24.1%)
profiling	47.763 ms [47.3 ms, 48.226 ms]	10.972 ms (29.8%)
tracing	43.193 ms [42.833 ms, 43.552 ms]	6.402 ms (17.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/test-union
git_commit_date	1758193224	1758210502
git_commit_sha	`f44ec39`	`5a47b6f`
release_version	1.54.0-SNAPSHOT~f44ec39f9b	1.54.0-SNAPSHOT~5a47b6fa89

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1758212425	1758212425
ci_job_id	1136510428	1136510428
ci_pipeline_id	76886452	76886452
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-2jw9zoux 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-2jw9zoux 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
.   : milestone, 1482,
appsec (3.727 ms) : 3510, 3944
.   : milestone, 3727,
iast (2.225 ms) : 2162, 2289
.   : milestone, 2225,
iast_GLOBAL (2.269 ms) : 2205, 2332
.   : milestone, 2269,
profiling (2.532 ms) : 2361, 2703
.   : milestone, 2532,
tracing (2.037 ms) : 1988, 2087
.   : milestone, 2037,
section candidate
no_agent (1.484 ms) : 1473, 1496
.   : milestone, 1484,
appsec (3.782 ms) : 3563, 4002
.   : milestone, 3782,
iast (2.217 ms) : 2154, 2280
.   : milestone, 2217,
iast_GLOBAL (2.269 ms) : 2205, 2333
.   : milestone, 2269,
profiling (2.06 ms) : 2009, 2111
.   : milestone, 2060,
tracing (2.039 ms) : 1989, 2089
.   : milestone, 2039,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.47 ms, 1.493 ms]	-
appsec	3.727 ms [3.51 ms, 3.944 ms]	2.245 ms (151.5%)
iast	2.225 ms [2.162 ms, 2.289 ms]	743.775 µs (50.2%)
iast_GLOBAL	2.269 ms [2.205 ms, 2.332 ms]	786.961 µs (53.1%)
profiling	2.532 ms [2.361 ms, 2.703 ms]	1.05 ms (70.9%)
tracing	2.037 ms [1.988 ms, 2.087 ms]	555.417 µs (37.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.484 ms [1.473 ms, 1.496 ms]	-
appsec	3.782 ms [3.563 ms, 4.002 ms]	2.298 ms (154.8%)
iast	2.217 ms [2.154 ms, 2.28 ms]	732.571 µs (49.4%)
iast_GLOBAL	2.269 ms [2.205 ms, 2.333 ms]	784.815 µs (52.9%)
profiling	2.06 ms [2.009 ms, 2.111 ms]	575.293 µs (38.8%)
tracing	2.039 ms [1.989 ms, 2.089 ms]	554.734 µs (37.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~5a47b6fa89, baseline=1.54.0-SNAPSHOT~f44ec39f9b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.557 s) : 15557000, 15557000
.   : milestone, 15557000,
appsec (14.851 s) : 14851000, 14851000
.   : milestone, 14851000,
iast (18.457 s) : 18457000, 18457000
.   : milestone, 18457000,
iast_GLOBAL (18.205 s) : 18205000, 18205000
.   : milestone, 18205000,
profiling (15.464 s) : 15464000, 15464000
.   : milestone, 15464000,
tracing (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
section candidate
no_agent (14.921 s) : 14921000, 14921000
.   : milestone, 14921000,
appsec (14.812 s) : 14812000, 14812000
.   : milestone, 14812000,
iast (18.462 s) : 18462000, 18462000
.   : milestone, 18462000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
.   : milestone, 18215000,
profiling (15.433 s) : 15433000, 15433000
.   : milestone, 15433000,
tracing (14.764 s) : 14764000, 14764000
.   : milestone, 14764000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.557 s [15.557 s, 15.557 s]	-
appsec	14.851 s [14.851 s, 14.851 s]	-706.0 ms (-4.5%)
iast	18.457 s [18.457 s, 18.457 s]	2.9 s (18.6%)
iast_GLOBAL	18.205 s [18.205 s, 18.205 s]	2.648 s (17.0%)
profiling	15.464 s [15.464 s, 15.464 s]	-93.0 ms (-0.6%)
tracing	15.036 s [15.036 s, 15.036 s]	-521.0 ms (-3.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.921 s [14.921 s, 14.921 s]	-
appsec	14.812 s [14.812 s, 14.812 s]	-109.0 ms (-0.7%)
iast	18.462 s [18.462 s, 18.462 s]	3.541 s (23.7%)
iast_GLOBAL	18.215 s [18.215 s, 18.215 s]	3.294 s (22.1%)
profiling	15.433 s [15.433 s, 15.433 s]	512.0 ms (3.4%)
tracing	14.764 s [14.764 s, 14.764 s]	-157.0 ms (-1.1%)

github-actions · 2025-09-18T08:36:37Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

dougqh · 2025-09-19T01:51:50Z

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java

+  private Map<K, V> secondaryMap;
  private transient Set<Map.Entry<K, V>> entrySet;
  private transient volatile boolean deduped;
+  private static final ThreadLocal<UnionMap<?, ?>> TL = new ThreadLocal<>();


It might make sense to just have a no-arg constructor and override ThreadLocal.initialValue.
Then you could have an init(primaryMap, secondaryMap)
I think that might read a bit better.

dougqh · 2025-09-19T01:52:21Z

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/log/UnionMap.java

  }

+  @SuppressWarnings({"unchecked"})
+  public static <K, V> UnionMap<K, V> create(Map<K, V> primaryMap, Map<K, V> secondaryMap) {


I think I'd prefer some other name than create, but I'm not sure what that would be.

Reuse unionmaps for thread bound MDCs

e60ce1a

amarziali force-pushed the andrea.marziali/test-union branch from 61f2c07 to e60ce1a Compare September 17, 2025 16:04

amarziali marked this pull request as ready for review September 18, 2025 08:36

amarziali requested review from a team as code owners September 18, 2025 08:36

amarziali requested a review from smola September 18, 2025 08:36

amarziali added tag: performance Performance related changes comp: logging Tracer internal logging labels Sep 18, 2025

Merge branch 'master' into andrea.marziali/test-union

4590f1f

amarziali added the type: enhancement Enhancements and improvements label Sep 18, 2025

Merge branch 'master' into andrea.marziali/test-union

5a47b6f

amarziali changed the title ~~test reusing unionmaps~~ Pool unionmap for log injection Sep 18, 2025

amarziali requested review from mcculls and dougqh September 18, 2025 16:30

dougqh reviewed Sep 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pool unionmap for log injection #9555

Pool unionmap for log injection #9555

Uh oh!

amarziali commented Sep 17, 2025 •

edited

Loading

Uh oh!

datadog-official bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 18, 2025 •

edited

Loading

Uh oh!

dougqh Sep 19, 2025

Uh oh!

dougqh Sep 19, 2025

Uh oh!

Uh oh!

Pool unionmap for log injection #9555

Are you sure you want to change the base?

Pool unionmap for log injection #9555

Uh oh!

Conversation

amarziali commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougqh Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

dougqh Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amarziali commented Sep 17, 2025 •

edited

Loading

datadog-official bot commented Sep 17, 2025 •

edited

Loading

pr-commenter bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Sep 18, 2025 •

edited

Loading