-
Notifications
You must be signed in to change notification settings - Fork 312
Makes writing the test jar buffered #9561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 988561a | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061215
Total [baseline] (10.6 s) : 0, 10599554
Agent [candidate] (1.061 s) : 0, 1061353
Total [candidate] (10.769 s) : 0, 10768577
section appsec
Agent [baseline] (1.236 s) : 0, 1235673
Total [baseline] (11.054 s) : 0, 11054323
Agent [candidate] (1.24 s) : 0, 1240249
Total [candidate] (10.994 s) : 0, 10994270
section iast
Agent [baseline] (1.195 s) : 0, 1194767
Total [baseline] (11.046 s) : 0, 11045522
Agent [candidate] (1.208 s) : 0, 1207933
Total [candidate] (11.209 s) : 0, 11209114
section profiling
Agent [baseline] (1.212 s) : 0, 1212108
Total [baseline] (10.96 s) : 0, 10959941
Agent [candidate] (1.217 s) : 0, 1217179
Total [candidate] (10.968 s) : 0, 10967689
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (732.354 ms) : 0, 732354
BytebuddyAgent [candidate] (732.417 ms) : 0, 732417
GlobalTracer [baseline] (252.904 ms) : 0, 252904
GlobalTracer [candidate] (252.567 ms) : 0, 252567
AppSec [baseline] (30.638 ms) : 0, 30638
AppSec [candidate] (30.595 ms) : 0, 30595
Debugger [baseline] (6.418 ms) : 0, 6418
Debugger [candidate] (6.393 ms) : 0, 6393
Remote Config [baseline] (698.684 µs) : 0, 699
Remote Config [candidate] (690.417 µs) : 0, 690
Telemetry [baseline] (15.73 ms) : 0, 15730
Telemetry [candidate] (16.238 ms) : 0, 16238
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (756.603 ms) : 0, 756603
BytebuddyAgent [candidate] (760.875 ms) : 0, 760875
GlobalTracer [baseline] (246.179 ms) : 0, 246179
GlobalTracer [candidate] (246.346 ms) : 0, 246346
IAST [baseline] (23.871 ms) : 0, 23871
IAST [candidate] (23.802 ms) : 0, 23802
AppSec [baseline] (171.199 ms) : 0, 171199
AppSec [candidate] (170.634 ms) : 0, 170634
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.773 ms) : 0, 6773
Remote Config [baseline] (630.433 µs) : 0, 630
Remote Config [candidate] (613.243 µs) : 0, 613
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (8.491 ms) : 0, 8491
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (855.308 ms) : 0, 855308
BytebuddyAgent [candidate] (865.57 ms) : 0, 865570
GlobalTracer [baseline] (247.624 ms) : 0, 247624
GlobalTracer [candidate] (248.339 ms) : 0, 248339
IAST [baseline] (27.901 ms) : 0, 27901
IAST [candidate] (28.429 ms) : 0, 28429
AppSec [baseline] (26.427 ms) : 0, 26427
AppSec [candidate] (27.728 ms) : 0, 27728
Debugger [baseline] (6.1 ms) : 0, 6100
Debugger [candidate] (6.142 ms) : 0, 6142
Remote Config [baseline] (606.545 µs) : 0, 607
Remote Config [candidate] (614.261 µs) : 0, 614
Telemetry [baseline] (8.355 ms) : 0, 8355
Telemetry [candidate] (8.376 ms) : 0, 8376
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (762.795 ms) : 0, 762795
BytebuddyAgent [candidate] (765.463 ms) : 0, 765463
GlobalTracer [baseline] (233.166 ms) : 0, 233166
GlobalTracer [candidate] (234.26 ms) : 0, 234260
AppSec [baseline] (30.673 ms) : 0, 30673
AppSec [candidate] (31.577 ms) : 0, 31577
Debugger [baseline] (13.655 ms) : 0, 13655
Debugger [candidate] (12.059 ms) : 0, 12059
Remote Config [baseline] (753.826 µs) : 0, 754
Remote Config [candidate] (724.746 µs) : 0, 725
Telemetry [baseline] (9.525 ms) : 0, 9525
Telemetry [candidate] (10.362 ms) : 0, 10362
ProfilingAgent [baseline] (108.858 ms) : 0, 108858
ProfilingAgent [candidate] (109.841 ms) : 0, 109841
Profiling [baseline] (109.483 ms) : 0, 109483
Profiling [candidate] (110.477 ms) : 0, 110477
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069952
Total [baseline] (8.663 s) : 0, 8663065
Agent [candidate] (1.07 s) : 0, 1070131
Total [candidate] (8.649 s) : 0, 8649111
section iast
Agent [baseline] (1.191 s) : 0, 1190650
Total [baseline] (9.275 s) : 0, 9275154
Agent [candidate] (1.189 s) : 0, 1188983
Total [candidate] (9.296 s) : 0, 9295878
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (739.059 ms) : 0, 739059
BytebuddyAgent [candidate] (739.216 ms) : 0, 739216
GlobalTracer [baseline] (253.932 ms) : 0, 253932
GlobalTracer [candidate] (253.878 ms) : 0, 253878
AppSec [baseline] (30.7 ms) : 0, 30700
AppSec [candidate] (30.889 ms) : 0, 30889
Debugger [baseline] (6.39 ms) : 0, 6390
Debugger [candidate] (6.421 ms) : 0, 6421
Remote Config [baseline] (702.002 µs) : 0, 702
Remote Config [candidate] (687.482 µs) : 0, 687
Telemetry [baseline] (16.594 ms) : 0, 16594
Telemetry [candidate] (16.408 ms) : 0, 16408
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (852.438 ms) : 0, 852438
BytebuddyAgent [candidate] (851.085 ms) : 0, 851085
GlobalTracer [baseline] (247.851 ms) : 0, 247851
GlobalTracer [candidate] (249.116 ms) : 0, 249116
IAST [baseline] (27.08 ms) : 0, 27080
IAST [candidate] (26.872 ms) : 0, 26872
AppSec [baseline] (26.235 ms) : 0, 26235
AppSec [candidate] (24.734 ms) : 0, 24734
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (6.041 ms) : 0, 6041
Remote Config [baseline] (586.847 µs) : 0, 587
Remote Config [candidate] (585.268 µs) : 0, 585
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.226 ms) : 0, 8226
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (4.325 ms) : 4277, 4374
. : milestone, 4325,
iast (9.355 ms) : 9199, 9510
. : milestone, 9355,
iast_FULL (14.271 ms) : 13984, 14558
. : milestone, 14271,
iast_GLOBAL (10.832 ms) : 10631, 11033
. : milestone, 10832,
profiling (9.414 ms) : 9265, 9563
. : milestone, 9414,
tracing (7.636 ms) : 7522, 7749
. : milestone, 7636,
section candidate
no_agent (4.387 ms) : 4337, 4437
. : milestone, 4387,
iast (9.37 ms) : 9212, 9528
. : milestone, 9370,
iast_FULL (14.102 ms) : 13825, 14379
. : milestone, 14102,
iast_GLOBAL (10.969 ms) : 10768, 11170
. : milestone, 10969,
profiling (8.988 ms) : 8837, 9138
. : milestone, 8988,
tracing (7.637 ms) : 7531, 7744
. : milestone, 7637,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (38.023 ms) : 37721, 38324
. : milestone, 38023,
appsec (49.511 ms) : 49074, 49948
. : milestone, 49511,
code_origins (46.098 ms) : 45688, 46508
. : milestone, 46098,
iast (45.427 ms) : 45018, 45836
. : milestone, 45427,
profiling (47.428 ms) : 47002, 47853
. : milestone, 47428,
tracing (44.951 ms) : 44560, 45341
. : milestone, 44951,
section candidate
no_agent (38.385 ms) : 38076, 38695
. : milestone, 38385,
appsec (45.988 ms) : 45587, 46390
. : milestone, 45988,
code_origins (45.886 ms) : 45511, 46261
. : milestone, 45886,
iast (45.936 ms) : 45545, 46328
. : milestone, 45936,
profiling (48.836 ms) : 48367, 49305
. : milestone, 48836,
tracing (43.457 ms) : 43105, 43808
. : milestone, 43457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
appsec (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
iast (18.813 s) : 18813000, 18813000
. : milestone, 18813000,
iast_GLOBAL (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
profiling (15.911 s) : 15911000, 15911000
. : milestone, 15911000,
tracing (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
section candidate
no_agent (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.7 s) : 18700000, 18700000
. : milestone, 18700000,
iast_GLOBAL (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
profiling (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
tracing (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~988561adfb, baseline=1.54.0-SNAPSHOT~f44ec39f9b
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.709 ms) : 3490, 3928
. : milestone, 3709,
iast (2.188 ms) : 2126, 2250
. : milestone, 2188,
iast_GLOBAL (2.23 ms) : 2167, 2293
. : milestone, 2230,
profiling (2.48 ms) : 2310, 2649
. : milestone, 2480,
tracing (2.015 ms) : 1966, 2064
. : milestone, 2015,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.695 ms) : 3480, 3910
. : milestone, 3695,
iast (2.181 ms) : 2118, 2243
. : milestone, 2181,
iast_GLOBAL (2.237 ms) : 2174, 2301
. : milestone, 2237,
profiling (2.067 ms) : 2015, 2119
. : milestone, 2067,
tracing (2.015 ms) : 1966, 2064
. : milestone, 2015,
|
What Does This Do
JarOutputStream
was writing to an unbuffered stream. This Pr wraps it inBufferedOutputStream
.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]