-
Notifications
You must be signed in to change notification settings - Fork 312
Migrate Maven instrumentation and Ut8Cache tests to JUnit 5 #9568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Migrate Maven instrumentation and Ut8Cache tests to JUnit 5 #9568
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 13 performance regressions! Performance is the same for 32 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017669
Total [baseline] (8.625 s) : 0, 8624982
Agent [candidate] (1.069 s) : 0, 1068718
Total [candidate] (8.632 s) : 0, 8632171
section iast
Agent [baseline] (1.154 s) : 0, 1153561
Total [baseline] (9.388 s) : 0, 9387885
Agent [candidate] (1.191 s) : 0, 1191348
Total [candidate] (9.284 s) : 0, 9284129
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (688.499 ms) : 0, 688499
BytebuddyAgent [candidate] (737.463 ms) : 0, 737463
GlobalTracer [baseline] (257.789 ms) : 0, 257789
GlobalTracer [candidate] (254.346 ms) : 0, 254346
AppSec [baseline] (31.581 ms) : 0, 31581
AppSec [candidate] (30.762 ms) : 0, 30762
Debugger [baseline] (6.344 ms) : 0, 6344
Debugger [candidate] (6.413 ms) : 0, 6413
Remote Config [baseline] (684.271 µs) : 0, 684
Remote Config [candidate] (700.633 µs) : 0, 701
Telemetry [baseline] (10.334 ms) : 0, 10334
Telemetry [candidate] (16.488 ms) : 0, 16488
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (808.69 ms) : 0, 808690
BytebuddyAgent [candidate] (853.031 ms) : 0, 853031
GlobalTracer [baseline] (248.933 ms) : 0, 248933
GlobalTracer [candidate] (249.192 ms) : 0, 249192
IAST [baseline] (30.661 ms) : 0, 30661
IAST [candidate] (25.39 ms) : 0, 25390
AppSec [baseline] (28.07 ms) : 0, 28070
AppSec [candidate] (26.364 ms) : 0, 26364
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.036 ms) : 0, 6036
Remote Config [baseline] (600.346 µs) : 0, 600
Remote Config [candidate] (596.771 µs) : 0, 597
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.242 ms) : 0, 8242
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023880
Total [baseline] (10.743 s) : 0, 10743407
Agent [candidate] (1.059 s) : 0, 1059224
Total [candidate] (10.695 s) : 0, 10694932
section appsec
Agent [baseline] (1.205 s) : 0, 1204806
Total [baseline] (11.031 s) : 0, 11030502
Agent [candidate] (1.237 s) : 0, 1237174
Total [candidate] (11.108 s) : 0, 11108035
section iast
Agent [baseline] (1.154 s) : 0, 1153683
Total [baseline] (11.068 s) : 0, 11067536
Agent [candidate] (1.191 s) : 0, 1190976
Total [candidate] (11.065 s) : 0, 11064913
section profiling
Agent [baseline] (1.165 s) : 0, 1165265
Total [baseline] (11.06 s) : 0, 11059962
Agent [candidate] (1.216 s) : 0, 1215757
Total [candidate] (10.95 s) : 0, 10949757
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (691.948 ms) : 0, 691948
BytebuddyAgent [candidate] (731.232 ms) : 0, 731232
GlobalTracer [baseline] (260.493 ms) : 0, 260493
GlobalTracer [candidate] (252.641 ms) : 0, 252641
AppSec [baseline] (31.974 ms) : 0, 31974
AppSec [candidate] (30.527 ms) : 0, 30527
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.378 ms) : 0, 6378
Remote Config [baseline] (692.295 µs) : 0, 692
Remote Config [candidate] (684.863 µs) : 0, 685
Telemetry [baseline] (9.74 ms) : 0, 9740
Telemetry [candidate] (15.343 ms) : 0, 15343
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (717.095 ms) : 0, 717095
BytebuddyAgent [candidate] (757.122 ms) : 0, 757122
GlobalTracer [baseline] (252.462 ms) : 0, 252462
GlobalTracer [candidate] (246.821 ms) : 0, 246821
IAST [baseline] (24.906 ms) : 0, 24906
IAST [candidate] (23.779 ms) : 0, 23779
AppSec [baseline] (170.214 ms) : 0, 170214
AppSec [candidate] (171.594 ms) : 0, 171594
Debugger [baseline] (6.124 ms) : 0, 6124
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (624.164 µs) : 0, 624
Remote Config [candidate] (636.852 µs) : 0, 637
Telemetry [baseline] (10.727 ms) : 0, 10727
Telemetry [candidate] (8.58 ms) : 0, 8580
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (808.153 ms) : 0, 808153
BytebuddyAgent [candidate] (852.587 ms) : 0, 852587
GlobalTracer [baseline] (249.469 ms) : 0, 249469
GlobalTracer [candidate] (246.674 ms) : 0, 246674
IAST [baseline] (31.468 ms) : 0, 31468
IAST [candidate] (27.289 ms) : 0, 27289
AppSec [baseline] (26.428 ms) : 0, 26428
AppSec [candidate] (26.95 ms) : 0, 26950
Debugger [baseline] (6.161 ms) : 0, 6161
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (597.003 µs) : 0, 597
Remote Config [candidate] (602.136 µs) : 0, 602
Telemetry [baseline] (8.958 ms) : 0, 8958
Telemetry [candidate] (8.359 ms) : 0, 8359
section profiling
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (719.717 ms) : 0, 719717
BytebuddyAgent [candidate] (765.767 ms) : 0, 765767
GlobalTracer [baseline] (236.688 ms) : 0, 236688
GlobalTracer [candidate] (234.452 ms) : 0, 234452
AppSec [baseline] (31.117 ms) : 0, 31117
AppSec [candidate] (30.31 ms) : 0, 30310
Debugger [baseline] (6.514 ms) : 0, 6514
Debugger [candidate] (12.956 ms) : 0, 12956
Remote Config [baseline] (719.747 µs) : 0, 720
Remote Config [candidate] (1.577 ms) : 0, 1577
Telemetry [baseline] (16.504 ms) : 0, 16504
Telemetry [candidate] (9.476 ms) : 0, 9476
ProfilingAgent [baseline] (101.581 ms) : 0, 101581
ProfilingAgent [candidate] (108.417 ms) : 0, 108417
Profiling [baseline] (102.182 ms) : 0, 102182
Profiling [candidate] (109.097 ms) : 0, 109097
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (4.138 ms) : 4089, 4187
. : milestone, 4138,
iast (10.562 ms) : 10373, 10751
. : milestone, 10562,
iast_FULL (14.86 ms) : 14565, 15155
. : milestone, 14860,
iast_GLOBAL (10.941 ms) : 10747, 11134
. : milestone, 10941,
profiling (9.266 ms) : 9118, 9414
. : milestone, 9266,
tracing (7.61 ms) : 7501, 7719
. : milestone, 7610,
section candidate
no_agent (4.412 ms) : 4360, 4463
. : milestone, 4412,
iast (9.667 ms) : 9506, 9828
. : milestone, 9667,
iast_FULL (14.193 ms) : 13905, 14482
. : milestone, 14193,
iast_GLOBAL (10.626 ms) : 10426, 10826
. : milestone, 10626,
profiling (8.915 ms) : 8769, 9061
. : milestone, 8915,
tracing (7.94 ms) : 7824, 8056
. : milestone, 7940,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (36.77 ms) : 36469, 37071
. : milestone, 36770,
appsec (48.788 ms) : 48355, 49221
. : milestone, 48788,
code_origins (45.642 ms) : 45244, 46040
. : milestone, 45642,
iast (44.922 ms) : 44513, 45331
. : milestone, 44922,
profiling (50.024 ms) : 49496, 50552
. : milestone, 50024,
tracing (44.548 ms) : 44170, 44925
. : milestone, 44548,
section candidate
no_agent (36.627 ms) : 36335, 36918
. : milestone, 36627,
appsec (48.44 ms) : 48014, 48866
. : milestone, 48440,
code_origins (45.869 ms) : 45469, 46269
. : milestone, 45869,
iast (44.384 ms) : 43995, 44773
. : milestone, 44384,
profiling (48.498 ms) : 48029, 48966
. : milestone, 48498,
tracing (43.85 ms) : 43468, 44232
. : milestone, 43850,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.445 ms) : 2395, 2494
. : milestone, 2445,
iast (2.201 ms) : 2139, 2264
. : milestone, 2201,
iast_GLOBAL (2.249 ms) : 2186, 2311
. : milestone, 2249,
profiling (2.068 ms) : 2016, 2120
. : milestone, 2068,
tracing (2.038 ms) : 1989, 2087
. : milestone, 2038,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.75 ms) : 3532, 3968
. : milestone, 3750,
iast (2.214 ms) : 2151, 2277
. : milestone, 2214,
iast_GLOBAL (2.244 ms) : 2181, 2307
. : milestone, 2244,
profiling (2.369 ms) : 2225, 2514
. : milestone, 2369,
tracing (2.038 ms) : 1989, 2088
. : milestone, 2038,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~67f1cf75fc, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (15.395 s) : 15395000, 15395000
. : milestone, 15395000,
appsec (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
iast (18.356 s) : 18356000, 18356000
. : milestone, 18356000,
iast_GLOBAL (18.406 s) : 18406000, 18406000
. : milestone, 18406000,
profiling (16.01 s) : 16010000, 16010000
. : milestone, 16010000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
section candidate
no_agent (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.92 s) : 18920000, 18920000
. : milestone, 18920000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
tracing (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
|
- updating tests to not use magic number and use MAX_ENTRY_LEN of their respective cache - had to make MAX_ENTRY_LEN package visible in both caches
🎯 Code Coverage 🔗 Commit SHA: 67f1cf7 | Docs | Was this helpful? Give us feedback! |
What Does This Do
org.junit.test
to JUnit 5.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]