-
Notifications
You must be signed in to change notification settings - Fork 312
Replace FixedSizeStripedLongAdder with LongAdder #9571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
🎯 Code Coverage 🔗 Commit SHA: 771c012 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029077
Total [baseline] (10.717 s) : 0, 10716757
Agent [candidate] (1.032 s) : 0, 1031754
Total [candidate] (10.76 s) : 0, 10759907
section appsec
Agent [baseline] (1.198 s) : 0, 1198085
Total [baseline] (10.973 s) : 0, 10972752
Agent [candidate] (1.21 s) : 0, 1209829
Total [candidate] (11.062 s) : 0, 11062189
section iast
Agent [baseline] (1.167 s) : 0, 1167319
Total [baseline] (11.139 s) : 0, 11139123
Agent [candidate] (1.154 s) : 0, 1153902
Total [candidate] (11.066 s) : 0, 11065578
section profiling
Agent [baseline] (1.167 s) : 0, 1167087
Total [baseline] (11.044 s) : 0, 11044227
Agent [candidate] (1.189 s) : 0, 1189080
Total [candidate] (11.047 s) : 0, 11046773
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (692.01 ms) : 0, 692010
BytebuddyAgent [candidate] (697.902 ms) : 0, 697902
GlobalTracer [baseline] (260.321 ms) : 0, 260321
GlobalTracer [candidate] (260.155 ms) : 0, 260155
AppSec [baseline] (31.956 ms) : 0, 31956
AppSec [candidate] (31.932 ms) : 0, 31932
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.429 ms) : 0, 6429
Remote Config [baseline] (686.241 µs) : 0, 686
Remote Config [candidate] (689.842 µs) : 0, 690
Telemetry [baseline] (15.044 ms) : 0, 15044
Telemetry [candidate] (11.864 ms) : 0, 11864
section appsec
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (710.91 ms) : 0, 710910
BytebuddyAgent [candidate] (719.076 ms) : 0, 719076
GlobalTracer [baseline] (251.607 ms) : 0, 251607
GlobalTracer [candidate] (252.976 ms) : 0, 252976
IAST [baseline] (25.117 ms) : 0, 25117
IAST [candidate] (25.332 ms) : 0, 25332
AppSec [baseline] (170.458 ms) : 0, 170458
AppSec [candidate] (173.545 ms) : 0, 173545
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.119 ms) : 0, 6119
Remote Config [baseline] (630.343 µs) : 0, 630
Remote Config [candidate] (629.842 µs) : 0, 630
Telemetry [baseline] (10.689 ms) : 0, 10689
Telemetry [candidate] (9.384 ms) : 0, 9384
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (817.851 ms) : 0, 817851
BytebuddyAgent [candidate] (809.196 ms) : 0, 809196
GlobalTracer [baseline] (251.743 ms) : 0, 251743
GlobalTracer [candidate] (248.477 ms) : 0, 248477
IAST [baseline] (29.627 ms) : 0, 29627
IAST [candidate] (28.277 ms) : 0, 28277
AppSec [baseline] (30.241 ms) : 0, 30241
AppSec [candidate] (30.497 ms) : 0, 30497
Debugger [baseline] (6.146 ms) : 0, 6146
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (608.909 µs) : 0, 609
Remote Config [candidate] (593.331 µs) : 0, 593
Telemetry [baseline] (8.239 ms) : 0, 8239
Telemetry [candidate] (8.227 ms) : 0, 8227
section profiling
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (720.806 ms) : 0, 720806
BytebuddyAgent [candidate] (735.219 ms) : 0, 735219
GlobalTracer [baseline] (237.165 ms) : 0, 237165
GlobalTracer [candidate] (239.836 ms) : 0, 239836
AppSec [baseline] (31.126 ms) : 0, 31126
AppSec [candidate] (31.739 ms) : 0, 31739
Debugger [baseline] (6.5 ms) : 0, 6500
Debugger [candidate] (6.658 ms) : 0, 6658
Remote Config [baseline] (696.285 µs) : 0, 696
Remote Config [candidate] (710.334 µs) : 0, 710
Telemetry [baseline] (16.665 ms) : 0, 16665
Telemetry [candidate] (16.877 ms) : 0, 16877
ProfilingAgent [baseline] (101.594 ms) : 0, 101594
ProfilingAgent [candidate] (104.353 ms) : 0, 104353
Profiling [baseline] (102.192 ms) : 0, 102192
Profiling [candidate] (104.986 ms) : 0, 104986
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029573
Total [baseline] (8.664 s) : 0, 8664325
Agent [candidate] (1.026 s) : 0, 1025679
Total [candidate] (8.653 s) : 0, 8653435
section iast
Agent [baseline] (1.157 s) : 0, 1156654
Total [baseline] (9.397 s) : 0, 9396710
Agent [candidate] (1.155 s) : 0, 1155351
Total [candidate] (9.408 s) : 0, 9408251
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (693.683 ms) : 0, 693683
BytebuddyAgent [candidate] (690.334 ms) : 0, 690334
GlobalTracer [baseline] (260.776 ms) : 0, 260776
GlobalTracer [candidate] (259.105 ms) : 0, 259105
AppSec [baseline] (31.894 ms) : 0, 31894
AppSec [candidate] (31.74 ms) : 0, 31740
Debugger [baseline] (6.384 ms) : 0, 6384
Debugger [candidate] (6.407 ms) : 0, 6407
Remote Config [baseline] (687.252 µs) : 0, 687
Remote Config [candidate] (683.721 µs) : 0, 684
Telemetry [baseline] (13.43 ms) : 0, 13430
Telemetry [candidate] (14.917 ms) : 0, 14917
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (810.092 ms) : 0, 810092
BytebuddyAgent [candidate] (809.641 ms) : 0, 809641
GlobalTracer [baseline] (249.909 ms) : 0, 249909
GlobalTracer [candidate] (249.261 ms) : 0, 249261
IAST [baseline] (26.867 ms) : 0, 26867
IAST [candidate] (27.592 ms) : 0, 27592
AppSec [baseline] (32.368 ms) : 0, 32368
AppSec [candidate] (31.431 ms) : 0, 31431
Debugger [baseline] (6.016 ms) : 0, 6016
Debugger [candidate] (6.086 ms) : 0, 6086
Remote Config [baseline] (601.957 µs) : 0, 602
Remote Config [candidate] (598.546 µs) : 0, 599
Telemetry [baseline] (8.278 ms) : 0, 8278
Telemetry [candidate] (8.222 ms) : 0, 8222
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (4.353 ms) : 4304, 4402
. : milestone, 4353,
iast (9.628 ms) : 9462, 9794
. : milestone, 9628,
iast_FULL (14.421 ms) : 14140, 14702
. : milestone, 14421,
iast_GLOBAL (10.714 ms) : 10520, 10908
. : milestone, 10714,
profiling (8.928 ms) : 8790, 9066
. : milestone, 8928,
tracing (7.431 ms) : 7315, 7548
. : milestone, 7431,
section candidate
no_agent (4.216 ms) : 4168, 4263
. : milestone, 4216,
iast (9.829 ms) : 9665, 9993
. : milestone, 9829,
iast_FULL (13.962 ms) : 13686, 14238
. : milestone, 13962,
iast_GLOBAL (10.619 ms) : 10430, 10808
. : milestone, 10619,
profiling (9.737 ms) : 9584, 9891
. : milestone, 9737,
tracing (7.869 ms) : 7755, 7983
. : milestone, 7869,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (36.949 ms) : 36660, 37238
. : milestone, 36949,
appsec (49.237 ms) : 48807, 49668
. : milestone, 49237,
code_origins (44.492 ms) : 44102, 44882
. : milestone, 44492,
iast (46.091 ms) : 45674, 46508
. : milestone, 46091,
profiling (48.53 ms) : 48089, 48971
. : milestone, 48530,
tracing (43.846 ms) : 43468, 44225
. : milestone, 43846,
section candidate
no_agent (37.558 ms) : 37253, 37864
. : milestone, 37558,
appsec (49.62 ms) : 49187, 50054
. : milestone, 49620,
code_origins (45.127 ms) : 44741, 45513
. : milestone, 45127,
iast (46.719 ms) : 46311, 47127
. : milestone, 46719,
profiling (47.665 ms) : 47215, 48115
. : milestone, 47665,
tracing (45.372 ms) : 44983, 45760
. : milestone, 45372,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.681 ms) : 3465, 3898
. : milestone, 3681,
iast (2.2 ms) : 2137, 2262
. : milestone, 2200,
iast_GLOBAL (2.244 ms) : 2182, 2307
. : milestone, 2244,
profiling (2.048 ms) : 1997, 2098
. : milestone, 2048,
tracing (2.029 ms) : 1980, 2078
. : milestone, 2029,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.661 ms) : 3448, 3875
. : milestone, 3661,
iast (2.202 ms) : 2140, 2265
. : milestone, 2202,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.079 ms) : 2027, 2132
. : milestone, 2079,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~771c01264c, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
appsec (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
iast (18.518 s) : 18518000, 18518000
. : milestone, 18518000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
. : milestone, 17969000,
profiling (16.108 s) : 16108000, 16108000
. : milestone, 16108000,
tracing (15.021 s) : 15021000, 15021000
. : milestone, 15021000,
section candidate
no_agent (15.341 s) : 15341000, 15341000
. : milestone, 15341000,
appsec (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
iast (18.476 s) : 18476000, 18476000
. : milestone, 18476000,
iast_GLOBAL (17.917 s) : 17917000, 17917000
. : milestone, 17917000,
profiling (15.391 s) : 15391000, 15391000
. : milestone, 15391000,
tracing (15.193 s) : 15193000, 15193000
. : milestone, 15193000,
|
What Does This Do
Replace FixedSizeStripedLongAdder with LongAdder and add the former to the forbidden api to make it future proof.
Follows a quick jmh bench result:
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]