-
Notifications
You must be signed in to change notification settings - Fork 312
Add downstream HTTP request/response analysis for OkHttp2 client #9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 42 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022229
Total [baseline] (8.677 s) : 0, 8676738
Agent [candidate] (1.027 s) : 0, 1026818
Total [candidate] (8.641 s) : 0, 8640953
section iast
Agent [baseline] (1.162 s) : 0, 1161807
Total [baseline] (9.415 s) : 0, 9414832
Agent [candidate] (1.156 s) : 0, 1156266
Total [candidate] (9.366 s) : 0, 9366401
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (689.435 ms) : 0, 689435
BytebuddyAgent [candidate] (690.484 ms) : 0, 690484
GlobalTracer [baseline] (258.154 ms) : 0, 258154
GlobalTracer [candidate] (259.719 ms) : 0, 259719
AppSec [baseline] (31.743 ms) : 0, 31743
AppSec [candidate] (33.48 ms) : 0, 33480
Debugger [baseline] (6.341 ms) : 0, 6341
Debugger [candidate] (6.432 ms) : 0, 6432
Remote Config [baseline] (706.107 µs) : 0, 706
Remote Config [candidate] (722.51 µs) : 0, 723
Telemetry [baseline] (13.381 ms) : 0, 13381
Telemetry [candidate] (13.37 ms) : 0, 13370
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (814.318 ms) : 0, 814318
BytebuddyAgent [candidate] (808.17 ms) : 0, 808170
GlobalTracer [baseline] (250.837 ms) : 0, 250837
GlobalTracer [candidate] (250.116 ms) : 0, 250116
IAST [baseline] (28.432 ms) : 0, 28432
IAST [candidate] (32.498 ms) : 0, 32498
AppSec [baseline] (30.791 ms) : 0, 30791
AppSec [candidate] (27.328 ms) : 0, 27328
Debugger [baseline] (6.03 ms) : 0, 6030
Debugger [candidate] (7.012 ms) : 0, 7012
Remote Config [baseline] (597.323 µs) : 0, 597
Remote Config [candidate] (693.114 µs) : 0, 693
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.076 ms) : 0, 8076
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022480
Total [baseline] (10.76 s) : 0, 10760356
Agent [candidate] (1.021 s) : 0, 1021225
Total [candidate] (10.685 s) : 0, 10685365
section appsec
Agent [baseline] (1.198 s) : 0, 1197580
Total [baseline] (11.039 s) : 0, 11039479
Agent [candidate] (1.208 s) : 0, 1207669
Total [candidate] (11.065 s) : 0, 11065385
section iast
Agent [baseline] (1.153 s) : 0, 1153197
Total [baseline] (11.11 s) : 0, 11110178
Agent [candidate] (1.156 s) : 0, 1155810
Total [candidate] (11.035 s) : 0, 11034663
section profiling
Agent [baseline] (1.17 s) : 0, 1170428
Total [baseline] (11.053 s) : 0, 11052652
Agent [candidate] (1.167 s) : 0, 1167366
Total [candidate] (11.027 s) : 0, 11026643
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (690.418 ms) : 0, 690418
BytebuddyAgent [candidate] (685.763 ms) : 0, 685763
GlobalTracer [baseline] (260.088 ms) : 0, 260088
GlobalTracer [candidate] (258.453 ms) : 0, 258453
AppSec [baseline] (31.837 ms) : 0, 31837
AppSec [candidate] (33.449 ms) : 0, 33449
Debugger [baseline] (6.398 ms) : 0, 6398
Debugger [candidate] (6.356 ms) : 0, 6356
Remote Config [baseline] (686.133 µs) : 0, 686
Remote Config [candidate] (728.025 µs) : 0, 728
Telemetry [baseline] (10.423 ms) : 0, 10423
Telemetry [candidate] (13.902 ms) : 0, 13902
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (710.881 ms) : 0, 710881
BytebuddyAgent [candidate] (715.653 ms) : 0, 715653
GlobalTracer [baseline] (251.435 ms) : 0, 251435
GlobalTracer [candidate] (253.889 ms) : 0, 253889
AppSec [baseline] (170.912 ms) : 0, 170912
AppSec [candidate] (174.131 ms) : 0, 174131
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.113 ms) : 0, 6113
Remote Config [baseline] (620.442 µs) : 0, 620
Remote Config [candidate] (666.664 µs) : 0, 667
Telemetry [baseline] (9.952 ms) : 0, 9952
Telemetry [candidate] (9.167 ms) : 0, 9167
IAST [baseline] (25.028 ms) : 0, 25028
IAST [candidate] (25.348 ms) : 0, 25348
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (807.476 ms) : 0, 807476
BytebuddyAgent [candidate] (808.094 ms) : 0, 808094
GlobalTracer [baseline] (249.187 ms) : 0, 249187
GlobalTracer [candidate] (249.728 ms) : 0, 249728
AppSec [baseline] (27.231 ms) : 0, 27231
AppSec [candidate] (30.519 ms) : 0, 30519
Debugger [baseline] (6.952 ms) : 0, 6952
Debugger [candidate] (6.137 ms) : 0, 6137
Remote Config [baseline] (684.298 µs) : 0, 684
Remote Config [candidate] (605.103 µs) : 0, 605
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.247 ms) : 0, 8247
IAST [baseline] (30.945 ms) : 0, 30945
IAST [candidate] (29.955 ms) : 0, 29955
section profiling
ProfilingAgent [baseline] (102.505 ms) : 0, 102505
ProfilingAgent [candidate] (101.22 ms) : 0, 101220
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (721.728 ms) : 0, 721728
BytebuddyAgent [candidate] (719.372 ms) : 0, 719372
GlobalTracer [baseline] (238.09 ms) : 0, 238090
GlobalTracer [candidate] (237.204 ms) : 0, 237204
AppSec [baseline] (31.414 ms) : 0, 31414
AppSec [candidate] (32.927 ms) : 0, 32927
Debugger [baseline] (6.575 ms) : 0, 6575
Debugger [candidate] (6.508 ms) : 0, 6508
Remote Config [baseline] (729.924 µs) : 0, 730
Remote Config [candidate] (848.774 µs) : 0, 849
Telemetry [baseline] (16.554 ms) : 0, 16554
Telemetry [candidate] (16.58 ms) : 0, 16580
Profiling [baseline] (103.099 ms) : 0, 103099
Profiling [candidate] (101.817 ms) : 0, 101817
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (4.26 ms) : 4214, 4306
. : milestone, 4260,
iast (9.669 ms) : 9502, 9836
. : milestone, 9669,
iast_FULL (15.702 ms) : 15387, 16017
. : milestone, 15702,
iast_GLOBAL (10.636 ms) : 10445, 10827
. : milestone, 10636,
profiling (8.586 ms) : 8453, 8718
. : milestone, 8586,
tracing (7.927 ms) : 7813, 8041
. : milestone, 7927,
section candidate
no_agent (4.372 ms) : 4323, 4422
. : milestone, 4372,
iast (9.559 ms) : 9394, 9724
. : milestone, 9559,
iast_FULL (14.089 ms) : 13808, 14370
. : milestone, 14089,
iast_GLOBAL (10.75 ms) : 10557, 10942
. : milestone, 10750,
profiling (9.402 ms) : 9256, 9549
. : milestone, 9402,
tracing (7.759 ms) : 7649, 7869
. : milestone, 7759,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (37.278 ms) : 36976, 37581
. : milestone, 37278,
appsec (50.635 ms) : 50179, 51092
. : milestone, 50635,
code_origins (45.213 ms) : 44837, 45589
. : milestone, 45213,
iast (45.389 ms) : 45000, 45778
. : milestone, 45389,
profiling (49.661 ms) : 49147, 50175
. : milestone, 49661,
tracing (43.763 ms) : 43390, 44136
. : milestone, 43763,
section candidate
no_agent (37.057 ms) : 36752, 37362
. : milestone, 37057,
appsec (49.018 ms) : 48600, 49436
. : milestone, 49018,
code_origins (45.034 ms) : 44646, 45423
. : milestone, 45034,
iast (45.571 ms) : 45173, 45969
. : milestone, 45571,
profiling (50.597 ms) : 50023, 51171
. : milestone, 50597,
tracing (45.018 ms) : 44624, 45413
. : milestone, 45018,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (15.531 s) : 15531000, 15531000
. : milestone, 15531000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.438 s) : 18438000, 18438000
. : milestone, 18438000,
iast_GLOBAL (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
profiling (15.763 s) : 15763000, 15763000
. : milestone, 15763000,
tracing (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
section candidate
no_agent (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
appsec (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
iast (18.706 s) : 18706000, 18706000
. : milestone, 18706000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
tracing (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~1dae6dc5b2, baseline=1.54.0-SNAPSHOT~abb87aba78
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.512 ms) : 2459, 2566
. : milestone, 2512,
iast (2.207 ms) : 2143, 2271
. : milestone, 2207,
iast_GLOBAL (2.251 ms) : 2187, 2315
. : milestone, 2251,
profiling (2.06 ms) : 2008, 2111
. : milestone, 2060,
tracing (2.035 ms) : 1985, 2084
. : milestone, 2035,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.516 ms) : 2464, 2569
. : milestone, 2516,
iast (2.213 ms) : 2149, 2276
. : milestone, 2213,
iast_GLOBAL (2.256 ms) : 2192, 2320
. : milestone, 2256,
profiling (2.058 ms) : 2007, 2109
. : milestone, 2058,
tracing (2.029 ms) : 1980, 2079
. : milestone, 2029,
|
e10c32e
to
094375b
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
094375b
to
fe39167
Compare
fe39167
to
1dae6dc
Compare
What Does This Do
Adds support for downstream HTTP request and response analysis in the OkHttp2 client instrumentation.
Motivation
Enable AppSec to analyze outbound requests made through OkHttp2. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.
Additional Notes
RFC
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58613