Prevent using v1/input endpoint for snapshots #9573

jpbempel · 2025-09-19T16:41:03Z

What Does This Do

snapshots should always send to DEBUGGER track through v2/input or v1/diagnostics endpoints. v1/input is unredacted.
v1/diagnostics endpoint was introduced since DD agent 7.49

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-4522

snapshots should always send to DEBUGGER track through v2/input or v1/diagnostics endpoints. v1/input is unredacted. v1/diagnostics endpoint was introduced since DD agent 7.49

github-actions · 2025-09-19T16:41:23Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-09-19T17:00:22Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1758305383	1758305729
end_time	2025-09-19T18:11:04	2025-09-19T18:16:48
git_branch	master	jpbempel/no-v1-input-snapshot
git_commit_sha	`abb87ab`	`3c857de`
start_time	2025-09-19T18:09:44	2025-09-19T18:15:30

See matching parameters

	Baseline	Candidate
ci_job_id	1139018430	1139018430
ci_pipeline_id	77022583	77022583
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1758304699	1758304699

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 8 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-32.294µs; +3.654µs] or [-11.406%; +1.291%]	unstable [-44.074µs; +14.076µs] or [-13.661%; +4.363%]	unstable [-54.888µs; +23.541µs] or [-16.305%; +6.993%]	unstable [-188.675µs; +13.049µs] or [-19.655%; +1.359%]	same
scenario:basic	same	unstable [-17.064µs; +11.398µs] or [-6.006%; +4.012%]	unstable [-17449.743ns; +16117.374ns] or [-5.949%; +5.494%]	unstable [-101.418µs; +227.699µs] or [-13.261%; +29.773%]	unstable [-196.818op/s; +196.818op/s] or [-7.479%; +7.479%]
scenario:loop	unsure [-15.215µs; -7.665µs] or [-0.171%; -0.086%]	unsure [-18.223µs; -6.779µs] or [-0.203%; -0.076%]	same	same	same

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (322.614 µs) : 290, 355
.   : milestone, 323,
basic (284.1 µs) : 278, 291
.   : milestone, 284,
loop (8.97 ms) : 8965, 8975
.   : milestone, 8970,
section candidate
noprobe (307.616 µs) : 286, 330
.   : milestone, 308,
basic (281.267 µs) : 263, 300
.   : milestone, 281,
loop (8.957 ms) : 8952, 8963
.   : milestone, 8957,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	322.614 µs [290.29 µs, 354.939 µs]
basic	284.1 µs [277.52 µs, 290.679 µs]
loop	8.97 ms [8.965 ms, 8.975 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	307.616 µs [285.525 µs, 329.706 µs]
basic	281.267 µs [262.681 µs, 299.852 µs]
loop	8.957 ms [8.952 ms, 8.963 ms]

datadog-datadog-prod-us1 · 2025-09-19T17:03:01Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.39% (-0.38%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 3c857de | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-09-19T17:14:49Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/no-v1-input-snapshot
git_commit_date	1758286417	1758304699
git_commit_sha	`abb87ab`	`3c857de`
release_version	1.54.0-SNAPSHOT~abb87aba78	1.54.0-SNAPSHOT~3c857de5a9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758306660	1758306660
ci_job_id	1139018411	1139018411
ci_pipeline_id	77022583	77022583
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-objl9na5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-objl9na5 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022213
Total [baseline] (8.643 s) : 0, 8643291
Agent [candidate] (1.02 s) : 0, 1020211
Total [candidate] (8.658 s) : 0, 8658069
section iast
Agent [baseline] (1.163 s) : 0, 1162958
Total [baseline] (9.461 s) : 0, 9461313
Agent [candidate] (1.169 s) : 0, 1169217
Total [candidate] (9.414 s) : 0, 9413817

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.022 s	-
Agent	iast	1.163 s	140.745 ms (13.8%)
Total	tracing	8.643 s	-
Total	iast	9.461 s	818.023 ms (9.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.169 s	149.006 ms (14.6%)
Total	tracing	8.658 s	-
Total	iast	9.414 s	755.748 ms (8.7%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (688.076 ms) : 0, 688076
BytebuddyAgent [candidate] (688.008 ms) : 0, 688008
GlobalTracer [baseline] (258.716 ms) : 0, 258716
GlobalTracer [candidate] (259.175 ms) : 0, 259175
AppSec [baseline] (31.698 ms) : 0, 31698
AppSec [candidate] (31.629 ms) : 0, 31629
Debugger [baseline] (6.353 ms) : 0, 6353
Debugger [candidate] (6.37 ms) : 0, 6370
Remote Config [baseline] (687.301 µs) : 0, 687
Remote Config [candidate] (680.393 µs) : 0, 680
Telemetry [baseline] (14.165 ms) : 0, 14165
Telemetry [candidate] (11.876 ms) : 0, 11876
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (815.019 ms) : 0, 815019
BytebuddyAgent [candidate] (819.302 ms) : 0, 819302
GlobalTracer [baseline] (251.194 ms) : 0, 251194
GlobalTracer [candidate] (252.535 ms) : 0, 252535
AppSec [baseline] (31.456 ms) : 0, 31456
AppSec [candidate] (30.142 ms) : 0, 30142
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (599.451 µs) : 0, 599
Remote Config [candidate] (597.505 µs) : 0, 598
Telemetry [baseline] (8.208 ms) : 0, 8208
Telemetry [candidate] (8.252 ms) : 0, 8252
IAST [baseline] (27.731 ms) : 0, 27731
IAST [candidate] (29.606 ms) : 0, 29606

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021225
Total [baseline] (10.741 s) : 0, 10741283
Agent [candidate] (1.019 s) : 0, 1019350
Total [candidate] (10.702 s) : 0, 10702247
section appsec
Agent [baseline] (1.205 s) : 0, 1205171
Total [baseline] (11.03 s) : 0, 11029935
Agent [candidate] (1.196 s) : 0, 1196224
Total [candidate] (11.109 s) : 0, 11109088
section iast
Agent [baseline] (1.17 s) : 0, 1170060
Total [baseline] (11.051 s) : 0, 11050694
Agent [candidate] (1.157 s) : 0, 1156842
Total [candidate] (11.094 s) : 0, 11093783
section profiling
Agent [baseline] (1.174 s) : 0, 1174353
Total [baseline] (11.137 s) : 0, 11136674
Agent [candidate] (1.171 s) : 0, 1171098
Total [candidate] (11.082 s) : 0, 11082415

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.205 s	183.945 ms (18.0%)
Agent	iast	1.17 s	148.835 ms (14.6%)
Agent	profiling	1.174 s	153.128 ms (15.0%)
Total	tracing	10.741 s	-
Total	appsec	11.03 s	288.652 ms (2.7%)
Total	iast	11.051 s	309.411 ms (2.9%)
Total	profiling	11.137 s	395.391 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.019 s	-
Agent	appsec	1.196 s	176.874 ms (17.4%)
Agent	iast	1.157 s	137.492 ms (13.5%)
Agent	profiling	1.171 s	151.748 ms (14.9%)
Total	tracing	10.702 s	-
Total	appsec	11.109 s	406.841 ms (3.8%)
Total	iast	11.094 s	391.536 ms (3.7%)
Total	profiling	11.082 s	380.168 ms (3.6%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.46 ms) : 0, 1460
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (687.633 ms) : 0, 687633
BytebuddyAgent [candidate] (685.685 ms) : 0, 685685
GlobalTracer [baseline] (258.849 ms) : 0, 258849
GlobalTracer [candidate] (258.491 ms) : 0, 258491
AppSec [baseline] (31.683 ms) : 0, 31683
AppSec [candidate] (31.6 ms) : 0, 31600
Debugger [baseline] (6.359 ms) : 0, 6359
Debugger [candidate] (6.335 ms) : 0, 6335
Remote Config [baseline] (688.939 µs) : 0, 689
Remote Config [candidate] (688.655 µs) : 0, 689
Telemetry [baseline] (13.442 ms) : 0, 13442
Telemetry [candidate] (14.082 ms) : 0, 14082
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (716.976 ms) : 0, 716976
BytebuddyAgent [candidate] (710.223 ms) : 0, 710223
GlobalTracer [baseline] (252.567 ms) : 0, 252567
GlobalTracer [candidate] (251.026 ms) : 0, 251026
AppSec [baseline] (170.685 ms) : 0, 170685
AppSec [candidate] (172.334 ms) : 0, 172334
Debugger [baseline] (6.824 ms) : 0, 6824
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (615.157 µs) : 0, 615
Remote Config [candidate] (619.018 µs) : 0, 619
Telemetry [baseline] (9.881 ms) : 0, 9881
Telemetry [candidate] (8.402 ms) : 0, 8402
IAST [baseline] (24.836 ms) : 0, 24836
IAST [candidate] (24.994 ms) : 0, 24994
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (820.994 ms) : 0, 820994
BytebuddyAgent [candidate] (810.487 ms) : 0, 810487
GlobalTracer [baseline] (252.133 ms) : 0, 252133
GlobalTracer [candidate] (250.036 ms) : 0, 250036
AppSec [baseline] (29.132 ms) : 0, 29132
AppSec [candidate] (28.091 ms) : 0, 28091
Debugger [baseline] (6.096 ms) : 0, 6096
Debugger [candidate] (6.11 ms) : 0, 6110
Remote Config [baseline] (612.592 µs) : 0, 613
Remote Config [candidate] (604.181 µs) : 0, 604
Telemetry [baseline] (8.23 ms) : 0, 8230
Telemetry [candidate] (8.109 ms) : 0, 8109
IAST [baseline] (30.128 ms) : 0, 30128
IAST [candidate] (30.875 ms) : 0, 30875
section profiling
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (724.839 ms) : 0, 724839
BytebuddyAgent [candidate] (724.18 ms) : 0, 724180
GlobalTracer [baseline] (238.682 ms) : 0, 238682
GlobalTracer [candidate] (236.915 ms) : 0, 236915
AppSec [baseline] (31.56 ms) : 0, 31560
AppSec [candidate] (31.26 ms) : 0, 31260
Debugger [baseline] (6.628 ms) : 0, 6628
Debugger [candidate] (6.595 ms) : 0, 6595
Remote Config [baseline] (711.614 µs) : 0, 712
Remote Config [candidate] (698.343 µs) : 0, 698
Telemetry [baseline] (16.606 ms) : 0, 16606
Telemetry [candidate] (16.428 ms) : 0, 16428
ProfilingAgent [baseline] (102.663 ms) : 0, 102663
ProfilingAgent [candidate] (101.993 ms) : 0, 101993
Profiling [baseline] (103.27 ms) : 0, 103270
Profiling [candidate] (102.589 ms) : 0, 102589

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/no-v1-input-snapshot
git_commit_date	1758286417	1758304699
git_commit_sha	`abb87ab`	`3c857de`
release_version	1.54.0-SNAPSHOT~abb87aba78	1.54.0-SNAPSHOT~3c857de5a9

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1758306322	1758306322
ci_job_id	1139018413	1139018413
ci_pipeline_id	77022583	77022583
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-ahfx743d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-ahfx743d 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:no_agent:high_load	better [-1.427ms; -0.782ms] or [-3.767%; -2.066%]	unstable [-5.424op/s; +12.774op/s] or [-4.393%; +10.347%]	36.769ms	127.138op/s	37.873ms	123.463op/s
scenario:load:petclinic:code_origins:high_load	better [-2.970ms; -2.108ms] or [-6.333%; -4.496%]	unstable [-1.902op/s; +13.302op/s] or [-1.907%; +13.332%]	44.357ms	105.475op/s	46.897ms	99.775op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.873 ms) : 37572, 38174
.   : milestone, 37873,
appsec (49.649 ms) : 49197, 50101
.   : milestone, 49649,
code_origins (46.897 ms) : 46478, 47316
.   : milestone, 46897,
iast (45.889 ms) : 45478, 46301
.   : milestone, 45889,
profiling (48.416 ms) : 47935, 48897
.   : milestone, 48416,
tracing (44.641 ms) : 44269, 45014
.   : milestone, 44641,
section candidate
no_agent (36.769 ms) : 36471, 37067
.   : milestone, 36769,
appsec (48.724 ms) : 48275, 49173
.   : milestone, 48724,
code_origins (44.357 ms) : 43976, 44739
.   : milestone, 44357,
iast (46.373 ms) : 45967, 46778
.   : milestone, 46373,
profiling (49.428 ms) : 48948, 49908
.   : milestone, 49428,
tracing (44.662 ms) : 44287, 45037
.   : milestone, 44662,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.873 ms [37.572 ms, 38.174 ms]	-
appsec	49.649 ms [49.197 ms, 50.101 ms]	11.776 ms (31.1%)
code_origins	46.897 ms [46.478 ms, 47.316 ms]	9.024 ms (23.8%)
iast	45.889 ms [45.478 ms, 46.301 ms]	8.016 ms (21.2%)
profiling	48.416 ms [47.935 ms, 48.897 ms]	10.543 ms (27.8%)
tracing	44.641 ms [44.269 ms, 45.014 ms]	6.768 ms (17.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.769 ms [36.471 ms, 37.067 ms]	-
appsec	48.724 ms [48.275 ms, 49.173 ms]	11.956 ms (32.5%)
code_origins	44.357 ms [43.976 ms, 44.739 ms]	7.589 ms (20.6%)
iast	46.373 ms [45.967 ms, 46.778 ms]	9.604 ms (26.1%)
profiling	49.428 ms [48.948 ms, 49.908 ms]	12.66 ms (34.4%)
tracing	44.662 ms [44.287 ms, 45.037 ms]	7.893 ms (21.5%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.352 ms) : 4304, 4401
.   : milestone, 4352,
iast (9.918 ms) : 9751, 10085
.   : milestone, 9918,
iast_FULL (14.259 ms) : 13977, 14542
.   : milestone, 14259,
iast_GLOBAL (10.821 ms) : 10627, 11015
.   : milestone, 10821,
profiling (8.774 ms) : 8639, 8909
.   : milestone, 8774,
tracing (7.796 ms) : 7677, 7916
.   : milestone, 7796,
section candidate
no_agent (4.414 ms) : 4363, 4464
.   : milestone, 4414,
iast (9.712 ms) : 9552, 9873
.   : milestone, 9712,
iast_FULL (14.012 ms) : 13733, 14290
.   : milestone, 14012,
iast_GLOBAL (10.97 ms) : 10778, 11163
.   : milestone, 10970,
profiling (8.811 ms) : 8670, 8952
.   : milestone, 8811,
tracing (7.843 ms) : 7729, 7957
.   : milestone, 7843,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.352 ms [4.304 ms, 4.401 ms]	-
iast	9.918 ms [9.751 ms, 10.085 ms]	5.566 ms (127.9%)
iast_FULL	14.259 ms [13.977 ms, 14.542 ms]	9.907 ms (227.6%)
iast_GLOBAL	10.821 ms [10.627 ms, 11.015 ms]	6.469 ms (148.6%)
profiling	8.774 ms [8.639 ms, 8.909 ms]	4.422 ms (101.6%)
tracing	7.796 ms [7.677 ms, 7.916 ms]	3.444 ms (79.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.414 ms [4.363 ms, 4.464 ms]	-
iast	9.712 ms [9.552 ms, 9.873 ms]	5.299 ms (120.1%)
iast_FULL	14.012 ms [13.733 ms, 14.29 ms]	9.598 ms (217.5%)
iast_GLOBAL	10.97 ms [10.778 ms, 11.163 ms]	6.557 ms (148.6%)
profiling	8.811 ms [8.67 ms, 8.952 ms]	4.398 ms (99.6%)
tracing	7.843 ms [7.729 ms, 7.957 ms]	3.429 ms (77.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/no-v1-input-snapshot
git_commit_date	1758286417	1758304699
git_commit_sha	`abb87ab`	`3c857de`
release_version	1.54.0-SNAPSHOT~abb87aba78	1.54.0-SNAPSHOT~3c857de5a9

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1758306875	1758306875
ci_job_id	1139018415	1139018415
ci_pipeline_id	77022583	77022583
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-smuzncjh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-smuzncjh 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
appsec (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
iast (18.805 s) : 18805000, 18805000
.   : milestone, 18805000,
iast_GLOBAL (17.964 s) : 17964000, 17964000
.   : milestone, 17964000,
profiling (15.534 s) : 15534000, 15534000
.   : milestone, 15534000,
tracing (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
section candidate
no_agent (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
appsec (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
iast (18.462 s) : 18462000, 18462000
.   : milestone, 18462000,
iast_GLOBAL (18.134 s) : 18134000, 18134000
.   : milestone, 18134000,
profiling (15.247 s) : 15247000, 15247000
.   : milestone, 15247000,
tracing (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.971 s [14.971 s, 14.971 s]	-
appsec	14.874 s [14.874 s, 14.874 s]	-97.0 ms (-0.6%)
iast	18.805 s [18.805 s, 18.805 s]	3.834 s (25.6%)
iast_GLOBAL	17.964 s [17.964 s, 17.964 s]	2.993 s (20.0%)
profiling	15.534 s [15.534 s, 15.534 s]	563.0 ms (3.8%)
tracing	15.273 s [15.273 s, 15.273 s]	302.0 ms (2.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.25 s [15.25 s, 15.25 s]	-
appsec	15.145 s [15.145 s, 15.145 s]	-105.0 ms (-0.7%)
iast	18.462 s [18.462 s, 18.462 s]	3.212 s (21.1%)
iast_GLOBAL	18.134 s [18.134 s, 18.134 s]	2.884 s (18.9%)
profiling	15.247 s [15.247 s, 15.247 s]	-3.0 ms (-0.0%)
tracing	15.063 s [15.063 s, 15.063 s]	-187.0 ms (-1.2%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~3c857de5a9, baseline=1.54.0-SNAPSHOT~abb87aba78
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
.   : milestone, 1481,
appsec (3.712 ms) : 3493, 3932
.   : milestone, 3712,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.251 ms) : 2188, 2315
.   : milestone, 2251,
profiling (2.089 ms) : 2036, 2143
.   : milestone, 2089,
tracing (2.044 ms) : 1994, 2093
.   : milestone, 2044,
section candidate
no_agent (1.492 ms) : 1480, 1503
.   : milestone, 1492,
appsec (3.738 ms) : 3521, 3956
.   : milestone, 3738,
iast (2.227 ms) : 2163, 2290
.   : milestone, 2227,
iast_GLOBAL (2.26 ms) : 2197, 2323
.   : milestone, 2260,
profiling (2.084 ms) : 2032, 2136
.   : milestone, 2084,
tracing (2.047 ms) : 1997, 2096
.   : milestone, 2047,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.47 ms, 1.493 ms]	-
appsec	3.712 ms [3.493 ms, 3.932 ms]	2.231 ms (150.6%)
iast	2.21 ms [2.147 ms, 2.273 ms]	728.269 µs (49.2%)
iast_GLOBAL	2.251 ms [2.188 ms, 2.315 ms]	770.062 µs (52.0%)
profiling	2.089 ms [2.036 ms, 2.143 ms]	607.99 µs (41.0%)
tracing	2.044 ms [1.994 ms, 2.093 ms]	562.238 µs (38.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.492 ms [1.48 ms, 1.503 ms]	-
appsec	3.738 ms [3.521 ms, 3.956 ms]	2.247 ms (150.6%)
iast	2.227 ms [2.163 ms, 2.29 ms]	735.075 µs (49.3%)
iast_GLOBAL	2.26 ms [2.197 ms, 2.323 ms]	768.596 µs (51.5%)
profiling	2.084 ms [2.032 ms, 2.136 ms]	592.134 µs (39.7%)
tracing	2.047 ms [1.997 ms, 2.096 ms]	555.05 µs (37.2%)

Prevent using v1/input endpoint for snapshots

05744f0

snapshots should always send to DEBUGGER track through v2/input or v1/diagnostics endpoints. v1/input is unredacted. v1/diagnostics endpoint was introduced since DD agent 7.49

jpbempel requested review from a team as code owners September 19, 2025 16:41

jpbempel requested review from shatzi and smola and removed request for a team September 19, 2025 16:41

jpbempel added the comp: debugger Dynamic Instrumentation label Sep 19, 2025

jpbempel added the type: enhancement Enhancements and improvements label Sep 19, 2025

shatzi approved these changes Sep 19, 2025

View reviewed changes

fix tests

3c857de

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prevent using v1/input endpoint for snapshots #9573

Prevent using v1/input endpoint for snapshots #9573

Uh oh!

jpbempel commented Sep 19, 2025 •

edited by atlassian bot

Loading

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

pr-commenter bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 19, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Prevent using v1/input endpoint for snapshots #9573

Are you sure you want to change the base?

Prevent using v1/input endpoint for snapshots #9573

Uh oh!

Conversation

jpbempel commented Sep 19, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

pr-commenter bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

datadog-datadog-prod-us1 bot commented Sep 19, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

jpbempel commented Sep 19, 2025 •

edited by atlassian bot

Loading

pr-commenter bot commented Sep 19, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Sep 19, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Sep 19, 2025 •

edited

Loading