Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

cecile75
Copy link
Contributor

@cecile75 cecile75 commented Sep 22, 2025

What Does This Do

Allow the generation of a tracer flare even when tracing is disabled.
Technically: Move the generic tracer flare code out of dd-tracer-core.

Changes in the tracer flare: tracer_health.txt, dynamic_config.txt and span_metrics.txt will be present only if tracing is enabled.

Motivation

We should be able to get a flare even when tracing is not enabled

Additional Notes

APMAPI-1591

@cecile75 cecile75 changed the title Cecile/nonetracerflare Tracer flare - no longer require tracing to be enabled Sep 22, 2025
@cecile75 cecile75 changed the title Tracer flare - no longer require tracing to be enabled Remove tracing requirement to be enabled to generate a flare Sep 22, 2025
@cecile75 cecile75 added comp: tooling Build & Tooling tag: diagnostics Diagnostics related changes type: enhancement Enhancements and improvements and removed tag: diagnostics Diagnostics related changes labels Sep 22, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 22, 2025

🎯 Code Coverage
Patch Coverage: 0.00%
Total Coverage: 59.97% (+0.18%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0802108 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 22, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/nonetracerflare
git_commit_date 1758813010 1758813259
git_commit_sha 050cad8 0802108
release_version 1.54.0-SNAPSHOT~050cad8b0e 1.54.0-SNAPSHOT~0802108d49
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758815211 1758815211
ci_job_id 1147882625 1147882625
ci_pipeline_id 77541932 77541932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-6-lfeeupdm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-6-lfeeupdm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 5 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1008045
Total [baseline] (8.73 s) : 0, 8729563
Agent [candidate] (1.012 s) : 0, 1011757
Total [candidate] (8.647 s) : 0, 8646503
section iast
Agent [baseline] (1.162 s) : 0, 1162353
Total [baseline] (9.353 s) : 0, 9352972
Agent [candidate] (1.145 s) : 0, 1145498
Total [candidate] (9.324 s) : 0, 9324000
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent iast 1.162 s 154.307 ms (15.3%)
Total tracing 8.73 s -
Total iast 9.353 s 623.409 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.012 s -
Agent iast 1.145 s 133.741 ms (13.2%)
Total tracing 8.647 s -
Total iast 9.324 s 677.497 ms (7.8%)
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (690.487 ms) : 0, 690487
BytebuddyAgent [candidate] (688.94 ms) : 0, 688940
GlobalTracer [baseline] (248.111 ms) : 0, 248111
GlobalTracer [candidate] (242.544 ms) : 0, 242544
AppSec [baseline] (30.92 ms) : 0, 30920
AppSec [candidate] (30.991 ms) : 0, 30991
Debugger [baseline] (6.368 ms) : 0, 6368
Debugger [candidate] (6.221 ms) : 0, 6221
Remote Config [baseline] (687.562 µs) : 0, 688
Remote Config [candidate] (667.304 µs) : 0, 667
Telemetry [baseline] (8.856 ms) : 0, 8856
Telemetry [candidate] (9.03 ms) : 0, 9030
Flare Poller [candidate] (10.775 ms) : 0, 10775
section iast
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (823.551 ms) : 0, 823551
BytebuddyAgent [candidate] (810.393 ms) : 0, 810393
GlobalTracer [baseline] (240.288 ms) : 0, 240288
GlobalTracer [candidate] (233.568 ms) : 0, 233568
IAST [baseline] (26.291 ms) : 0, 26291
IAST [candidate] (26.312 ms) : 0, 26312
AppSec [baseline] (34.274 ms) : 0, 34274
AppSec [candidate] (33.581 ms) : 0, 33581
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.032 ms) : 0, 6032
Remote Config [baseline] (594.302 µs) : 0, 594
Remote Config [candidate] (579.674 µs) : 0, 580
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.111 ms) : 0, 8111
Flare Poller [candidate] (4.183 ms) : 0, 4183
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022028
Total [baseline] (10.728 s) : 0, 10727699
Agent [candidate] (1.011 s) : 0, 1010608
Total [candidate] (10.654 s) : 0, 10654364
section appsec
Agent [baseline] (1.199 s) : 0, 1198659
Total [baseline] (11.048 s) : 0, 11047994
Agent [candidate] (1.193 s) : 0, 1193022
Total [candidate] (10.926 s) : 0, 10925780
section iast
Agent [baseline] (1.146 s) : 0, 1145639
Total [baseline] (11.003 s) : 0, 11003147
Agent [candidate] (1.152 s) : 0, 1152359
Total [candidate] (10.985 s) : 0, 10984839
section profiling
Agent [baseline] (1.166 s) : 0, 1166023
Total [baseline] (11.096 s) : 0, 11096151
Agent [candidate] (1.163 s) : 0, 1162657
Total [candidate] (11.144 s) : 0, 11143969
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent appsec 1.199 s 176.631 ms (17.3%)
Agent iast 1.146 s 123.61 ms (12.1%)
Agent profiling 1.166 s 143.995 ms (14.1%)
Total tracing 10.728 s -
Total appsec 11.048 s 320.295 ms (3.0%)
Total iast 11.003 s 275.448 ms (2.6%)
Total profiling 11.096 s 368.452 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.011 s -
Agent appsec 1.193 s 182.414 ms (18.0%)
Agent iast 1.152 s 141.752 ms (14.0%)
Agent profiling 1.163 s 152.05 ms (15.0%)
Total tracing 10.654 s -
Total appsec 10.926 s 271.416 ms (2.5%)
Total iast 10.985 s 330.475 ms (3.1%)
Total profiling 11.144 s 489.605 ms (4.6%)
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (701.901 ms) : 0, 701901
BytebuddyAgent [candidate] (686.589 ms) : 0, 686589
GlobalTracer [baseline] (249.911 ms) : 0, 249911
GlobalTracer [candidate] (243.482 ms) : 0, 243482
AppSec [baseline] (31.15 ms) : 0, 31150
AppSec [candidate] (31.149 ms) : 0, 31149
Debugger [baseline] (6.385 ms) : 0, 6385
Debugger [candidate] (6.326 ms) : 0, 6326
Remote Config [baseline] (725.539 µs) : 0, 726
Remote Config [candidate] (677.625 µs) : 0, 678
Telemetry [baseline] (9.006 ms) : 0, 9006
Telemetry [candidate] (8.936 ms) : 0, 8936
Flare Poller [candidate] (10.733 ms) : 0, 10733
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (719.64 ms) : 0, 719640
BytebuddyAgent [candidate] (715.654 ms) : 0, 715654
GlobalTracer [baseline] (242.438 ms) : 0, 242438
GlobalTracer [candidate] (236.636 ms) : 0, 236636
AppSec [baseline] (172.204 ms) : 0, 172204
AppSec [candidate] (172.994 ms) : 0, 172994
Debugger [baseline] (6.031 ms) : 0, 6031
Debugger [candidate] (6.812 ms) : 0, 6812
Remote Config [baseline] (643.096 µs) : 0, 643
Remote Config [candidate] (652.31 µs) : 0, 652
Telemetry [baseline] (9.979 ms) : 0, 9979
Telemetry [candidate] (8.303 ms) : 0, 8303
Flare Poller [candidate] (3.941 ms) : 0, 3941
IAST [baseline] (24.911 ms) : 0, 24911
IAST [candidate] (25.254 ms) : 0, 25254
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (810.395 ms) : 0, 810395
BytebuddyAgent [candidate] (814.241 ms) : 0, 814241
GlobalTracer [baseline] (237.464 ms) : 0, 237464
GlobalTracer [candidate] (235.089 ms) : 0, 235089
AppSec [baseline] (34.096 ms) : 0, 34096
AppSec [candidate] (34.055 ms) : 0, 34055
Debugger [baseline] (6.003 ms) : 0, 6003
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (592.451 µs) : 0, 592
Remote Config [candidate] (591.368 µs) : 0, 591
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.388 ms) : 0, 8388
Flare Poller [candidate] (4.266 ms) : 0, 4266
IAST [baseline] (25.956 ms) : 0, 25956
IAST [candidate] (26.693 ms) : 0, 26693
section profiling
ProfilingAgent [baseline] (102.117 ms) : 0, 102117
ProfilingAgent [candidate] (103.088 ms) : 0, 103088
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (727.851 ms) : 0, 727851
BytebuddyAgent [candidate] (725.241 ms) : 0, 725241
GlobalTracer [baseline] (225.434 ms) : 0, 225434
GlobalTracer [candidate] (221.26 ms) : 0, 221260
AppSec [baseline] (31.605 ms) : 0, 31605
AppSec [candidate] (32.099 ms) : 0, 32099
Debugger [baseline] (7.367 ms) : 0, 7367
Debugger [candidate] (7.344 ms) : 0, 7344
Remote Config [baseline] (728.551 µs) : 0, 729
Remote Config [candidate] (697.127 µs) : 0, 697
Telemetry [baseline] (15.704 ms) : 0, 15704
Telemetry [candidate] (14.905 ms) : 0, 14905
Flare Poller [candidate] (5.012 ms) : 0, 5012
Profiling [baseline] (103.376 ms) : 0, 103376
Profiling [candidate] (103.699 ms) : 0, 103699
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/nonetracerflare
git_commit_date 1758813010 1758813259
git_commit_sha 050cad8 0802108
release_version 1.54.0-SNAPSHOT~050cad8b0e 1.54.0-SNAPSHOT~0802108d49
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758814877 1758814877
ci_job_id 1147882626 1147882626
ci_pipeline_id 77541932 77541932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ae8fx9zm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ae8fx9zm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 2 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+570.073µs; +995.793µs] or [+5.368%; +9.377%]
unstable
[-83.716op/s; +24.091op/s] or [-19.126%; +5.504%]
11.402ms 407.906op/s 10.620ms 437.719op/s
scenario:load:insecure-bank:tracing:high_load worse
[+178.736µs; +413.164µs] or [+2.371%; +5.480%]
unstable
[-103.397op/s; +57.272op/s] or [-16.833%; +9.324%]
7.835ms 591.188op/s 7.539ms 614.250op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-1294.460µs; -674.104µs] or [-8.754%; -4.559%]
unstable
[-15.861op/s; +60.673op/s] or [-5.032%; +19.250%]
13.802ms 337.594op/s 14.787ms 315.188op/s
scenario:load:petclinic:no_agent:high_load better
[-2.392ms; -1.745ms] or [-6.258%; -4.567%]
unstable
[-1.449op/s; +15.399op/s] or [-1.184%; +12.587%]
36.147ms 129.312op/s 38.216ms 122.338op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.216 ms) : 37902, 38530
.   : milestone, 38216,
appsec (49.268 ms) : 48833, 49703
.   : milestone, 49268,
code_origins (43.593 ms) : 43220, 43966
.   : milestone, 43593,
iast (45.596 ms) : 45202, 45990
.   : milestone, 45596,
profiling (48.581 ms) : 48131, 49031
.   : milestone, 48581,
tracing (45.255 ms) : 44850, 45661
.   : milestone, 45255,
section candidate
no_agent (36.147 ms) : 35862, 36433
.   : milestone, 36147,
appsec (49.865 ms) : 49418, 50312
.   : milestone, 49865,
code_origins (43.794 ms) : 43433, 44155
.   : milestone, 43794,
iast (46.14 ms) : 45747, 46534
.   : milestone, 46140,
profiling (47.862 ms) : 47419, 48305
.   : milestone, 47862,
tracing (45.497 ms) : 45111, 45882
.   : milestone, 45497,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.216 ms [37.902 ms, 38.53 ms] -
appsec 49.268 ms [48.833 ms, 49.703 ms] 11.052 ms (28.9%)
code_origins 43.593 ms [43.22 ms, 43.966 ms] 5.377 ms (14.1%)
iast 45.596 ms [45.202 ms, 45.99 ms] 7.38 ms (19.3%)
profiling 48.581 ms [48.131 ms, 49.031 ms] 10.365 ms (27.1%)
tracing 45.255 ms [44.85 ms, 45.661 ms] 7.039 ms (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.147 ms [35.862 ms, 36.433 ms] -
appsec 49.865 ms [49.418 ms, 50.312 ms] 13.718 ms (37.9%)
code_origins 43.794 ms [43.433 ms, 44.155 ms] 7.646 ms (21.2%)
iast 46.14 ms [45.747 ms, 46.534 ms] 9.993 ms (27.6%)
profiling 47.862 ms [47.419 ms, 48.305 ms] 11.715 ms (32.4%)
tracing 45.497 ms [45.111 ms, 45.882 ms] 9.349 ms (25.9%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.336 ms) : 4282, 4391
.   : milestone, 4336,
iast (10.502 ms) : 10324, 10681
.   : milestone, 10502,
iast_FULL (14.787 ms) : 14490, 15084
.   : milestone, 14787,
iast_GLOBAL (10.62 ms) : 10430, 10809
.   : milestone, 10620,
profiling (8.807 ms) : 8663, 8951
.   : milestone, 8807,
tracing (7.539 ms) : 7432, 7646
.   : milestone, 7539,
section candidate
no_agent (4.266 ms) : 4219, 4312
.   : milestone, 4266,
iast (10.474 ms) : 10293, 10655
.   : milestone, 10474,
iast_FULL (13.802 ms) : 13523, 14082
.   : milestone, 13802,
iast_GLOBAL (11.402 ms) : 11197, 11608
.   : milestone, 11402,
profiling (8.588 ms) : 8456, 8719
.   : milestone, 8588,
tracing (7.835 ms) : 7724, 7946
.   : milestone, 7835,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.336 ms [4.282 ms, 4.391 ms] -
iast 10.502 ms [10.324 ms, 10.681 ms] 6.166 ms (142.2%)
iast_FULL 14.787 ms [14.49 ms, 15.084 ms] 10.45 ms (241.0%)
iast_GLOBAL 10.62 ms [10.43 ms, 10.809 ms] 6.283 ms (144.9%)
profiling 8.807 ms [8.663 ms, 8.951 ms] 4.471 ms (103.1%)
tracing 7.539 ms [7.432 ms, 7.646 ms] 3.203 ms (73.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.266 ms [4.219 ms, 4.312 ms] -
iast 10.474 ms [10.293 ms, 10.655 ms] 6.209 ms (145.5%)
iast_FULL 13.802 ms [13.523 ms, 14.082 ms] 9.537 ms (223.6%)
iast_GLOBAL 11.402 ms [11.197 ms, 11.608 ms] 7.137 ms (167.3%)
profiling 8.588 ms [8.456 ms, 8.719 ms] 4.322 ms (101.3%)
tracing 7.835 ms [7.724 ms, 7.946 ms] 3.569 ms (83.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/nonetracerflare
git_commit_date 1758813010 1758813259
git_commit_sha 050cad8 0802108
release_version 1.54.0-SNAPSHOT~050cad8b0e 1.54.0-SNAPSHOT~0802108d49
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1758815527 1758815527
ci_job_id 1147882627 1147882627
ci_pipeline_id 77541932 77541932
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-vxu9ofwa 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-vxu9ofwa 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1487
.   : milestone, 1475,
appsec (3.655 ms) : 3440, 3869
.   : milestone, 3655,
iast (2.204 ms) : 2141, 2267
.   : milestone, 2204,
iast_GLOBAL (2.245 ms) : 2182, 2308
.   : milestone, 2245,
profiling (2.483 ms) : 2310, 2657
.   : milestone, 2483,
tracing (2.016 ms) : 1967, 2065
.   : milestone, 2016,
section candidate
no_agent (1.483 ms) : 1471, 1494
.   : milestone, 1483,
appsec (3.65 ms) : 3435, 3864
.   : milestone, 3650,
iast (2.21 ms) : 2147, 2273
.   : milestone, 2210,
iast_GLOBAL (2.253 ms) : 2190, 2317
.   : milestone, 2253,
profiling (2.079 ms) : 2026, 2131
.   : milestone, 2079,
tracing (2.032 ms) : 1982, 2082
.   : milestone, 2032,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.487 ms] -
appsec 3.655 ms [3.44 ms, 3.869 ms] 2.18 ms (147.8%)
iast 2.204 ms [2.141 ms, 2.267 ms] 729.221 µs (49.4%)
iast_GLOBAL 2.245 ms [2.182 ms, 2.308 ms] 769.774 µs (52.2%)
profiling 2.483 ms [2.31 ms, 2.657 ms] 1.009 ms (68.4%)
tracing 2.016 ms [1.967 ms, 2.065 ms] 540.839 µs (36.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.483 ms [1.471 ms, 1.494 ms] -
appsec 3.65 ms [3.435 ms, 3.864 ms] 2.167 ms (146.1%)
iast 2.21 ms [2.147 ms, 2.273 ms] 727.006 µs (49.0%)
iast_GLOBAL 2.253 ms [2.19 ms, 2.317 ms] 770.69 µs (52.0%)
profiling 2.079 ms [2.026 ms, 2.131 ms] 596.132 µs (40.2%)
tracing 2.032 ms [1.982 ms, 2.082 ms] 549.461 µs (37.1%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~0802108d49, baseline=1.54.0-SNAPSHOT~050cad8b0e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.381 s) : 15381000, 15381000
.   : milestone, 15381000,
appsec (14.94 s) : 14940000, 14940000
.   : milestone, 14940000,
iast (18.492 s) : 18492000, 18492000
.   : milestone, 18492000,
iast_GLOBAL (17.651 s) : 17651000, 17651000
.   : milestone, 17651000,
profiling (15.324 s) : 15324000, 15324000
.   : milestone, 15324000,
tracing (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,
section candidate
no_agent (15.521 s) : 15521000, 15521000
.   : milestone, 15521000,
appsec (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,
iast (18.593 s) : 18593000, 18593000
.   : milestone, 18593000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
.   : milestone, 18052000,
profiling (15.454 s) : 15454000, 15454000
.   : milestone, 15454000,
tracing (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.381 s [15.381 s, 15.381 s] -
appsec 14.94 s [14.94 s, 14.94 s] -441.0 ms (-2.9%)
iast 18.492 s [18.492 s, 18.492 s] 3.111 s (20.2%)
iast_GLOBAL 17.651 s [17.651 s, 17.651 s] 2.27 s (14.8%)
profiling 15.324 s [15.324 s, 15.324 s] -57.0 ms (-0.4%)
tracing 15.177 s [15.177 s, 15.177 s] -204.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.521 s [15.521 s, 15.521 s] -
appsec 14.91 s [14.91 s, 14.91 s] -611.0 ms (-3.9%)
iast 18.593 s [18.593 s, 18.593 s] 3.072 s (19.8%)
iast_GLOBAL 18.052 s [18.052 s, 18.052 s] 2.531 s (16.3%)
profiling 15.454 s [15.454 s, 15.454 s] -67.0 ms (-0.4%)
tracing 14.986 s [14.986 s, 14.986 s] -535.0 ms (-3.4%)

@cecile75 cecile75 marked this pull request as ready for review September 24, 2025 08:51
@cecile75 cecile75 requested a review from a team as a code owner September 24, 2025 08:51
@cecile75 cecile75 requested a review from amarziali September 24, 2025 08:51
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having extracted this part. The proposed change looks ok. I left some comments. I'd particularly like to flesh out the part around the CoreTracerBuilder since we might still want to disable the flare

Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 suggestion: ‏Can you move the new module under :utils (like the recently moved config) please?

📝 notes: What about moving tracer flare testing also to this new module?

@PerfectSlayer PerfectSlayer added comp: core Tracer core type: refactoring and removed comp: tooling Build & Tooling type: enhancement Enhancements and improvements labels Sep 25, 2025
@cecile75 cecile75 requested a review from amarziali September 25, 2025 12:58
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having improved the flare and for having addressed the comments

@cecile75 cecile75 merged commit 8f47b66 into master Sep 26, 2025
541 checks passed
@cecile75 cecile75 deleted the cecile/nonetracerflare branch September 26, 2025 08:22
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants