-
Notifications
You must be signed in to change notification settings - Fork 312
Introduce one undiscovered state for featuresDiscovery #9605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Override | ||
public boolean active() { | ||
return supportsMetrics() && discoveryState.supportsDropping; | ||
return supportsMetrics() && discoveryState.isSupportsLongRunning(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's an error -> to be changed
plugins { | ||
`java-library` | ||
id("supported-config-generator") | ||
// id("supported-config-generator") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be removed
🎯 Code Coverage 🔗 Commit SHA: 8a31509 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014148
Total [baseline] (10.752 s) : 0, 10751907
Agent [candidate] (1.006 s) : 0, 1006036
Total [candidate] (10.793 s) : 0, 10792580
section appsec
Agent [baseline] (1.19 s) : 0, 1189613
Total [baseline] (10.926 s) : 0, 10925532
Agent [candidate] (1.193 s) : 0, 1193347
Total [candidate] (11.105 s) : 0, 11104913
section iast
Agent [baseline] (1.148 s) : 0, 1148462
Total [baseline] (10.917 s) : 0, 10917298
Agent [candidate] (1.16 s) : 0, 1159810
Total [candidate] (11.081 s) : 0, 11081160
section profiling
Agent [baseline] (1.152 s) : 0, 1152020
Total [baseline] (11.026 s) : 0, 11025612
Agent [candidate] (1.153 s) : 0, 1153426
Total [candidate] (10.967 s) : 0, 10966593
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (694.259 ms) : 0, 694259
BytebuddyAgent [candidate] (689.582 ms) : 0, 689582
GlobalTracer [baseline] (249.878 ms) : 0, 249878
GlobalTracer [candidate] (245.963 ms) : 0, 245963
AppSec [baseline] (31.15 ms) : 0, 31150
AppSec [candidate] (31.184 ms) : 0, 31184
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.835 ms) : 0, 6835
Remote Config [baseline] (698.782 µs) : 0, 699
Remote Config [candidate] (697.643 µs) : 0, 698
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.965 ms) : 0, 8965
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (713.852 ms) : 0, 713852
BytebuddyAgent [candidate] (716.399 ms) : 0, 716399
GlobalTracer [baseline] (240.437 ms) : 0, 240437
GlobalTracer [candidate] (240.068 ms) : 0, 240068
IAST [baseline] (24.805 ms) : 0, 24805
IAST [candidate] (24.555 ms) : 0, 24555
AppSec [baseline] (171.904 ms) : 0, 171904
AppSec [candidate] (170.508 ms) : 0, 170508
Debugger [baseline] (6.797 ms) : 0, 6797
Debugger [candidate] (6.095 ms) : 0, 6095
Remote Config [baseline] (642.491 µs) : 0, 642
Remote Config [candidate] (652.122 µs) : 0, 652
Telemetry [baseline] (8.458 ms) : 0, 8458
Telemetry [candidate] (12.317 ms) : 0, 12317
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (812.088 ms) : 0, 812088
BytebuddyAgent [candidate] (822.49 ms) : 0, 822490
GlobalTracer [baseline] (238.127 ms) : 0, 238127
GlobalTracer [candidate] (239.161 ms) : 0, 239161
IAST [baseline] (26.268 ms) : 0, 26268
IAST [candidate] (26.388 ms) : 0, 26388
AppSec [baseline] (33.841 ms) : 0, 33841
AppSec [candidate] (33.699 ms) : 0, 33699
Debugger [baseline] (6.079 ms) : 0, 6079
Debugger [candidate] (6.097 ms) : 0, 6097
Remote Config [baseline] (595.84 µs) : 0, 596
Remote Config [candidate] (592.181 µs) : 0, 592
Telemetry [baseline] (8.404 ms) : 0, 8404
Telemetry [candidate] (8.36 ms) : 0, 8360
section profiling
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (718.934 ms) : 0, 718934
BytebuddyAgent [candidate] (719.378 ms) : 0, 719378
GlobalTracer [baseline] (223.473 ms) : 0, 223473
GlobalTracer [candidate] (222.858 ms) : 0, 222858
AppSec [baseline] (31.299 ms) : 0, 31299
AppSec [candidate] (31.247 ms) : 0, 31247
Debugger [baseline] (7.335 ms) : 0, 7335
Debugger [candidate] (6.941 ms) : 0, 6941
Remote Config [baseline] (717.886 µs) : 0, 718
Remote Config [candidate] (699.804 µs) : 0, 700
Telemetry [baseline] (15.616 ms) : 0, 15616
Telemetry [candidate] (16.077 ms) : 0, 16077
ProfilingAgent [baseline] (101.085 ms) : 0, 101085
ProfilingAgent [candidate] (102.384 ms) : 0, 102384
Profiling [baseline] (101.678 ms) : 0, 101678
Profiling [candidate] (103.005 ms) : 0, 103005
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015198
Total [baseline] (8.662 s) : 0, 8661691
Agent [candidate] (1.008 s) : 0, 1007882
Total [candidate] (8.677 s) : 0, 8677056
section iast
Agent [baseline] (1.148 s) : 0, 1147543
Total [baseline] (9.266 s) : 0, 9265759
Agent [candidate] (1.144 s) : 0, 1143768
Total [candidate] (9.294 s) : 0, 9294162
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (695.359 ms) : 0, 695359
BytebuddyAgent [candidate] (690.942 ms) : 0, 690942
GlobalTracer [baseline] (249.691 ms) : 0, 249691
GlobalTracer [candidate] (246.319 ms) : 0, 246319
AppSec [baseline] (31.336 ms) : 0, 31336
AppSec [candidate] (31.284 ms) : 0, 31284
Debugger [baseline] (6.454 ms) : 0, 6454
Debugger [candidate] (6.776 ms) : 0, 6776
Remote Config [baseline] (708.516 µs) : 0, 709
Remote Config [candidate] (693.007 µs) : 0, 693
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (9.103 ms) : 0, 9103
section iast
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (811.756 ms) : 0, 811756
BytebuddyAgent [candidate] (810.307 ms) : 0, 810307
GlobalTracer [baseline] (237.745 ms) : 0, 237745
GlobalTracer [candidate] (236.073 ms) : 0, 236073
IAST [baseline] (26.125 ms) : 0, 26125
IAST [candidate] (25.925 ms) : 0, 25925
AppSec [baseline] (33.967 ms) : 0, 33967
AppSec [candidate] (33.588 ms) : 0, 33588
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (601.009 µs) : 0, 601
Remote Config [candidate] (581.831 µs) : 0, 582
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.437 ms) : 0, 8437
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section baseline
no_agent (4.303 ms) : 4255, 4351
. : milestone, 4303,
iast (10.423 ms) : 10243, 10602
. : milestone, 10423,
iast_FULL (14.706 ms) : 14412, 15000
. : milestone, 14706,
iast_GLOBAL (10.717 ms) : 10526, 10907
. : milestone, 10717,
profiling (8.855 ms) : 8720, 8990
. : milestone, 8855,
tracing (7.986 ms) : 7872, 8099
. : milestone, 7986,
section candidate
no_agent (4.329 ms) : 4280, 4378
. : milestone, 4329,
iast (9.919 ms) : 9742, 10097
. : milestone, 9919,
iast_FULL (14.208 ms) : 13921, 14495
. : milestone, 14208,
iast_GLOBAL (10.942 ms) : 10747, 11137
. : milestone, 10942,
profiling (9.061 ms) : 8916, 9205
. : milestone, 9061,
tracing (7.927 ms) : 7804, 8051
. : milestone, 7927,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section baseline
no_agent (36.212 ms) : 35927, 36497
. : milestone, 36212,
appsec (49.753 ms) : 49310, 50195
. : milestone, 49753,
code_origins (44.347 ms) : 43961, 44734
. : milestone, 44347,
iast (45.131 ms) : 44728, 45534
. : milestone, 45131,
profiling (47.157 ms) : 46732, 47582
. : milestone, 47157,
tracing (44.739 ms) : 44363, 45116
. : milestone, 44739,
section candidate
no_agent (36.275 ms) : 35985, 36564
. : milestone, 36275,
appsec (46.367 ms) : 45954, 46780
. : milestone, 46367,
code_origins (44.476 ms) : 44094, 44857
. : milestone, 44476,
iast (45.059 ms) : 44662, 45455
. : milestone, 45059,
profiling (48.484 ms) : 48038, 48931
. : milestone, 48484,
tracing (41.971 ms) : 41615, 42327
. : milestone, 41971,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.694 ms) : 3477, 3910
. : milestone, 3694,
iast (2.199 ms) : 2136, 2261
. : milestone, 2199,
iast_GLOBAL (2.232 ms) : 2169, 2295
. : milestone, 2232,
profiling (2.03 ms) : 1980, 2080
. : milestone, 2030,
tracing (2.009 ms) : 1960, 2057
. : milestone, 2009,
section candidate
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (2.492 ms) : 2439, 2544
. : milestone, 2492,
iast (2.195 ms) : 2132, 2258
. : milestone, 2195,
iast_GLOBAL (2.232 ms) : 2170, 2295
. : milestone, 2232,
profiling (2.057 ms) : 2005, 2108
. : milestone, 2057,
tracing (2.02 ms) : 1970, 2069
. : milestone, 2020,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~8a31509b86, baseline=1.54.0-SNAPSHOT~d76b984a7f
dateFormat X
axisFormat %s
section baseline
no_agent (15.621 s) : 15621000, 15621000
. : milestone, 15621000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.659 s) : 18659000, 18659000
. : milestone, 18659000,
iast_GLOBAL (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
profiling (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
tracing (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
section candidate
no_agent (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
appsec (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
iast (18.322 s) : 18322000, 18322000
. : milestone, 18322000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (15.517 s) : 15517000, 15517000
. : milestone, 15517000,
tracing (15.209 s) : 15209000, 15209000
. : milestone, 15209000,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]