-
Notifications
You must be signed in to change notification settings - Fork 312
Update task naming in gradle files PT 1 #9608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: db9877f | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.01 s) : 0, 1009933
Total [baseline] (8.663 s) : 0, 8662854
Agent [candidate] (1.007 s) : 0, 1007410
Total [candidate] (8.644 s) : 0, 8644338
section iast
Agent [baseline] (1.143 s) : 0, 1143436
Total [baseline] (9.259 s) : 0, 9258764
Agent [candidate] (1.156 s) : 0, 1155638
Total [candidate] (9.278 s) : 0, 9278262
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (692.424 ms) : 0, 692424
BytebuddyAgent [candidate] (689.653 ms) : 0, 689653
GlobalTracer [baseline] (247.631 ms) : 0, 247631
GlobalTracer [candidate] (248.35 ms) : 0, 248350
AppSec [baseline] (31.15 ms) : 0, 31150
AppSec [candidate] (30.832 ms) : 0, 30832
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.38 ms) : 0, 6380
Remote Config [baseline] (687.346 µs) : 0, 687
Remote Config [candidate] (683.384 µs) : 0, 683
Telemetry [baseline] (9.108 ms) : 0, 9108
Telemetry [candidate] (8.947 ms) : 0, 8947
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (808.844 ms) : 0, 808844
BytebuddyAgent [candidate] (817.737 ms) : 0, 817737
GlobalTracer [baseline] (237.126 ms) : 0, 237126
GlobalTracer [candidate] (239.905 ms) : 0, 239905
AppSec [baseline] (33.712 ms) : 0, 33712
AppSec [candidate] (33.827 ms) : 0, 33827
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.048 ms) : 0, 6048
Remote Config [baseline] (612.101 µs) : 0, 612
Remote Config [candidate] (605.555 µs) : 0, 606
Telemetry [baseline] (8.287 ms) : 0, 8287
Telemetry [candidate] (8.417 ms) : 0, 8417
IAST [baseline] (26.011 ms) : 0, 26011
IAST [candidate] (26.201 ms) : 0, 26201
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012161
Total [baseline] (10.675 s) : 0, 10675327
Agent [candidate] (1.014 s) : 0, 1013943
Total [candidate] (10.699 s) : 0, 10699015
section appsec
Agent [baseline] (1.184 s) : 0, 1184376
Total [baseline] (10.959 s) : 0, 10959410
Agent [candidate] (1.191 s) : 0, 1190553
Total [candidate] (10.953 s) : 0, 10953313
section iast
Agent [baseline] (1.155 s) : 0, 1155132
Total [baseline] (10.951 s) : 0, 10950506
Agent [candidate] (1.145 s) : 0, 1144558
Total [candidate] (10.846 s) : 0, 10846349
section profiling
Agent [baseline] (1.171 s) : 0, 1171379
Total [baseline] (11.126 s) : 0, 11125570
Agent [candidate] (1.151 s) : 0, 1150753
Total [candidate] (10.997 s) : 0, 10997314
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (693.024 ms) : 0, 693024
BytebuddyAgent [candidate] (693.975 ms) : 0, 693975
GlobalTracer [baseline] (249.231 ms) : 0, 249231
GlobalTracer [candidate] (250.081 ms) : 0, 250081
AppSec [baseline] (31.059 ms) : 0, 31059
AppSec [candidate] (31.092 ms) : 0, 31092
Debugger [baseline] (6.453 ms) : 0, 6453
Debugger [candidate] (6.437 ms) : 0, 6437
Remote Config [baseline] (685.901 µs) : 0, 686
Remote Config [candidate] (678.763 µs) : 0, 679
Telemetry [baseline] (8.98 ms) : 0, 8980
Telemetry [candidate] (8.935 ms) : 0, 8935
section appsec
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (709.888 ms) : 0, 709888
BytebuddyAgent [candidate] (714.225 ms) : 0, 714225
GlobalTracer [baseline] (239.13 ms) : 0, 239130
GlobalTracer [candidate] (240.679 ms) : 0, 240679
AppSec [baseline] (172.575 ms) : 0, 172575
AppSec [candidate] (172.52 ms) : 0, 172520
Debugger [baseline] (5.942 ms) : 0, 5942
Debugger [candidate] (6.02 ms) : 0, 6020
Remote Config [baseline] (638.169 µs) : 0, 638
Remote Config [candidate] (627.276 µs) : 0, 627
Telemetry [baseline] (9.173 ms) : 0, 9173
Telemetry [candidate] (9.21 ms) : 0, 9210
IAST [baseline] (24.426 ms) : 0, 24426
IAST [candidate] (24.632 ms) : 0, 24632
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (815.552 ms) : 0, 815552
BytebuddyAgent [candidate] (809.912 ms) : 0, 809912
GlobalTracer [baseline] (240.588 ms) : 0, 240588
GlobalTracer [candidate] (237.014 ms) : 0, 237014
AppSec [baseline] (34.263 ms) : 0, 34263
AppSec [candidate] (33.832 ms) : 0, 33832
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (5.989 ms) : 0, 5989
Remote Config [baseline] (608.231 µs) : 0, 608
Remote Config [candidate] (576.917 µs) : 0, 577
Telemetry [baseline] (8.482 ms) : 0, 8482
Telemetry [candidate] (8.251 ms) : 0, 8251
IAST [baseline] (26.557 ms) : 0, 26557
IAST [candidate] (26.015 ms) : 0, 26015
section profiling
ProfilingAgent [baseline] (103.833 ms) : 0, 103833
ProfilingAgent [candidate] (100.88 ms) : 0, 100880
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (730.459 ms) : 0, 730459
BytebuddyAgent [candidate] (717.695 ms) : 0, 717695
GlobalTracer [baseline] (227.547 ms) : 0, 227547
GlobalTracer [candidate] (223.773 ms) : 0, 223773
AppSec [baseline] (31.925 ms) : 0, 31925
AppSec [candidate] (31.188 ms) : 0, 31188
Debugger [baseline] (7.375 ms) : 0, 7375
Debugger [candidate] (6.546 ms) : 0, 6546
Remote Config [baseline] (727.973 µs) : 0, 728
Remote Config [candidate] (704.417 µs) : 0, 704
Telemetry [baseline] (14.771 ms) : 0, 14771
Telemetry [candidate] (16.342 ms) : 0, 16342
Profiling [baseline] (104.435 ms) : 0, 104435
Profiling [candidate] (101.488 ms) : 0, 101488
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (36.935 ms) : 36638, 37232
. : milestone, 36935,
appsec (50.324 ms) : 49884, 50763
. : milestone, 50324,
code_origins (44.515 ms) : 44140, 44891
. : milestone, 44515,
iast (44.754 ms) : 44388, 45120
. : milestone, 44754,
profiling (50.319 ms) : 49872, 50766
. : milestone, 50319,
tracing (44.462 ms) : 44072, 44851
. : milestone, 44462,
section candidate
no_agent (36.64 ms) : 36350, 36930
. : milestone, 36640,
appsec (48.807 ms) : 48362, 49251
. : milestone, 48807,
code_origins (43.661 ms) : 43287, 44035
. : milestone, 43661,
iast (48.38 ms) : 47954, 48805
. : milestone, 48380,
profiling (49.844 ms) : 49375, 50312
. : milestone, 49844,
tracing (44.874 ms) : 44494, 45255
. : milestone, 44874,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (4.26 ms) : 4211, 4309
. : milestone, 4260,
iast (10.132 ms) : 9958, 10306
. : milestone, 10132,
iast_FULL (15.339 ms) : 15025, 15652
. : milestone, 15339,
iast_GLOBAL (10.332 ms) : 10149, 10515
. : milestone, 10332,
profiling (8.924 ms) : 8787, 9060
. : milestone, 8924,
tracing (7.613 ms) : 7504, 7722
. : milestone, 7613,
section candidate
no_agent (4.248 ms) : 4201, 4295
. : milestone, 4248,
iast (10.234 ms) : 10062, 10407
. : milestone, 10234,
iast_FULL (14.928 ms) : 14629, 15226
. : milestone, 14928,
iast_GLOBAL (11.199 ms) : 11000, 11399
. : milestone, 11199,
profiling (8.88 ms) : 8731, 9028
. : milestone, 8880,
tracing (7.415 ms) : 7313, 7518
. : milestone, 7415,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
appsec (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
iast (18.509 s) : 18509000, 18509000
. : milestone, 18509000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
tracing (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
section candidate
no_agent (15.57 s) : 15570000, 15570000
. : milestone, 15570000,
appsec (15.276 s) : 15276000, 15276000
. : milestone, 15276000,
iast (18.333 s) : 18333000, 18333000
. : milestone, 18333000,
iast_GLOBAL (18.037 s) : 18037000, 18037000
. : milestone, 18037000,
profiling (15.447 s) : 15447000, 15447000
. : milestone, 15447000,
tracing (15.093 s) : 15093000, 15093000
. : milestone, 15093000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~db9877f0e8, baseline=1.54.0-SNAPSHOT~b09dcc584a
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.64 ms) : 3426, 3854
. : milestone, 3640,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.061 ms) : 2009, 2112
. : milestone, 2061,
tracing (2.004 ms) : 1956, 2053
. : milestone, 2004,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.726 ms) : 3509, 3943
. : milestone, 3726,
iast (2.196 ms) : 2134, 2259
. : milestone, 2196,
iast_GLOBAL (2.253 ms) : 2190, 2316
. : milestone, 2253,
profiling (2.035 ms) : 1984, 2085
. : milestone, 2035,
tracing (2.024 ms) : 1975, 2074
. : milestone, 2024,
|
gradle/jacoco.gradle
Outdated
} | ||
|
||
jacocoTestCoverageVerification { | ||
tasks.named("jacocoTestCoverageVerification") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, would it be better to use this variant: tasks.named<JacocoCoverageVerification>("jacocoTestCoverageVerification")
here and similar places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 This would make it more type-safe! I'll do this.
What Does This Do
Update task naming to
tasks.named("EXAMPLE_TASK")
in thetest-published-dependencies/
andgradle/
directories to use lazy APIsMotivation
Build improvements
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]