-
Notifications
You must be signed in to change notification settings - Fork 312
Remove extra .configure
method
#9609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎯 Code Coverage 🔗 Commit SHA: 4adde29 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1012999
Total [baseline] (8.691 s) : 0, 8690598
Agent [candidate] (1.008 s) : 0, 1008336
Total [candidate] (8.678 s) : 0, 8678095
section iast
Agent [baseline] (1.145 s) : 0, 1144816
Total [baseline] (9.33 s) : 0, 9330164
Agent [candidate] (1.142 s) : 0, 1141981
Total [candidate] (9.26 s) : 0, 9259933
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (694.397 ms) : 0, 694397
BytebuddyAgent [candidate] (690.221 ms) : 0, 690221
GlobalTracer [baseline] (248.918 ms) : 0, 248918
GlobalTracer [candidate] (248.517 ms) : 0, 248517
AppSec [baseline] (31.041 ms) : 0, 31041
AppSec [candidate] (30.959 ms) : 0, 30959
Debugger [baseline] (6.352 ms) : 0, 6352
Debugger [candidate] (6.387 ms) : 0, 6387
Remote Config [baseline] (677.309 µs) : 0, 677
Remote Config [candidate] (677.685 µs) : 0, 678
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (9.02 ms) : 0, 9020
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (810.092 ms) : 0, 810092
BytebuddyAgent [candidate] (807.378 ms) : 0, 807378
GlobalTracer [baseline] (237.236 ms) : 0, 237236
GlobalTracer [candidate] (237.038 ms) : 0, 237038
IAST [baseline] (26.047 ms) : 0, 26047
IAST [candidate] (26.086 ms) : 0, 26086
AppSec [baseline] (33.723 ms) : 0, 33723
AppSec [candidate] (33.844 ms) : 0, 33844
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (588.967 µs) : 0, 589
Remote Config [candidate] (582.971 µs) : 0, 583
Telemetry [baseline] (8.302 ms) : 0, 8302
Telemetry [candidate] (8.306 ms) : 0, 8306
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1014066
Total [baseline] (10.752 s) : 0, 10751876
Agent [candidate] (1.009 s) : 0, 1009367
Total [candidate] (10.719 s) : 0, 10719399
section appsec
Agent [baseline] (1.189 s) : 0, 1188600
Total [baseline] (11.112 s) : 0, 11112374
Agent [candidate] (1.188 s) : 0, 1187590
Total [candidate] (10.975 s) : 0, 10975184
section iast
Agent [baseline] (1.163 s) : 0, 1162597
Total [baseline] (10.979 s) : 0, 10978525
Agent [candidate] (1.154 s) : 0, 1154364
Total [candidate] (10.998 s) : 0, 10997815
section profiling
Agent [baseline] (1.156 s) : 0, 1155651
Total [baseline] (11.121 s) : 0, 11121270
Agent [candidate] (1.151 s) : 0, 1151314
Total [candidate] (11.071 s) : 0, 11070635
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (694.386 ms) : 0, 694386
BytebuddyAgent [candidate] (690.541 ms) : 0, 690541
GlobalTracer [baseline] (249.496 ms) : 0, 249496
GlobalTracer [candidate] (249.009 ms) : 0, 249009
AppSec [baseline] (31.295 ms) : 0, 31295
AppSec [candidate] (31.141 ms) : 0, 31141
Debugger [baseline] (6.45 ms) : 0, 6450
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (684.934 µs) : 0, 685
Remote Config [candidate] (670.951 µs) : 0, 671
Telemetry [baseline] (8.939 ms) : 0, 8939
Telemetry [candidate] (8.966 ms) : 0, 8966
section appsec
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (712.911 ms) : 0, 712911
BytebuddyAgent [candidate] (711.856 ms) : 0, 711856
GlobalTracer [baseline] (239.832 ms) : 0, 239832
GlobalTracer [candidate] (239.807 ms) : 0, 239807
IAST [baseline] (24.663 ms) : 0, 24663
IAST [candidate] (24.578 ms) : 0, 24578
AppSec [baseline] (171.859 ms) : 0, 171859
AppSec [candidate] (172.13 ms) : 0, 172130
Debugger [baseline] (5.996 ms) : 0, 5996
Debugger [candidate] (6.801 ms) : 0, 6801
Remote Config [baseline] (652.759 µs) : 0, 653
Remote Config [candidate] (634.095 µs) : 0, 634
Telemetry [baseline] (10.048 ms) : 0, 10048
Telemetry [candidate] (9.125 ms) : 0, 9125
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (823.222 ms) : 0, 823222
BytebuddyAgent [candidate] (817.364 ms) : 0, 817364
GlobalTracer [baseline] (240.25 ms) : 0, 240250
GlobalTracer [candidate] (238.524 ms) : 0, 238524
IAST [baseline] (26.453 ms) : 0, 26453
IAST [candidate] (26.473 ms) : 0, 26473
AppSec [baseline] (34.359 ms) : 0, 34359
AppSec [candidate] (33.853 ms) : 0, 33853
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.106 ms) : 0, 6106
Remote Config [baseline] (606.794 µs) : 0, 607
Remote Config [candidate] (610.509 µs) : 0, 611
Telemetry [baseline] (8.604 ms) : 0, 8604
Telemetry [candidate] (8.375 ms) : 0, 8375
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (720.803 ms) : 0, 720803
BytebuddyAgent [candidate] (718.886 ms) : 0, 718886
GlobalTracer [baseline] (224.269 ms) : 0, 224269
GlobalTracer [candidate] (223.161 ms) : 0, 223161
AppSec [baseline] (31.499 ms) : 0, 31499
AppSec [candidate] (31.186 ms) : 0, 31186
Debugger [baseline] (7.382 ms) : 0, 7382
Debugger [candidate] (7.284 ms) : 0, 7284
Remote Config [baseline] (714.925 µs) : 0, 715
Remote Config [candidate] (705.788 µs) : 0, 706
Telemetry [baseline] (15.565 ms) : 0, 15565
Telemetry [candidate] (15.34 ms) : 0, 15340
ProfilingAgent [baseline] (101.756 ms) : 0, 101756
ProfilingAgent [candidate] (101.095 ms) : 0, 101095
Profiling [baseline] (102.345 ms) : 0, 102345
Profiling [candidate] (101.709 ms) : 0, 101709
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section baseline
no_agent (37.518 ms) : 37219, 37817
. : milestone, 37518,
appsec (46.39 ms) : 45984, 46797
. : milestone, 46390,
code_origins (42.263 ms) : 41902, 42624
. : milestone, 42263,
iast (43.059 ms) : 42707, 43411
. : milestone, 43059,
profiling (48.372 ms) : 47925, 48819
. : milestone, 48372,
tracing (44.567 ms) : 44185, 44948
. : milestone, 44567,
section candidate
no_agent (37.374 ms) : 37074, 37674
. : milestone, 37374,
appsec (46.738 ms) : 46337, 47139
. : milestone, 46738,
code_origins (43.565 ms) : 43193, 43937
. : milestone, 43565,
iast (44.379 ms) : 43980, 44777
. : milestone, 44379,
profiling (50.97 ms) : 50458, 51483
. : milestone, 50970,
tracing (45.656 ms) : 45258, 46053
. : milestone, 45656,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section baseline
no_agent (4.317 ms) : 4269, 4365
. : milestone, 4317,
iast (9.979 ms) : 9801, 10157
. : milestone, 9979,
iast_FULL (13.856 ms) : 13582, 14131
. : milestone, 13856,
iast_GLOBAL (10.513 ms) : 10327, 10699
. : milestone, 10513,
profiling (8.563 ms) : 8418, 8707
. : milestone, 8563,
tracing (7.69 ms) : 7576, 7803
. : milestone, 7690,
section candidate
no_agent (4.351 ms) : 4301, 4400
. : milestone, 4351,
iast (9.96 ms) : 9793, 10126
. : milestone, 9960,
iast_FULL (13.834 ms) : 13560, 14108
. : milestone, 13834,
iast_GLOBAL (11.235 ms) : 11035, 11435
. : milestone, 11235,
profiling (8.723 ms) : 8586, 8860
. : milestone, 8723,
tracing (7.647 ms) : 7529, 7765
. : milestone, 7647,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.706 ms) : 3489, 3923
. : milestone, 3706,
iast (2.189 ms) : 2126, 2251
. : milestone, 2189,
iast_GLOBAL (2.239 ms) : 2176, 2303
. : milestone, 2239,
profiling (2.063 ms) : 2011, 2115
. : milestone, 2063,
tracing (2.013 ms) : 1965, 2062
. : milestone, 2013,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.646 ms) : 3435, 3856
. : milestone, 3646,
iast (2.2 ms) : 2137, 2263
. : milestone, 2200,
iast_GLOBAL (2.243 ms) : 2180, 2306
. : milestone, 2243,
profiling (2.04 ms) : 1989, 2090
. : milestone, 2040,
tracing (2.014 ms) : 1965, 2063
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~4adde29a5a, baseline=1.54.0-SNAPSHOT~9f07fa1a06
dateFormat X
axisFormat %s
section baseline
no_agent (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
appsec (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
iast (18.294 s) : 18294000, 18294000
. : milestone, 18294000,
iast_GLOBAL (17.923 s) : 17923000, 17923000
. : milestone, 17923000,
profiling (16.231 s) : 16231000, 16231000
. : milestone, 16231000,
tracing (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
section candidate
no_agent (15.335 s) : 15335000, 15335000
. : milestone, 15335000,
appsec (15.096 s) : 15096000, 15096000
. : milestone, 15096000,
iast (18.707 s) : 18707000, 18707000
. : milestone, 18707000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
. : milestone, 18096000,
profiling (15.458 s) : 15458000, 15458000
. : milestone, 15458000,
tracing (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
* First batch * Second batch * Third batch
For reference,
|
What Does This Do
named {}
andregister {}
Gradle methods already invoke.configure {}
, so removing the extra.configure
doesn't change existing behavior or laziness.Motivation
Clean up build
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]